From jhelfman@experts-exchange.com  Thu Mar 22 00:04:45 2012
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AD1A6106564A;
	Thu, 22 Mar 2012 00:04:45 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 8BDF38FC0A;
	Thu, 22 Mar 2012 00:04:45 +0000 (UTC)
Received: from mail.dw.redsrci.com (localhost [127.0.0.1])
	by mail.dw.redsrci.com (Postfix) with ESMTP id 218176F17CC;
	Wed, 21 Mar 2012 17:04:45 -0700 (PDT)
Received: from mail.dw.redsrci.com ([127.0.0.1])
	by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id SzBaN-uBh17X; Wed, 21 Mar 2012 17:04:44 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.dw.redsrci.com (Postfix) with SMTP id F19676F17C2;
	Wed, 21 Mar 2012 17:04:44 -0700 (PDT)
Received: (nullmailer pid 58952 invoked by uid 1001);
	Thu, 22 Mar 2012 00:03:54 -0000
Message-Id: <1332374634.553577.58951.nullmailer@experts-exchange.com>
Date: Wed, 21 Mar 2012 17:03:54 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: scheidell@FreeBSD.org
Subject: [PATCH] mail/p5-Mail-SpamAssassin: add support for AutoWhiteList (AWL)
X-Send-Pr-Version: 3.113
X-GNATS-Notify: zi@FreeBSD.org

>Number:         166310
>Category:       ports
>Synopsis:       [PATCH] mail/p5-Mail-SpamAssassin: add support for AutoWhiteList (AWL)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    scheidell
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 22 00:10:07 UTC 2012
>Closed-Date:    Sun Apr 08 16:50:09 UTC 2012
>Last-Modified:  Sun Apr 08 16:50:09 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
>Description:
It was noted that the AWL plugin has been deprecated in ports/159365.

I can't find any supporting information to this statement.
According to documentation at http://wiki.apache.org/spamassassin/AutoWhitelist

"In 3.3, the plugin is not loaded by default."

In the notes for 3.3.0, the following is stated:

"- as the plugin AWL is no longer loaded by default, to continue using it
  the following line is needed in one of the .pre files (e.g. local.pre):
    loadplugin Mail::SpamAssassin::Plugin::AWL"

Releases since then do not note a deprecation of the plugin, and it is
still available in the source distribution.

Port maintainer (scheidell@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_4 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- p5-Mail-SpamAssassin-3.3.2_7.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/mail/p5-Mail-SpamAssassin/Makefile,v
retrieving revision 1.152
diff -u -r1.152 Makefile
--- Makefile	13 Mar 2012 16:15:10 -0000	1.152
+++ Makefile	21 Mar 2012 23:56:45 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	Mail-SpamAssassin
 PORTVERSION=	3.3.2
-PORTREVISION?=	6
+PORTREVISION?=	7
 CATEGORIES?=	mail perl5
 MASTER_SITES=	${MASTER_SITE_APACHE:S/$/:apache/} ${MASTER_SITE_PERL_CPAN:S/$/:cpan/}
 MASTER_SITE_SUBDIR=	spamassassin/source/:apache Mail/:cpan
@@ -51,7 +51,8 @@
 		RAZOR "Add Vipul's Razor support" on \
 		SPF_QUERY "Add SPF query support" off \
 		RELAY_COUNTRY "Relay country support" off \
-		DCC "Add DCC support (see LICENSE)" off
+		DCC "Add DCC support (see LICENSE)" off \
+		AWL "Add AutoWhiteList Support" off
 
 SUB_FILES=	pkg-install
 SUB_LIST=	USER=${USERS} GROUP=${GROUPS} INSTALL="${INSTALL}"
@@ -189,6 +190,9 @@
 .if defined(WITH_SACOMPILE)
 	${REINPLACE_CMD} -e '/Rule2XSBody/s/^# loadplugin/loadplugin/' ${WRKSRC}/rules/v320.pre
 .endif
+.if defined(WITH_AWL)
+	${REINPLACE_CMD} -e '/AWL/s/^#loadplugin/loadplugin/' ${WRKSRC}/rules/v310.pre
+.endif
 
 post-build:
 	@(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} spamc/libspamc.so)
--- p5-Mail-SpamAssassin-3.3.2_7.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->scheidell 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Mar 22 00:10:17 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166310 
State-Changed-From-To: open->closed 
State-Changed-By: scheidell 
State-Changed-When: Thu Mar 22 00:30:26 UTC 2012 
State-Changed-Why:  
This option will not be added. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166310 

From: Ryan Steinmetz <zi@FreeBSD.org>
To: Jason Helfman <jgh@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org, scheidell@FreeBSD.org
Subject: Re: ports/166310: [PATCH] mail/p5-Mail-SpamAssassin: add support for
 AutoWhiteList (AWL)
Date: Wed, 21 Mar 2012 21:13:50 -0400

 As a fellow p5-Mail-SpamAssassin user, I would be interested in seeing
 this option return to the port.
 
 It doesn't even necessarily need to be an OPTION.  Simply having the
 WITH_* logic in the port would enable those interested to define the
 options they want in /etc/make.conf.
 
 This would help ensure that the port doesn't overwrite their custom
 changes that they are forced to do now.

From: Michael Scheidell <scheidell@freebsd.org>
To: Ryan Steinmetz <zi@FreeBSD.org>
Cc: Jason Helfman <jgh@FreeBSD.org>, <FreeBSD-gnats-submit@FreeBSD.org>
Subject: Re: ports/166310: [PATCH] mail/p5-Mail-SpamAssassin: add support
 for AutoWhiteList (AWL)
Date: Wed, 21 Mar 2012 21:46:24 -0400

 On 3/21/12 9:13 PM, Ryan Steinmetz wrote:
 > As a fellow p5-Mail-SpamAssassin user, I would be interested in seeing
 > this option return to the port.
 >
 > It doesn't even necessarily need to be an OPTION.  Simply having the
 > WITH_* logic in the port would enable those interested to define the
 > options they want in /etc/make.conf.
 >
 > This would help ensure that the port doesn't overwrite their custom
 > changes that they are forced to do now.
 I was not aware it was stomping on legacy settings. I will look at it 
 tomorrow.
 
 -- 
 Michael Scheidell, CTO
  >*| * SECNAP Network Security Corporation
 d: +1.561.948.2259
 w: http://people.freebsd.org/~scheidell
State-Changed-From-To: closed->open 
State-Changed-By: scheidell 
State-Changed-When: Thu Mar 22 02:01:25 UTC 2012 
State-Changed-Why:  
Submitter states that without a patch, reinstall stomps on existing 
configurations. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166310 
State-Changed-From-To: open->feedback 
State-Changed-By: scheidell 
State-Changed-When: Thu Mar 22 17:06:46 UTC 2012 
State-Changed-Why:  
Please help me understand the problem.  I am not able to duplicate the issue. 
Maybe if you explained in in depth, it would help. 

This is on our site, currently.  (default install of SA, AWL plugin disabled): 

grep AWL *.pre* 
v310.pre:#loadplugin Mail::SpamAssassin::Plugin::AWL 
v310.pre.sample:#loadplugin Mail::SpamAssassin::Plugin::AWL 

I edited v310.pre to simulate a legacy, or custom installation: (I enabled AWL plugin) 

grep AWL *.pre* 
v310.pre:loadplugin Mail::SpamAssassin::Plugin::AWL 
v310.pre.sample:#loadplugin Mail::SpamAssassin::Plugin::AWL 

I then deleted the package: (custom v310.pre is left alone) 

grep AWL *.pre* 
v310.pre:loadplugin Mail::SpamAssassin::Plugin::AWL 

I then installed the package:  (custom v310.pre is left alone). 
No clobbering I can see. 

grep AWL *.pre* 
v310.pre:loadplugin Mail::SpamAssassin::Plugin::AWL 
v310.pre.sample:#loadplugin Mail::SpamAssassin::Plugin::AWL 

Pretend I am (stupid|stubborn). please give me the steps you took in order to clobber an existing v310.pre with AWL enabled. 
Or am I missing the point? 

there are 39 (optional), plugins for current SA.   
grep loadplugin *.pre | wc -l 

Again, pretend I am (stupid|stubborn).  Let me know how the current SA port clobbers the v310.pre so I can make sure that your  
patch/fix actually does what you want it to. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=166310 

From: Michael Scheidell <scheidell@FreeBSD.org>
To: <bug-followup@FreeBSD.org>, <jgh@FreeBSD.org>, Ryan Steinmetz
	<zi@FreeBSD.org>
Cc:  
Subject: Re: ports/166310: [PATCH] mail/p5-Mail-SpamAssassin: add support
 for AutoWhiteList (AWL)
Date: Wed, 4 Apr 2012 10:08:55 -0400

 I am about to do a repocopy -> p5-Mail-SpamAssassin-devel, and commit a 
 patch to add conflicts.
 Jason:
 
 We talked about supporting a ../mail/SpamAssassin-gui/menu/jgh optional 
 port (where you could add all kinds of options).
 It might be a good place to support some of the less used and/or 
 specialized options.  Some come to mind, like the language/charset, 
 freemail/ things like that.
 
 As I get ready to commit this, do you want me to add something like:
 
 .ifdef (WITH_SA_MORE_BETTER_GOODER_OPTIONS)
 .include ../SpamAssassin-(something)?
 .endif
 
 or just make sure you have a slave port that works?
 
 any place in post-config/config/etc that you want ?
 Want to post a patch to Makefile?  pkg-install?
 I think pkg-plist should be ok.
 
 -- 
 Michael Scheidell, CTO
  >*| * SECNAP Network Security Corporation
 d: +1.561.948.2259
 w: http://people.freebsd.org/~scheidell

From: Jason Helfman <jgh@FreeBSD.org>
To: Michael Scheidell <scheidell@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, Ryan Steinmetz <zi@FreeBSD.org>
Subject: Re: ports/166310: [PATCH] mail/p5-Mail-SpamAssassin: add support for
 AutoWhiteList (AWL)
Date: Wed, 4 Apr 2012 09:24:51 -0700

 On Wed, Apr 04, 2012 at 10:08:55AM -0400, Michael Scheidell thus spake:
 >I am about to do a repocopy -> p5-Mail-SpamAssassin-devel, and commit a
 >patch to add conflicts.
 
 Great, glad to hear you are taking this on!
 
 >Jason:
 >
 >We talked about supporting a ../mail/SpamAssassin-gui/menu/jgh optional
 >port (where you could add all kinds of options).
 >It might be a good place to support some of the less used and/or
 >specialized options.  Some come to mind, like the language/charset,
 >freemail/ things like that.
 >
 >As I get ready to commit this, do you want me to add something like:
 >
 >.ifdef (WITH_SA_MORE_BETTER_GOODER_OPTIONS)
 >.include ../SpamAssassin-(something)?
 >.endif
 
 Sure, that sounds good, or at least have the support available, and then
 when I can confirm it works, we can add bits like this in.
 >
 >or just make sure you have a slave port that works?
 
 Accounting for a value such as IS_SLAVE/IS_MASTER throughout your Makefile,
 can only help support such as direction.
 >
 >any place in post-config/config/etc that you want ?
 >Want to post a patch to Makefile?  pkg-install?
 >I think pkg-plist should be ok.
 
 I don't have time to patch the Makefile at the moment, but I can look into
 working with you in optimal slave support, and any other tweaks that we can
 think of.
 
 Thanks Michael!
 
 --
 Jason Helfman         | FreeBSD Committer
 jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
State-Changed-From-To: feedback->closed 
State-Changed-By: scheidell 
State-Changed-When: Sun Apr 8 16:50:08 UTC 2012 
State-Changed-Why:  
Closing due to age, and, no evidence installing sa clobbers existing AWL 
config file.  submitter is encouraged to look at either a slave port, or 
a port that can call additional options in this port.  For an example of 
an SA slave port,  please see this pr that I just closed. 
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165765 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166310 
>Unformatted:
