From glarkin@sourcehosting.net  Fri Mar 16 16:02:05 2012
Return-Path: <glarkin@sourcehosting.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D347A106564A;
	Fri, 16 Mar 2012 16:02:05 +0000 (UTC)
	(envelope-from glarkin@sourcehosting.net)
Received: from mail1.sourcehosting.net (mail1.sourcehosting.net [74.205.51.45])
	by mx1.freebsd.org (Postfix) with ESMTP id AA5768FC15;
	Fri, 16 Mar 2012 16:02:05 +0000 (UTC)
Received: from 68-189-245-235.dhcp.oxfr.ma.charter.com ([68.189.245.235] helo=imac.entropy.prv)
	by mail1.sourcehosting.net with esmtp (Exim 4.73 (FreeBSD))
	(envelope-from <glarkin@sourcehosting.net>)
	id 1S8Za9-000OTk-2g; Fri, 16 Mar 2012 12:01:59 -0400
Received: from sourcehosting.net (unknown [192.168.216.128])
	by imac.entropy.prv (Postfix) with SMTP id A176A100B8D5;
	Fri, 16 Mar 2012 12:00:44 -0400 (EDT)
Received: (nullmailer pid 20844 invoked by uid 1001);
	Fri, 16 Mar 2012 16:00:44 -0000
Message-Id: <1331913644.433334.20843.nullmailer@sourcehosting.net>
Date: Fri, 16 Mar 2012 12:00:44 -0400
From: Greg Larkin <glarkin@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: rea@FreeBSD.org
Subject: [PATCH] mail/exim: configure phase fails with CFLAGS containing a comma
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         166180
>Category:       ports
>Synopsis:       [PATCH] mail/exim: configure phase fails with CFLAGS containing a comma
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rea
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 16 16:10:01 UTC 2012
>Closed-Date:    Sun May 06 06:25:44 UTC 2012
>Last-Modified:  Sun May 06 06:25:44 UTC 2012
>Originator:     Greg Larkin
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD amd64_82.localdomain 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
>Description:
Changed the sed delimiter character from a comma to a vertical bar
to avoid a problem when CFLAGS contains a comma.

Port maintainer (rea@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_4 (mode: change, diff: CVS)
>How-To-Repeat:
Add this to /etc/make.conf and attempt to build the port:

WITH_OPENSSL_BASE=yes
USE_OPENSSL_RPATH=yes
>Fix:

--- exim-4.77_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/mail/exim/Makefile,v
retrieving revision 1.261
diff -u -r1.261 Makefile
--- Makefile	14 Feb 2012 12:45:21 -0000	1.261
+++ Makefile	16 Mar 2012 15:56:25 -0000
@@ -188,7 +188,7 @@
 EXTRA_PATCHES+=	`${FIND} ${PATCHDIR} -name 'wishlist-*.patch'`
 .endif
 
-SEDLIST+=	-e 's,XX_CFLAGS_XX,${CFLAGS},' \
+SEDLIST+=	-e 's|XX_CFLAGS_XX|${CFLAGS}|' \
 		-e 's,XX_PREFIX_XX,${PREFIX},' \
 		-e 's,XX_LOCALBASE_XX,${LOCALBASE},' \
 		-e 's,XX_LOG_FILE_PATH_XX,${LOG_FILE_PATH},' \
--- exim-4.77_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->rea 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Mar 16 16:10:10 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166180 

Date: Sat, 17 Mar 2012 21:45:09 +0400
From: Eygene Ryabinkin <rea@FreeBSD.org>
Sender: rea@codelabs.ru
To: FreeBSD GNATS followup <bug-followup@freebsd.org>
Subject: Re: [PATCH] mail/exim: configure phase fails with CFLAGS containing
 a comma

 Could you, please, try the patch from
   http://codelabs.ru/fbsd/ports/exim/4.77-fix-sed-substitutions.diff
 --=20
 Eygene Ryabinkin                                        ,,,^..^,,,
 [ Life's unfair - but root password helps!           | codelabs.ru ]
 [ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]

From: Greg Larkin <glarkin@FreeBSD.org>
To: bug-followup@FreeBSD.org, Eygene Ryabinkin <rea@freebsd.org>
Cc:  
Subject: Re: ports/166180: [PATCH] mail/exim: configure phase fails with CFLAGS
 containing a comma
Date: Mon, 16 Apr 2012 15:35:00 -0400

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 Hi Eygene,
 
 Sorry for the delay, but your proposed patch worked fine in my environment.
 
 Thank you,
 Greg
 
 - -- 
 Greg Larkin
 
 http://www.FreeBSD.org/           - The Power To Serve
 http://www.sourcehosting.net/     - Ready. Set. Code.
 http://twitter.com/cpucycle/      - Follow you, follow me
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.11 (Darwin)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
 iEYEARECAAYFAk+MdGQACgkQ0sRouByUApC9agCeOF0LYnyqpOUdzt04V6Y40Jd7
 ZQwAnRZzLT5Hy+SHI0I5pMtLcFfmftmI
 =S7Gp
 -----END PGP SIGNATURE-----
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166180: commit references a PR
Date: Sat,  5 May 2012 13:22:29 +0000 (UTC)

 rea         2012-05-05 13:22:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/exim            Makefile 
   Log:
   Handle SEDLIST variables containing commas
   
   ... since we're using comma as the separator for the 's' command.
   
   PR: 166180
   
   Revision  Changes    Path
   1.262     +24 -24    ports/mail/exim/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: rea 
State-Changed-When: Sun May 6 06:25:20 UTC 2012 
State-Changed-Why:  
Fix committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166180 
>Unformatted:
