From jhelfman@experts-exchange.com  Wed Mar 14 21:34:00 2012
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 87C57106566C;
	Wed, 14 Mar 2012 21:34:00 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 6C07F8FC18;
	Wed, 14 Mar 2012 21:34:00 +0000 (UTC)
Received: from mail.dw.redsrci.com (localhost [127.0.0.1])
	by mail.dw.redsrci.com (Postfix) with ESMTP id C6592718558;
	Wed, 14 Mar 2012 14:33:59 -0700 (PDT)
Received: from mail.dw.redsrci.com ([127.0.0.1])
	by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id UtXMrbrdLONC; Wed, 14 Mar 2012 14:33:59 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.dw.redsrci.com (Postfix) with SMTP id A28296EE61C;
	Wed, 14 Mar 2012 14:33:59 -0700 (PDT)
Received: (nullmailer pid 59154 invoked by uid 1001);
	Wed, 14 Mar 2012 21:33:13 -0000
Message-Id: <1331760793.301082.59153.nullmailer@experts-exchange.com>
Date: Wed, 14 Mar 2012 14:33:13 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: lippe@FreeBSD.org
Subject: [PATCH] mail/qmail-scanner: drop invalid post-deinstall target
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         166122
>Category:       ports
>Synopsis:       [PATCH] mail/qmail-scanner: drop invalid post-deinstall target
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jgh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 14 21:40:01 UTC 2012
>Closed-Date:    Thu Mar 29 00:46:51 UTC 2012
>Last-Modified:  Thu Mar 29 00:50:07 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
>Description:
post-deinstall is an invalid target
use pkg-deinstall script, and add to sub_files

Added file(s):
- files/pkg-deinstall.in

Port maintainer (lippe@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_4 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- qmail-scanner-2.01_6.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/mail/qmail-scanner/Makefile,v
retrieving revision 1.26
diff -u -r1.26 Makefile
--- Makefile	27 Jan 2010 01:47:45 -0000	1.26
+++ Makefile	14 Mar 2012 21:33:11 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	qmail-scanner
 PORTVERSION=	2.01
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	mail security
 MASTER_SITES=	SF
 EXTRACT_SUFX=	.tgz
@@ -60,7 +60,7 @@
 		NORMALIZE "Decode encoded headers per MIME Base64" off \
 		CWRAPPER "use C wrapper (no suid perl script needed)" on
 
-SUB_FILES=	pkg-install pkg-message
+SUB_FILES=	pkg-deinstall pkg-install pkg-message
 SUB_LIST+=	QS_USER=${QS_USER} \
 		QS_ID=${QS_ID} \
 		SPOOLDIR=${SPOOLDIR}
@@ -264,11 +264,6 @@
 	@${SETENV} PKG_PREFIX="${PREFIX}" ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
 	@${CAT} ${PKGMESSAGE}
 
-post-deinstall:
-	@${ECHO_MSG}
-	@${ECHO_MSG} "If you're not updating this port, you can delete directory '${SPOOLDIR}'."
-	@${ECHO_MSG} ""
-
 test:
 	@${WRKSRC}/contrib/test_installation.sh -doit
 
Index: files/pkg-deinstall.in
===================================================================
RCS file: files/pkg-deinstall.in
diff -N files/pkg-deinstall.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/pkg-deinstall.in	14 Mar 2012 21:33:11 -0000
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ "$2" = "DEINSTALL" ]; then
+  echo "If you're not updating this port, you can delete directory %%SPOOLDIR%%"
+fi
--- qmail-scanner-2.01_6.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->lippe 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Mar 14 21:40:17 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166122 
Responsible-Changed-From-To: lippe->jgh 
Responsible-Changed-By: jgh 
Responsible-Changed-When: Wed Mar 28 20:33:19 UTC 2012 
Responsible-Changed-Why:  
maintainer timeout (14 days) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166122 
State-Changed-From-To: open->closed 
State-Changed-By: jgh 
State-Changed-When: Thu Mar 29 00:46:49 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166122 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166122: commit references a PR
Date: Thu, 29 Mar 2012 00:45:38 +0000 (UTC)

 jgh         2012-03-29 00:45:25 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/qmail-scanner   Makefile 
   Added files:
     mail/qmail-scanner/files pkg-deinstall.in 
   Log:
   - drop invalid post-deinstall target
   - add pkg-deinstall script and add to SUB_FILES
   
   PR:     ports/166122
   Submitted by:   jgh
   Approved by:    maintainer timeout ( 14 days )
   Feature safe:   yes
   
   Revision  Changes    Path
   1.27      +2 -7      ports/mail/qmail-scanner/Makefile
   1.1       +5 -0      ports/mail/qmail-scanner/files/pkg-deinstall.in (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
