From jhelfman@experts-exchange.com  Wed Mar 14 16:34:58 2012
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 05CBC106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Mar 2012 16:34:58 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id DC9168FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Mar 2012 16:34:57 +0000 (UTC)
Received: from mail.dw.redsrci.com (localhost [127.0.0.1])
	by mail.dw.redsrci.com (Postfix) with ESMTP id 8D6256EEA38;
	Wed, 14 Mar 2012 09:34:57 -0700 (PDT)
Received: from mail.dw.redsrci.com ([127.0.0.1])
	by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id mykRKOYi7naC; Wed, 14 Mar 2012 09:34:57 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.dw.redsrci.com (Postfix) with SMTP id 68E5C6EEA37;
	Wed, 14 Mar 2012 09:34:57 -0700 (PDT)
Received: (nullmailer pid 79981 invoked by uid 1001);
	Wed, 14 Mar 2012 16:34:11 -0000
Message-Id: <1331742851.245042.79980.nullmailer@experts-exchange.com>
Date: Wed, 14 Mar 2012 09:34:11 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: voisined@wit.edu
Subject: [PATCH] www/abyssws: drop invalid target post-deinstall
X-Send-Pr-Version: 3.113
X-GNATS-Notify: voisined@wit.edu

>Number:         166094
>Category:       ports
>Synopsis:       [PATCH] www/abyssws: drop invalid target post-deinstall
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jgh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 14 16:40:05 UTC 2012
>Closed-Date:    Wed Mar 28 21:10:41 UTC 2012
>Last-Modified:  Wed Mar 28 21:20:08 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
>Description:
post-deinstall is an invalid target, and adjust scripts to work via standards

Added file(s):
- pkg-deinstall

Port maintainer (voisined@wit.edu) is cc'd.

Generated with FreeBSD Port Tools 0.99_4 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- abyssws-2.6_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/www/abyssws/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	22 Jan 2009 05:33:28 -0000	1.5
+++ Makefile	14 Mar 2012 16:33:50 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	abyssws
 PORTVERSION=	2.6
+PORTREVISION=	1
 CATEGORIES=	www
 MASTER_SITES=	http://www.aprelium.com/data/
 DISTNAME=	abwsx1-freebsd
@@ -50,8 +51,4 @@
 	@${SETENV} PKG_PREFIX=${PREFIX} \
 		${SH} ${PKGINSTALL} ${PORTNAME} POST-INSTALL
 
-post-deinstall:
-	@${SETENV} PKG_PREFIX=${PREFIX} \
-		${SH} ${PKGDEINSTALL} ${PORTNAME} POST-DEINSTALL
-
 .include <bsd.port.post.mk>
Index: pkg-deinstall
===================================================================
RCS file: pkg-deinstall
diff -N pkg-deinstall
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ pkg-deinstall	14 Mar 2012 16:33:50 -0000
@@ -0,0 +1,35 @@
+#!/bin/sh
+
+PATH=/bin:/usr/sbin
+WSHOME=${PKG_PREFIX}/lib/abyssws
+
+USER=abyssws
+GROUP=${USER}
+
+if [ "$2" = "DEINSTALL" ]; then
+
+	if ! [ -x ${WSHOME} ] ; then
+	    if pw group show "${GROUP}" 2>/dev/null; then
+		if pw groupdel ${GROUP}; then
+		    echo "Removed group \"${GROUP}\"."
+		else
+		    echo "Removing group \"${GROUP}\" failed..."
+		    exit 1
+		fi
+	    else
+		echo "Group \"${GROUP}\" doesn't exist!"
+	    fi
+
+	    if pw user show "${USER}" 2>/dev/null; then
+		if pw userdel ${USER}; then
+		    echo "Removed user \"${USER}\"."
+		else
+		    echo "Removing user \"${USER}\" failed..."
+		    exit 1
+		fi
+	    else
+		echo "User \"${USER}\" doesn't exist!"
+	    fi
+	fi
+
+fi
Index: pkg-install
===================================================================
RCS file: /home/pcvs/ports/www/abyssws/pkg-install,v
retrieving revision 1.3
diff -u -r1.3 pkg-install
--- pkg-install	14 Dec 2007 20:37:54 -0000	1.3
+++ pkg-install	14 Mar 2012 16:33:50 -0000
@@ -49,30 +49,5 @@
 	
 	
 	;;
-POST-DEINSTALL)
-	if ! [ -x ${WSHOME} ] ; then
-	    if pw group show "${GROUP}" 2>/dev/null; then
-		if pw groupdel ${GROUP}; then
-		    echo "Removed group \"${GROUP}\"."
-		else
-		    echo "Removing group \"${GROUP}\" failed..."
-		    exit 1
-		fi
-	    else
-		echo "Group \"${GROUP}\" doesn't exist!"
-	    fi
-
-	    if pw user show "${USER}" 2>/dev/null; then
-		if pw userdel ${USER}; then
-		    echo "Removed user \"${USER}\"."
-		else
-		    echo "Removing user \"${USER}\" failed..."
-		    exit 1
-		fi
-	    else
-		echo "User \"${USER}\" doesn't exist!"
-	    fi
-	fi
-	;;
 
 esac
--- abyssws-2.6_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jgh 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Mar 14 16:40:16 UTC 2012 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166094 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Mar 14 16:40:21 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166094 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: voisined@wit.edu
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/166094: [PATCH] www/abyssws: drop invalid target post-deinstall
Date: Wed, 14 Mar 2012 16:40:19 UT

 Maintainer of www/abyssws,
 
 Please note that PR ports/166094 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166094
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->open 
State-Changed-By: jgh 
State-Changed-When: Wed Mar 28 20:34:06 UTC 2012 
State-Changed-Why:  
feedback timeout (14 days) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166094 
State-Changed-From-To: open->closed 
State-Changed-By: jgh 
State-Changed-When: Wed Mar 28 21:10:38 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166094 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166094: commit references a PR
Date: Wed, 28 Mar 2012 21:11:04 +0000 (UTC)

 jgh         2012-03-28 21:10:24 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/abyssws          Makefile pkg-install 
   Added files:
     www/abyssws          pkg-deinstall 
   Log:
   - drop invalid post-deinstall target, and add pkg-deinstall script
   - while here adjust install scripts
   
   PR:     ports/166094
   Submitted by:   jgh
   Approved by:    maintainer timeout ( 14 days )
   Feature safe:   yes
   
   Revision  Changes    Path
   1.6       +1 -5      ports/www/abyssws/Makefile
   1.1       +35 -0     ports/www/abyssws/pkg-deinstall (new)
   1.4       +1 -26     ports/www/abyssws/pkg-install
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
