From jhelfman@experts-exchange.com  Wed Mar 14 16:27:26 2012
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1766E106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Mar 2012 16:27:26 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id EF43B8FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 14 Mar 2012 16:27:25 +0000 (UTC)
Received: from mail.dw.redsrci.com (localhost [127.0.0.1])
	by mail.dw.redsrci.com (Postfix) with ESMTP id D550F6EEA42;
	Wed, 14 Mar 2012 09:27:25 -0700 (PDT)
Received: from mail.dw.redsrci.com ([127.0.0.1])
	by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id LWgVB-DW93e9; Wed, 14 Mar 2012 09:27:25 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.dw.redsrci.com (Postfix) with SMTP id B131C6EEA3B;
	Wed, 14 Mar 2012 09:27:25 -0700 (PDT)
Received: (nullmailer pid 79586 invoked by uid 1001);
	Wed, 14 Mar 2012 16:26:39 -0000
Message-Id: <1331742399.539535.79585.nullmailer@experts-exchange.com>
Date: Wed, 14 Mar 2012 09:26:39 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: rfarmer@predatorlabs.net
Subject: [PATCH] shells/fish: drop unknown post-deinstall target
X-Send-Pr-Version: 3.113
X-GNATS-Notify: rfarmer@predatorlabs.net

>Number:         166093
>Category:       ports
>Synopsis:       [PATCH] shells/fish: drop unknown post-deinstall target
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jgh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 14 16:30:01 UTC 2012
>Closed-Date:    Mon Mar 19 16:31:16 UTC 2012
>Last-Modified:  Mon Mar 19 16:40:09 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
>Description:
post-deinstall is an invalid target, use default pkg-deinstall script on deinstall

Added file(s):
- pkg-deinstall

Port maintainer (rfarmer@predatorlabs.net) is cc'd.

Generated with FreeBSD Port Tools 0.99_4 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- fish-1.23.1_8.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/shells/fish/Makefile,v
retrieving revision 1.17
diff -u -r1.17 Makefile
--- Makefile	23 Sep 2011 22:25:21 -0000	1.17
+++ Makefile	14 Mar 2012 16:25:59 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	fish
 PORTVERSION=	1.23.1
-PORTREVISION=	7
+PORTREVISION=	8
 CATEGORIES=	shells
 MASTER_SITES=	SF
 
@@ -78,10 +78,4 @@
 		${ECHO_CMD} '${PREFIX}/bin/${PORTNAME}' >> /etc/shells; \
 	fi
 
-post-deinstall:
-	${CP} /etc/shells /etc/shells.bak
-	${GREP} -v '${PREFIX}/bin/${PORTNAME}' /etc/shells.bak \
-		>> /etc/shells
-	${RM} -f /etc/shells.bak
-
 .include <bsd.port.post.mk>
Index: pkg-deinstall
===================================================================
RCS file: pkg-deinstall
diff -N pkg-deinstall
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ pkg-deinstall	14 Mar 2012 16:25:59 -0000
@@ -0,0 +1,7 @@
+#!/bin/sh
+
+if [ "$2" = "DEINSTALL" ]; then
+	/bin/cp /etc/shells /etc/shells.bak
+	/usr/bin/grep -v '/usr/local/bin/fish' /etc/shells.bak >> /etc/shells
+	/bin/rm -f /etc/shells.bak
+fi
--- fish-1.23.1_8.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jgh 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Mar 14 16:30:37 UTC 2012 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166093 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Mar 14 16:30:46 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166093 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: rfarmer@predatorlabs.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/166093: [PATCH] shells/fish: drop unknown post-deinstall target
Date: Wed, 14 Mar 2012 16:30:42 UT

 Maintainer of shells/fish,
 
 Please note that PR ports/166093 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166093
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Rob Farmer <rfarmer@predatorlabs.net>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/166093: [PATCH] shells/fish: drop unknown post-deinstall target
Date: Mon, 19 Mar 2012 04:42:08 -0700

 On Wed, Mar 14, 2012 at 9:30 AM, Edwin Groothuis <edwin@freebsd.org> wrote:
 > Maintainer of shells/fish,
 >
 > Please note that PR ports/166093 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 > =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/166093
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 
 Approved
 
 --=20
 Rob Farmer
State-Changed-From-To: feedback->closed 
State-Changed-By: jgh 
State-Changed-When: Mon Mar 19 16:31:14 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166093 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166093: commit references a PR
Date: Mon, 19 Mar 2012 16:31:09 +0000 (UTC)

 jgh         2012-03-19 16:30:56 UTC
 
   FreeBSD ports repository
 
   Modified files:
     shells/fish          Makefile 
   Added files:
     shells/fish          pkg-deinstall 
   Log:
   - remove invalid post-deinstall target
   
   PR:     ports/166093
   Submitted by:   jgh@
   Approved by:    maintainer, rfarmer@predatorlabs.net
   Feature safe:   yes
   
   Revision  Changes    Path
   1.18      +1 -7      ports/shells/fish/Makefile
   1.1       +7 -0      ports/shells/fish/pkg-deinstall (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
