From jhelfman@experts-exchange.com  Wed Mar 14 05:16:20 2012
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 98F9A106566B;
	Wed, 14 Mar 2012 05:16:20 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 7813C8FC0C;
	Wed, 14 Mar 2012 05:16:20 +0000 (UTC)
Received: from mail.dw.redsrci.com (localhost [127.0.0.1])
	by mail.dw.redsrci.com (Postfix) with ESMTP id 28989717F17;
	Tue, 13 Mar 2012 22:16:20 -0700 (PDT)
Received: from mail.dw.redsrci.com ([127.0.0.1])
	by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id TSTV96wjQ++q; Tue, 13 Mar 2012 22:16:20 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.dw.redsrci.com (Postfix) with SMTP id 054616EE1C2;
	Tue, 13 Mar 2012 22:16:20 -0700 (PDT)
Received: (nullmailer pid 95015 invoked by uid 1001);
	Wed, 14 Mar 2012 05:15:34 -0000
Message-Id: <1331702134.113362.95014.nullmailer@experts-exchange.com>
Date: Tue, 13 Mar 2012 22:15:34 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: dhn@FreeBSD.org
Subject: [PATCH] net/wired: drop unknown post-deinstall target
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         166077
>Category:       ports
>Synopsis:       [PATCH] net/wired: drop unknown post-deinstall target
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dhn
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 14 05:20:07 UTC 2012
>Closed-Date:    Fri Mar 16 15:48:45 UTC 2012
>Last-Modified:  Fri Mar 16 15:50:02 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
>Description:
drop unknown post-deinstall target and use default pkg-deinstall
tighten install operations

Port maintainer (dhn@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_4 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- wired-1.3.4_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/net/wired/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- Makefile	25 Feb 2011 00:56:51 -0000	1.11
+++ Makefile	14 Mar 2012 05:14:37 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	wired
 PORTVERSION=	1.3.4
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	net
 MASTER_SITES=	http://mirror.mcx2.org/
 
@@ -27,28 +27,11 @@
 	PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
 
 post-install:
-	@if [ ! -f ${PREFIX}/wired/etc/wired.conf ]; then \
-		${CP} -p ${PREFIX}/wired/etc/wired.conf.sample ${PREFIX}/wired/etc/wired.conf ; \
-	fi
-	@if [ ! -f ${PREFIX}/wired/etc/resolv.conf ]; then \
-		${CP} -p ${PREFIX}/wired/etc/resolv.conf.sample ${PREFIX}/wired/etc/resolv.conf ; \
-	fi
-	@if [ ! -f ${PREFIX}/wired/banlist ]; then \
-		${CP} -p ${PREFIX}/wired/banlist.sample ${PREFIX}/wired/banlist ; \
-	fi
-	@if [ ! -f ${PREFIX}/wired/groups ]; then \
-		${CP} -p ${PREFIX}/wired/groups.sample ${PREFIX}/wired/groups ; \
-	fi
-	@if [ ! -f ${PREFIX}/wired/news ]; then \
-		${CP} -p ${PREFIX}/wired/news.sample ${PREFIX}/wired/news ; \
-	fi
-	@if [ ! -f ${PREFIX}/wired/users ]; then \
-		${CP} -p ${PREFIX}/wired/users.sample ${PREFIX}/wired/users ; \
+.for i in etc/wired.conf etc/resolv.conf banlist groups news users
+	@if [ ! -f ${PREFIX}/wired/${i} ]; then \
+		${CP} -p ${PREFIX}/wired/${i}.sample ${PREFIX}/wired/${i} ; \
 	fi
+.endfor
 	PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
 
-post-deinstall:
-	${RM} -f ${PREFIX}/wired/etc/certificate.pem.sample
-	PKG_PREFIX=${PREFIX} ${SH} pkg-deinstall ${PKGNAME} POST-DEINSTALL
-
 .include <bsd.port.mk>
--- wired-1.3.4_2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dhn 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Mar 14 05:20:24 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166077 
State-Changed-From-To: open->closed 
State-Changed-By: dhn 
State-Changed-When: Fri Mar 16 15:48:44 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=166077 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/166077: commit references a PR
Date: Fri, 16 Mar 2012 15:48:43 +0000 (UTC)

 dhn         2012-03-16 15:48:34 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/wired            Makefile 
   Log:
   - Drop unknown post-deinstall target
   - Bump PORTREVISION
   
   PR:             ports/166077
   Submitted by:   Jason Helfman <jgh@FreeBSD.org>
   Feature safe:   yes
   
   Revision  Changes    Path
   1.12      +5 -22     ports/net/wired/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
