From nobody@FreeBSD.org  Sun Mar 11 11:04:14 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 32CCD1065675
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2012 11:04:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 08FE68FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2012 11:04:14 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q2BB4DUw077207
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2012 11:04:13 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q2BB4DK0077185;
	Sun, 11 Mar 2012 11:04:13 GMT
	(envelope-from nobody)
Message-Id: <201203111104.q2BB4DK0077185@red.freebsd.org>
Date: Sun, 11 Mar 2012 11:04:13 GMT
From: alexander <alexander.4mail@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: New port: devel/p5-File-KeePass
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         165922
>Category:       ports
>Synopsis:       New port: devel/p5-File-KeePass
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    culot
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 11 11:10:09 UTC 2012
>Closed-Date:    Thu Mar 15 12:44:10 UTC 2012
>Last-Modified:  Thu Mar 15 12:50:06 UTC 2012
>Originator:     alexander
>Release:        FreeBSD 9.0-STABLE
>Organization:
>Environment:
>Description:
New port: devel/p5-File-KeePass Interface to KeePass V1 datafile
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	p5-File-KeePass
#	p5-File-KeePass/pkg-plist
#	p5-File-KeePass/pkg-descr
#	p5-File-KeePass/Makefile
#	p5-File-KeePass/distinfo
#
echo c - p5-File-KeePass
mkdir -p p5-File-KeePass > /dev/null 2>&1
echo x - p5-File-KeePass/pkg-plist
sed 's/^X//' >p5-File-KeePass/pkg-plist << '5e63d210d3fd1a04579cd35d50636fa9'
X%%SITE_PERL%%/File/KeePass.pm
X@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/File
X@dirrmtry %%SITE_PERL%%/File
5e63d210d3fd1a04579cd35d50636fa9
echo x - p5-File-KeePass/pkg-descr
sed 's/^X//' >p5-File-KeePass/pkg-descr << 'f57b745bf9a67755f107b63588387b63'
XThis module is interface to KeePassX and KeePass V1 database files. 
XIt supports only Rijndael encryption and only bases which secured 
Xvia passkeys (key files not supported).
X
XWWW: http://search.cpan.org/dist/File-KeePass/
f57b745bf9a67755f107b63588387b63
echo x - p5-File-KeePass/Makefile
sed 's/^X//' >p5-File-KeePass/Makefile << 'e5c577d4c0add7c353c678d4859ae121'
X# New ports collection makefile for:    p5-File-KeePass
X# Date created:			10 March 2012
X# Whom:				Alexander Y. Grigoryev <alexander.4mail@gmail.com>
X#
X# $FreeBSD$
X
XPORTNAME=       File-KeePass
XPORTVERSION=    0.03
XCATEGORIES=     devel perl5
XMASTER_SITES=   CPAN
XPKGNAMEPREFIX=  p5-
X
XMAINTAINER=     alexander.4mail@gmail.com
XCOMMENT=       	Interface to KeePass V1 and KeePassX database files
X
XRUN_DEPENDS=	p5-Crypt-Rijndael>=1.09:${PORTSDIR}/security/p5-Crypt-Rijndael \
X		p5-Digest-SHA1>=2.13:${PORTSDIR}/security/p5-Digest-SHA1
XBUILD_DEPENDS=  ${RUN_DEPENDS}
X
XPERL_CONFIGURE= yes
X
XMAN3=           File::KeePass.3
X
X.include <bsd.port.mk>
e5c577d4c0add7c353c678d4859ae121
echo x - p5-File-KeePass/distinfo
sed 's/^X//' >p5-File-KeePass/distinfo << '11f1cb1c145a2687a73691787d31b81b'
XSHA256 (File-KeePass-0.03.tar.gz) = 858b9052ec05e7203e504fe8d8ccea0b936f814bd30f3192a4253d0c985743f4
XSIZE (File-KeePass-0.03.tar.gz) = 16264
11f1cb1c145a2687a73691787d31b81b
exit



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->perl 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Mar 11 11:10:18 UTC 2012 
Responsible-Changed-Why:  
perl@ wants this port PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165922 
Responsible-Changed-From-To: perl->culot 
Responsible-Changed-By: culot 
Responsible-Changed-When: Wed Mar 14 12:35:43 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165922 

From: Frederic Culot <culot@FreeBSD.org>
To: bug-followup@FreeBSD.org, alexander <alexander.4mail@gmail.com>
Cc:  
Subject: Re: ports/165922: New port: devel/p5-File-KeePass
Date: Wed, 14 Mar 2012 13:58:20 +0000

 Hi Alexander,
 
 thanks for submitting this new port, however there are several problems
 with it. Here is a list of issues I found:
 
 - dependencies are wrong (one should use the vendor suggested dependencies,
 not the last version of the packages found in the ports tree)
 - some files are missing in plist
 - the license is missing
 - there are style issues (use of spaces instead of tabs in Makefile)
 
 You could use portlint(1) (available via ports-mgmt/portlint)
 to check your ports, and you could also run it via tinderbox
 (ports-mgmt/tinderbox) to check that it installs/deinstalls well.
 Those tools could help you spotting the kinds of issues mentionned
 above.
 
 I corrected those issues in the following updated port:
 
 http://people.freebsd.org/~culot/files/p5-File-KeePass.shar
 
 I also moved the port to the security category, as I believe it is
 more adequate (the devel category already has too many ports so if
 another category is more appropriate, go for it!).
 A tinderbox log corresponding to this updated port could be found here:
 
 http://people.freebsd.org/~culot/tinderbox/8.2-FreeBSD/p5-File-KeePass-0.03.log
 
 If you agree with those chances then I will import this updated port.
 
 Regards,
 Frederic

From: Frederic Culot <culot@FreeBSD.org>
To: Alexander <alexander.4mail@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/165922: New port: devel/p5-File-KeePass
Date: Thu, 15 Mar 2012 08:59:21 +0100

 Hi Alexander,
 
 > > Hi Frederic,
 > > 
 > > Sorry about that issues - it some kind of difficult to find a
 > > comprehensive guide about making FreeBSD port (I used Porters Handbook
 > > and ports\mk files, but looks like its not enough for me). I'll check about
 > > portlint and tinderbox more carefully than I did.
 
 no problem. There is indeed a lot of material and it's not easy to get a
 comprehensive view of everything that has to be checked when creating a new
 port! That's why committers are here to help so feel free to contact me directly
 if you need help next time you work on a port.
 
 > > I definitely agree with changes in port, expect one thing: it
 > > looks like that you remove p5-Digest-SHA1 from depencies list, but
 > > according to source code it is required thing (for example you may check MakeFile.pl
 > > of File-KeePass or File-KeePass itself). Will it work without it?
 > > Thanks, and sorry for my English - its not my native language.
 > > 
 > > Regard,
 > > Alexander
 > 
 > Sorry, my mistake. Its ok about p5-Digest-SHA1. Feel free to
 > import updated port. Thanks.
 
 Yes, Digest::SHA (and not Digest::SHA1) is now shipped as a perl core module
 (you could check that using corelist(1)) since perl 5.10. Hence I added the
 conditionnal to add this module in case the version of perl that is installed is
 lesser than 5.10.
 
 Again, feel free to contact me if you have any question. If you are on irc you
 could also join the #bsdports channel on efnet to get some help.
 
 Cheers,
 Frederic
 
 PS: I put bug-followup@ in CC so that the bug tracking system could keep track
 of your approval (emails are automatically inserted in the PR that way).
State-Changed-From-To: open->closed 
State-Changed-By: culot 
State-Changed-When: Thu Mar 15 12:44:10 UTC 2012 
State-Changed-Why:  
New port added. Thanks Alexander! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165922 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/165922: commit references a PR
Date: Thu, 15 Mar 2012 12:42:24 +0000 (UTC)

 culot       2012-03-15 12:42:10 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security             Makefile 
   Added files:
     security/p5-File-KeePass Makefile distinfo pkg-descr pkg-plist 
   Log:
   File::KeePass is an interface to KeePassX and KeePass V1 database files.
   It supports only Rijndael encryption and only bases which were secured
   via passkeys (key files not supported).
   
   WWW: http://search.cpan.org/dist/File-KeePass/
   
   PR:             ports/165922 (based on)
   Submitted by:   Alexander Y. Grigoryev <alexander.4mail@gmail.com>
   Feature safe:   yes
   
   Revision  Changes    Path
   1.1262    +1 -0      ports/security/Makefile
   1.1       +33 -0     ports/security/p5-File-KeePass/Makefile (new)
   1.1       +2 -0      ports/security/p5-File-KeePass/distinfo (new)
   1.1       +5 -0      ports/security/p5-File-KeePass/pkg-descr (new)
   1.1       +5 -0      ports/security/p5-File-KeePass/pkg-plist (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/165922: commit references a PR
Date: Thu, 15 Mar 2012 12:49:24 +0000 (UTC)

 culot       2012-03-15 12:49:10 UTC
 
   FreeBSD doc repository (ports committer)
 
   Modified files:
     en_US.ISO8859-1/articles/contributors contrib.additional.sgml 
   Log:
   Add Alexander Grigoryev <alexander.4mail@gmail.com> for security/p5-File-KeePass.
   
   PR:     ports/165922
   
   Revision  Changes    Path
   1.1071    +5 -0      doc/en_US.ISO8859-1/articles/contributors/contrib.additional.sgml
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
