From bsdkaffee@gmail.com  Mon Mar  5 20:35:06 2012
Return-Path: <bsdkaffee@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 14FF11065670
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 Mar 2012 20:34:57 +0000 (UTC)
	(envelope-from bsdkaffee@gmail.com)
Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182])
	by mx1.freebsd.org (Postfix) with ESMTP id C27978FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  5 Mar 2012 20:34:56 +0000 (UTC)
Received: by vcmm1 with SMTP id m1so3059913vcm.13
        for <FreeBSD-gnats-submit@freebsd.org>; Mon, 05 Mar 2012 12:34:56 -0800 (PST)
Received: from mr.google.com ([10.52.26.176])
        by 10.52.26.176 with SMTP id m16mr38147628vdg.1.1330979696327 (num_hops = 1);
        Mon, 05 Mar 2012 12:34:56 -0800 (PST)
Received: by 10.52.26.176 with SMTP id m16mr32643001vdg.1.1330979696268;
        Mon, 05 Mar 2012 12:34:56 -0800 (PST)
Received: from mocha.verizon.net (c-71-61-40-68.hsd1.oh.comcast.net. [71.61.40.68])
        by mx.google.com with ESMTPS id w6sm26752582vdj.4.2012.03.05.12.34.55
        (version=TLSv1/SSLv3 cipher=OTHER);
        Mon, 05 Mar 2012 12:34:55 -0800 (PST)
Message-Id: <4f55236f.4625340a.655a.ffff8213@mx.google.com>
Date: Mon, 05 Mar 2012 12:34:55 -0800 (PST)
From: Jason E. Hale <bsdkaffee@gmail.com>
Reply-To: Jason E. Hale <bsdkaffee@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] sysutils/k3b: Remove musicbrainz option
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         165749
>Category:       ports
>Synopsis:       [PATCH] sysutils/k3b: Remove musicbrainz option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ak
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 05 20:40:09 UTC 2012
>Closed-Date:    Fri Mar 09 05:29:00 UTC 2012
>Last-Modified:  Fri Mar  9 05:30:12 UTC 2012
>Originator:     Jason E. Hale
>Release:        FreeBSD 9.0-RELEASE i386
>Organization:
none 
>Environment:
System: FreeBSD mocha.verizon.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Thu Jan 19 11:42:41 EST 2012 Jason@mocha.verizon.net:/usr/obj/usr/src/sys/MOCHA9 i386


	
>Description:
- Remove the audio/libmusicbrainz option from sysutils/k3b
- audio/libmusicbrainz is deprecated as the MusicBrainz RDF webservice is no
  longer functional
	
>How-To-Repeat:
- Use attached diff
	
>Fix:

	

--- 2012-03-05-k3b.diff begins here ---
diff -ruN k3b.orig/Makefile k3b/Makefile
--- k3b.orig/Makefile	2012-03-05 15:17:39.000000000 -0500
+++ k3b/Makefile	2012-03-05 15:19:15.000000000 -0500
@@ -7,7 +7,7 @@
 
 PORTNAME=	k3b
 PORTVERSION=	1.0.5
-PORTREVISION=	13
+PORTREVISION=	14
 CATEGORIES=	sysutils multimedia kde
 MASTER_SITES=	SF
 
@@ -23,7 +23,8 @@
 CONFIGURE_ARGS=	--with-k3bsetup=no \
 			--without-resmgr \
 			--without-hal \
-			--without-musepack
+			--without-musepack \
+			--without-musicbrainz
 USE_GMAKE=	yes
 USE_CDRTOOLS=	yes
 USE_LDCONFIG=	yes
@@ -36,7 +37,6 @@
 		FLAC "Add audio/flac decoder" On \
 		LAME "Add audio/lame encoder (for mp3 files)" On \
 		LIBDVDREAD "Use libdvdread (for video dvd ripping)" On \
-		MUSICBRAINZ "Use audio/libmusicbrainz music meta database" Off \
 		NORMALIZE "Add Normalize (adjust audio to a std. level)" Off \
 		SOX "Add SoX (more audio encoding formats)" Off \
 		TRANSCODE "Add Transcode (for DVD ripping)" Off \
@@ -85,14 +85,6 @@
 CONFIGURE_ARGS+=	--without-ffmpeg
 .endif
 
-.if defined(WITH_MUSICBRAINZ)
-PLIST_SUB+=	MUSICBRAINZ=""
-LIB_DEPENDS+=	musicbrainz:${PORTSDIR}/audio/libmusicbrainz
-.else
-PLIST_SUB+=	MUSICBRAINZ="@comment "
-CONFIGURE_ARGS+=	--without-musicbrainz
-.endif
-
 .if defined(WITH_LIBDVDREAD)
 PLIST_SUB+=	LIBDVDREAD=""
 LIB_DEPENDS+=	dvdread.4:${PORTSDIR}/multimedia/libdvdread
--- 2012-03-05-k3b.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ak 
Responsible-Changed-By: ak 
Responsible-Changed-When: Tue Mar 6 02:03:14 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165749 
State-Changed-From-To: open->closed 
State-Changed-By: ak 
State-Changed-When: Fri Mar 9 05:28:59 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165749 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/165749: commit references a PR
Date: Fri,  9 Mar 2012 05:26:07 +0000 (UTC)

 ak          2012-03-09 05:25:53 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/k3b         Makefile 
   Log:
   - Remove the audio/libmusicbrainz option from sysutils/k3b
     audio/libmusicbrainz is deprecated as the MusicBrainz RDF
     webservice is no longer functional
   
   PR:             ports/165749
   Submitted by:   Jason E. Hale <bsdkaffee@gmail.com>
   Approved by:    eadler (mentor)
   Feature safe:   yes
   
   Revision  Changes    Path
   1.76      +3 -11     ports/sysutils/k3b/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
