From scheidell@secnap.net  Fri Feb 24 17:27:39 2012
Return-Path: <scheidell@secnap.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 454151065675
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 24 Feb 2012 17:27:39 +0000 (UTC)
	(envelope-from scheidell@secnap.net)
Received: from mx1.secnap.com.ionspam.net (mx1.secnap.com.ionspam.net [204.89.241.253])
	by mx1.freebsd.org (Postfix) with ESMTP id 1312F8FC18
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 24 Feb 2012 17:27:37 +0000 (UTC)
Received: from mx1.secnap.com.ionspam.net (mx1.secnap.com.ionspam.net [10.70.1.253])
	by mx1.secnap.com.ionspam.net (Postfix) with ESMTP id 880D6621C06
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 24 Feb 2012 12:27:37 -0500 (EST)
Received: from scanner.secnap.net (unknown [10.70.1.4])
	by mx1.secnap.com.ionspam.net (Postfix) with ESMTP id 61E58621C04
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 24 Feb 2012 12:27:36 -0500 (EST)
Received: by scanner.secnap.net (Postfix, from userid 1001)
	id 50B431D403; Fri, 24 Feb 2012 12:27:36 -0500 (EST)
Message-Id: <20120224172736.50B431D403@scanner.secnap.net>
Date: Fri, 24 Feb 2012 12:27:36 -0500 (EST)
From: Michael Scheidell <scheidell@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Subject: small patch www/nginx. re-order extra_commands
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         165454
>Category:       ports
>Synopsis:       [patch] www/nginx: re-order extra_commands
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    osa
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 24 17:30:13 UTC 2012
>Closed-Date:    Tue Feb 28 11:15:00 UTC 2012
>Last-Modified:  Tue Feb 28 11:15:00 UTC 2012
>Originator:     Michael Scheidell
>Release:        FreeBSD 7.4-RELEASE-p3 i386
>Organization:
SECNAP Network Security
>Environment:

>Description:

Can I beg for a small change to order of extra_commands in ../nginx rc file?
The way it is, anyone who want to add to this, with a /etc/rc.conf.d/nginx file won't get their 'special' hacks included.
By putting extra_commands ahead of the load_rc_config $name, it gives more of a standard ability for customizations.

this should be 100% upward compatible, don't need a portrevision bump, so no rebuilds needed, just makes it more comparible.
thanks.

- Update order of extra_commands in rc file to facilitate custom scripts
- no PORTREVISION bump

>How-To-Repeat:

add an extra command to /etc/rc.conf.d and execute service nginx {new command}

>Fix:

this small patch. thanks.

--- nginx.sh.patch begins here ---
Index: files/nginx.sh.in
===================================================================
RCS file: /home/pcvs/ports/www/nginx/files/nginx.sh.in,v
retrieving revision 1.10
diff -u -r1.10 nginx.sh.in
--- files/nginx.sh.in	14 Jan 2012 08:57:15 -0000	1.10
+++ files/nginx.sh.in	24 Feb 2012 17:22:07 -0000
@@ -35,6 +35,7 @@
 _pidprefix="/var/run/nginx"
 pidfile="${_pidprefix}.pid"
 required_files=%%PREFIX%%/etc/nginx/nginx.conf
+extra_commands="reload configtest upgrade gracefulstop"
 
 [ -z "$nginx_enable" ]		&& nginx_enable="NO"
 [ -z "$nginxlimits_enable" ]	&& nginxlimits_enable="NO"
@@ -118,5 +119,4 @@
 	fi
 }
 
-extra_commands="reload configtest upgrade gracefulstop"
 run_rc_command "$1"
--- nginx.sh.patch ends here ---

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.spammertrap.com/
______________________________________________________________________  
  
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->osa 
Responsible-Changed-By: jgh 
Responsible-Changed-When: Fri Feb 24 18:52:58 UTC 2012 
Responsible-Changed-Why:  
fix synopsis, and assign 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165454 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/165454: commit references a PR
Date: Tue, 28 Feb 2012 10:26:28 +0000 (UTC)

 osa         2012-02-28 10:26:19 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/nginx/files      nginx.sh.in 
     www/nginx-devel/files nginx.sh.in 
   Log:
   Move upward extra_commands string for compatible with rc.conf.d
   feature.
   
   Do not bump PORTREVISIONs.
   PR:     165454
   
   Revision  Changes    Path
   1.13      +2 -2      ports/www/nginx-devel/files/nginx.sh.in
   1.11      +2 -2      ports/www/nginx/files/nginx.sh.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: osa 
State-Changed-When: Tue Feb 28 11:14:41 UTC 2012 
State-Changed-Why:  
Committed, thanks for report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165454 
>Unformatted:
