From nobody@FreeBSD.org  Tue Feb 21 10:12:44 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A15391065670
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 21 Feb 2012 10:12:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8C8678FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 21 Feb 2012 10:12:44 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q1LACi5n099182
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 21 Feb 2012 10:12:44 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q1LACiAT099176;
	Tue, 21 Feb 2012 10:12:44 GMT
	(envelope-from nobody)
Message-Id: <201202211012.q1LACiAT099176@red.freebsd.org>
Date: Tue, 21 Feb 2012 10:12:44 GMT
From: "Y.A." <nexther0@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: libnet: UDP checksums are bogus in odd sized packets
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         165355
>Category:       ports
>Synopsis:       net/libnet: UDP checksums are bogus in odd sized packets
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 21 10:20:09 UTC 2012
>Closed-Date:    Wed Feb 22 05:49:55 CET 2012
>Last-Modified:  Wed Feb 22 04:50:04 UTC 2012
>Originator:     Y.A.
>Release:        FreeBSD 7.2 RELEASE-p6
>Organization:
>Environment:
FreeBSD noc.umc.com.ua 7.2-RELEASE-p6 FreeBSD 7.2-RELEASE-p6 #4: Tue Jan 19 09:36:13 EET 2010     root@noc:/usr/obj/usr/src/sys/NOC  amd64

>Description:
UDP checksums are bogus in odd sized packets
full detail
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=284729

>How-To-Repeat:
simply create odd length packet 
>Fix:
find attached patch

Patch attached with submission follows:

--- src/libnet_checksum.c.orig	Mon Mar  1 22:26:12 2004
+++ src/libnet_checksum.c	Mon Aug 25 15:44:12 2008
@@ -42,8 +42,10 @@
 libnet_in_cksum(u_int16_t *addr, int len)
 {
     int sum;
+    u_int16_t last_byte;
 
     sum = 0;
+    last_byte = 0;
 
     while (len > 1)
     {
@@ -52,7 +54,8 @@
     }
     if (len == 1)
     {
-        sum += *(u_int16_t *)addr;
+        *(u_int8_t*)&last_byte = *(u_int8_t*)addr;
+        sum += last_byte;
     }
 
     return (sum);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Feb 22 03:32:31 UTC 2012 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165355 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Wed Feb 22 05:49:43 CET 2012 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165355 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/165355: commit references a PR
Date: Wed, 22 Feb 2012 04:49:22 +0000 (UTC)

 dinoex      2012-02-22 04:49:08 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/libnet           Makefile 
   Added files:
     net/libnet/files     patch-libnet_checksum.c 
   Log:
   - fix UDP checksums in odd sized packets
   PR:             165355
   Submitted by:   Y.A.
   Obtained from:  debian
   
   Revision  Changes    Path
   1.25      +1 -1      ports/net/libnet/Makefile
   1.1       +23 -0     ports/net/libnet/files/patch-libnet_checksum.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
