From steve@mouf.net  Mon Feb 20 15:10:13 2012
Return-Path: <steve@mouf.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 16202106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 20 Feb 2012 15:10:13 +0000 (UTC)
	(envelope-from steve@mouf.net)
Received: from mouf.net (unknown [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b2])
	by mx1.freebsd.org (Postfix) with ESMTP id 0537A8FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 20 Feb 2012 15:10:09 +0000 (UTC)
Received: from meatwad.mouf.net (cpe-024-162-230-236.nc.res.rr.com [24.162.230.236])
	by mouf.net (8.14.4/8.14.4) with ESMTP id q1KFA5Za085195
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Mon, 20 Feb 2012 10:10:06 -0500 (EST)
	(envelope-from steve@meatwad.mouf.net)
Received: (from steve@localhost)
	by meatwad.mouf.net (8.14.5/8.14.5/Submit) id q1KFA5QZ062675;
	Mon, 20 Feb 2012 10:10:05 -0500 (EST)
	(envelope-from steve)
Message-Id: <201202201510.q1KFA5QZ062675@meatwad.mouf.net>
Date: Mon, 20 Feb 2012 10:10:05 -0500 (EST)
From: Steve Wills <swills@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: martymac@freebsd.org
Subject: [PATCH] graphics/pencil: switch from libungif to giflib to avoid conflict
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         165325
>Category:       ports
>Synopsis:       [PATCH] graphics/pencil: switch from libungif to giflib to avoid conflict
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    martymac
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 20 15:20:10 UTC 2012
>Closed-Date:    Wed Feb 22 07:15:54 UTC 2012
>Last-Modified:  Wed Feb 22 07:20:16 UTC 2012
>Originator:     Steve Wills
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD meatwad.mouf.net 10.0-CURRENT FreeBSD 10.0-CURRENT #13 r230974: Fri Feb  3 23:48:36
>Description:
see patch

Port maintainer (martymac@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_3 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- pencil-0.4.4b_5.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/graphics/pencil/Makefile,v
retrieving revision 1.11
diff -u -u -r1.11 Makefile
--- Makefile	10 Aug 2011 02:37:11 -0000	1.11
+++ Makefile	20 Feb 2012 15:09:45 -0000
@@ -22,7 +22,7 @@
 		freetype:${PORTSDIR}/print/freetype2 \
 		fontconfig:${PORTSDIR}/x11-fonts/fontconfig \
 		iconv:${PORTSDIR}/converters/libiconv \
-		ungif:${PORTSDIR}/graphics/libungif \
+		gif:${PORTSDIR}/graphics/giflib \
 		expat:${PORTSDIR}/textproc/expat2 \
 		pcre:${PORTSDIR}/devel/pcre \
 		drm:${PORTSDIR}/graphics/libdrm
--- pencil-0.4.4b_5.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->martymac 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Feb 20 15:20:21 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165325 

From: "Ganael LAPLANCHE" <martymac@FreeBSD.org>
To: bug-followup@FreeBSD.org,swills@freebsd.org
Cc: sunpoet@FreeBSD.org
Subject: Re: ports/165325: [PATCH] graphics/pencil: switch from libungif to giflib to avoid conflict
Date: Tue, 21 Feb 2012 13:10:47 +0000 (UTC)

 Hi Steve,
 
 (sunpoet@, maintainer of graphics/ming CC'ed)
 
 Thanks for your patch. Unfortunately, it cannot be applied as is because :
 
 - graphics/pencil would depend on graphics/giflib *and* graphics/ming
 - but graphics/ming still depends on graphics/libungif
 
 => both gif libraries CONFLICTS
 
 I see two possibilities :
 
 1) For graphics/ming, change graphics/libungif dependency to
    graphics/giflib and apply your patch for graphics/pencil
 2) For graphics/ming, leave graphics/libungif dependency as is and
    for graphics/pencil, remove dependency to graphics/libungif
    (as it depends on graphics/ming, use this dependency to get
    a gif library, whatever it is)
 
 I would prefer fix 1), as I think it is useful to keep an explicit
 dependency on gif for graphics/pencil. Po-Chuan, what do you think about
 that ? Can you change gif dependency for graphics/ming ?
 
 Best regards,
 
 --
 Ganael LAPLANCHE <ganael.laplanche@martymac.org>
 http://www.martymac.org | http://contribs.martymac.org
 FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org

From: "Steve Wills" <swills@FreeBSD.org>
To: "Ganael LAPLANCHE" <martymac@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, swills@FreeBSD.org, sunpoet@FreeBSD.org
Subject: Re: ports/165325: [PATCH] graphics/pencil: switch from libungif to giflib to avoid conflict
Date: Tue, 21 Feb 2012 08:50:12 -0500

 Hi,
 
 > Hi Steve,
 >
 > (sunpoet@, maintainer of graphics/ming CC'ed)
 >
 > Thanks for your patch. Unfortunately, it cannot be applied as is because :
 >
 > - graphics/pencil would depend on graphics/giflib *and* graphics/ming
 > - but graphics/ming still depends on graphics/libungif
 
 I also opened PR ports/165324. I should have noted in PR ports/165325 that
 it needed  PR ports/165324 to be applied first.
 
 > => both gif libraries CONFLICTS
 >
 > I see two possibilities :
 >
 > 1) For graphics/ming, change graphics/libungif dependency to
 >    graphics/giflib and apply your patch for graphics/pencil
 > 2) For graphics/ming, leave graphics/libungif dependency as is and
 >    for graphics/pencil, remove dependency to graphics/libungif
 >    (as it depends on graphics/ming, use this dependency to get
 >    a gif library, whatever it is)
 >
 > I would prefer fix 1), as I think it is useful to keep an explicit
 > dependency on gif for graphics/pencil. Po-Chuan, what do you think about
 > that ? Can you change gif dependency for graphics/ming ?
 >
 
 I guess from the other PR you can see I had been thinking of 1) as well,
 but now that you mention it, if the explicit dep isn't needed, maybe it
 could be removed.
 
 There has also been some talk lately of removing explicit version numbers
 from lib depends where they aren't needed, which may be a good idea. Of
 course, changing the dep from libungif to giflib would still be required.
 
 Thanks,
 Steve
 
 
State-Changed-From-To: open->closed 
State-Changed-By: martymac 
State-Changed-When: Wed Feb 22 07:15:53 UTC 2012 
State-Changed-Why:  
Committed with minor changes, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165325 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/165325: commit references a PR
Date: Wed, 22 Feb 2012 07:10:58 +0000 (UTC)

 martymac    2012-02-22 07:10:49 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/pencil      Makefile 
   Log:
   Remove useless dependency to graphics/libungif
   
   PR:             ports/165325
   Submitted by:   swills
   
   Revision  Changes    Path
   1.12      +1 -2      ports/graphics/pencil/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: "Ganael LAPLANCHE" <martymac@FreeBSD.org>
To: "Steve Wills" <swills@FreeBSD.org>
Cc: bug-followup@FreeBSD.org,sunpoet@FreeBSD.org
Subject: Re: ports/165325: [PATCH] graphics/pencil: switch from libungif to giflib to avoid conflict
Date: Wed, 22 Feb 2012 07:14:16 +0000 (UTC)

 On Tue, 21 Feb 2012 08:50:12 -0500, Steve Wills wrote
 
 Hi Steve,
 
 > [...]
 >  I guess from the other PR you can see I had been thinking of 
 > 1) as well, but now that you mention it, if the explicit dep 
 > isn't needed, maybe it could be removed.
 
 I've just removed the dependency to graphics/libungif as it was not needed.
 
 Thanks for your help :)
 
 --
 Ganael LAPLANCHE <ganael.laplanche@martymac.org>
 http://www.martymac.org | http://contribs.martymac.org
 FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org
>Unformatted:
