From gslin@colo-p.gslin.org  Sun Feb 12 00:34:40 2012
Return-Path: <gslin@colo-p.gslin.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D48B106564A;
	Sun, 12 Feb 2012 00:34:40 +0000 (UTC)
	(envelope-from gslin@colo-p.gslin.org)
Received: from colo-p.gslin.org (gslin-1-pt.tunnel.tserv3.fmt2.ipv6.he.net [IPv6:2001:470:1f04:18a1::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 466858FC17;
	Sun, 12 Feb 2012 00:34:40 +0000 (UTC)
Received: by colo-p.gslin.org (Postfix, from userid 1000)
	id 8D16F7E81B; Sun, 12 Feb 2012 08:34:39 +0800 (CST)
Message-Id: <20120212003439.8D16F7E81B@colo-p.gslin.org>
Date: Sun, 12 Feb 2012 08:34:39 +0800 (CST)
From: Gea-Suan Lin <gslin@gslin.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: perl@FreeBSD.org, gslin@gslin.org
Subject: [PATCH] sysutils/p5-MogileFS-Server: Fix multiple issues in rc scripts
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         165007
>Category:       ports
>Synopsis:       [PATCH] sysutils/p5-MogileFS-Server: Fix multiple issues in rc scripts
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 12 00:40:11 UTC 2012
>Closed-Date:    Wed Feb 15 01:05:53 UTC 2012
>Last-Modified:  Wed Feb 15 01:05:53 UTC 2012
>Originator:     Gea-Suan Lin
>Release:        FreeBSD 7.4-RELEASE-p3 i386
>Organization:
>Environment:
System: FreeBSD colo-p.gslin.org 7.4-RELEASE-p3 FreeBSD 7.4-RELEASE-p3 #0: Tue Sep 27 14:47:23 UTC 2011
>Description:
- Fix multiple issues in rc scripts.
- Follow practice in Porter's Handbook.

Port maintainer (perl@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- p5-MogileFS-Server-2.57_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/sysutils/p5-MogileFS-Server/Makefile /home/staff/gslin/work/ports/p5-MogileFS-Server/Makefile
--- /usr/ports/sysutils/p5-MogileFS-Server/Makefile	2012-02-12 06:37:24.000000000 +0800
+++ /home/staff/gslin/work/ports/p5-MogileFS-Server/Makefile	2012-02-12 07:56:08.000000000 +0800
@@ -7,7 +7,7 @@
 
 PORTNAME=	MogileFS-Server
 PORTVERSION=	2.57
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	sysutils perl5
 MASTER_SITES=	CPAN
 MASTER_SITE_SUBDIR=	CPAN:DORMANDO
diff -ruN --exclude=CVS /usr/ports/sysutils/p5-MogileFS-Server/files/mogilefsd.in /home/staff/gslin/work/ports/p5-MogileFS-Server/files/mogilefsd.in
--- /usr/ports/sysutils/p5-MogileFS-Server/files/mogilefsd.in	2012-02-12 06:37:24.000000000 +0800
+++ /home/staff/gslin/work/ports/p5-MogileFS-Server/files/mogilefsd.in	2012-02-12 08:21:25.000000000 +0800
@@ -15,5 +15,10 @@
 
 [ -z "$mogilefsd_enable" ] && mogilefsd_enable="NO"
 [ -z "$mogilefsd_flags" ] && mogilefsd_flags="--config=%%PREFIX%%/etc/mogtracker.conf"
+[ -z "$mogilefsd_user" ] && mogilefsd_user="nobody"
 
+command="%%PREFIX%%/bin/mogilefsd"
+command_args="$mogilefsd_flags >/dev/null &"
+
+load_rc_config $name
 run_rc_command "$1"
diff -ruN --exclude=CVS /usr/ports/sysutils/p5-MogileFS-Server/files/mogstored.in /home/staff/gslin/work/ports/p5-MogileFS-Server/files/mogstored.in
--- /usr/ports/sysutils/p5-MogileFS-Server/files/mogstored.in	2012-02-12 06:37:24.000000000 +0800
+++ /home/staff/gslin/work/ports/p5-MogileFS-Server/files/mogstored.in	2012-02-12 08:31:03.000000000 +0800
@@ -14,6 +14,11 @@
 required_files=%%PREFIX%%/etc/mogstored.conf
 
 [ -z "$mogstored_enable" ] && mogstored_enable="NO"
-[ -z "$mogstored_flags" ] && mogstored_flags="-d --config=/usr/local/etc/mogstored.conf"
+[ -z "$mogstored_flags" ] && mogstored_flags="--config=%%PREFIX%%/etc/mogstored.conf"
+[ -z "$mogstored_user" ] && mogstored_user="nobody"
 
+command="%%PREFIX%%/bin/mogstored"
+command_args="-d $mogstored_flags"
+
+load_rc_config $name
 run_rc_command "$1"
--- p5-MogileFS-Server-2.57_2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->perl 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Feb 12 00:40:20 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165007 
Responsible-Changed-From-To: perl->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Sun Feb 12 20:38:50 UTC 2012 
Responsible-Changed-Why:  
I will take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165007 
State-Changed-From-To: open->feedback 
State-Changed-By: pgollucci 
State-Changed-When: Sun Feb 12 20:41:47 UTC 2012 
State-Changed-Why:  
doug can you review this quickly. I would love not to screw it up twice 


Responsible-Changed-From-To: pgollucci->dougb 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Sun Feb 12 20:41:47 UTC 2012 
Responsible-Changed-Why:  
doug can you review this quickly. I would love not to screw it up twice 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165007 
Responsible-Changed-From-To: dougb->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Tue Feb 14 02:18:09 UTC 2012 
Responsible-Changed-Why:  
I will take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165007 
State-Changed-From-To: feedback->closed 
State-Changed-By: pgollucci 
State-Changed-When: Wed Feb 15 01:05:51 UTC 2012 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165007 
>Unformatted:
