From nobody@FreeBSD.org  Sat Feb 11 04:32:30 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E3ADF106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 11 Feb 2012 04:32:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D32B08FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 11 Feb 2012 04:32:30 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q1B4WUtT069910
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 11 Feb 2012 04:32:30 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q1B4WUNm069909;
	Sat, 11 Feb 2012 04:32:30 GMT
	(envelope-from nobody)
Message-Id: <201202110432.q1B4WUNm069909@red.freebsd.org>
Date: Sat, 11 Feb 2012 04:32:30 GMT
From: James Kelly <james@hicag.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] mail/libspf2 doesn't build with Clang.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         164974
>Category:       ports
>Synopsis:       [PATCH] mail/libspf2 doesn't build with Clang.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 11 04:40:11 UTC 2012
>Closed-Date:    Sun Feb 12 03:39:01 UTC 2012
>Last-Modified:  Sun Feb 12 03:40:09 UTC 2012
>Originator:     James Kelly
>Release:        9.0-STABLE
>Organization:
>Environment:
FreeBSD trilobite.build.stf.ord.tilted.net 9.0-STABLE FreeBSD 9.0-STABLE #0: Fri Feb 10 15:46:00 CST 2012     jjk@trilobite.build.stf.ord.tilted.net:/.amd_mnt/FreeBSD_9/obj/amd64.amd64/.amd_mnt/FreeBSD_9/src/sys/GREENHOUSE  amd64
>Description:
mail/libspf2 doesn't build with Clang due to the way it uses __VA_ARGS__ in logging macros.
>How-To-Repeat:
Build mail/libspf2
>Fix:


Patch attached with submission follows:

Index: files/patch-src__include__spf_log.h
===================================================================
--- files/patch-src__include__spf_log.h	(revision 0)
+++ files/patch-src__include__spf_log.h	(revision 4147)
@@ -0,0 +1,17 @@
+--- ./src/include/spf_log.h.orig	Sat Sep 13 22:04:44 2008
++++ ./src/include/spf_log.h	Tue Feb  7 17:01:49 2012
+@@ -60,10 +60,10 @@
+ 
+ #if defined( __STDC_VERSION__ ) && __STDC_VERSION__ >= 199901L
+ 
+-#define SPF_errorf(format, ... ) SPF_errorx( __FILE__, __LINE__, format, __VA_ARGS__ )
+-#define SPF_warningf(format, ... ) SPF_warningx( __FILE__, __LINE__, format, __VA_ARGS__ )
+-#define SPF_infof(format, ... ) SPF_infox( __FILE__, __LINE__, format, __VA_ARGS__ )
+-#define SPF_debugf(format, ... ) SPF_debugx( __FILE__, __LINE__, format, __VA_ARGS__ )
++#define SPF_errorf( ... ) SPF_errorx( __FILE__, __LINE__, __VA_ARGS__ )
++#define SPF_warningf( ... ) SPF_warningx( __FILE__, __LINE__, __VA_ARGS__ )
++#define SPF_infof( ... ) SPF_infox( __FILE__, __LINE__, __VA_ARGS__ )
++#define SPF_debugf( ... ) SPF_debugx( __FILE__, __LINE__, __VA_ARGS__ )
+ 
+ #elif defined( __GNUC__ )
+ 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Feb 11 04:40:21 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164974 
State-Changed-From-To: open->closed 
State-Changed-By: sunpoet 
State-Changed-When: Sun Feb 12 03:38:59 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164974 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/164974: commit references a PR
Date: Sun, 12 Feb 2012 03:39:41 +0000 (UTC)

 sunpoet     2012-02-12 03:38:52 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/libspf2         Makefile 
   Log:
   - Fix build with clang
   
   PR:             ports/164974
   Submitted by:   James Kelly <james@hicag.org>
   
   Revision  Changes    Path
   1.21      +2 -2      ports/mail/libspf2/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
