From nobody@FreeBSD.org  Tue Feb  7 23:31:54 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 014521065670
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Feb 2012 23:31:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id E50D08FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Feb 2012 23:31:53 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q17NVrDS052616
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 7 Feb 2012 23:31:53 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q17NVrNY052615;
	Tue, 7 Feb 2012 23:31:53 GMT
	(envelope-from nobody)
Message-Id: <201202072331.q17NVrNY052615@red.freebsd.org>
Date: Tue, 7 Feb 2012 23:31:53 GMT
From: "4721@hushmail.com" <4721@hushmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] unbreak devel/avr-gcc
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: scheidell@FreeBSD.org

>Number:         164874
>Category:       ports
>Synopsis:       [patch] unbreak devel/avr-gcc
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    joerg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 07 23:40:10 UTC 2012
>Closed-Date:    Fri Mar 09 18:17:18 MET 2012
>Last-Modified:  Fri Mar  9 17:20:11 UTC 2012
>Originator:     4721@hushmail.com
>Release:        
>Organization:
>Environment:
>Description:

>How-To-Repeat:

>Fix:
patch fixes objdump usage, which resolves no plugin build/install on non-i386
and fixes packing list.


Patch attached with submission follows:

--- ports/devel/avr-gcc/Makefile.orig
+++ ports/devel/avr-gcc/Makefile
@@ -45,7 +45,6 @@
 
 .if (${ARCH} == "amd64")
 ARCH=		x86_64
-BROKEN=		does not package
 .endif
 
 CONFLICTS=	avr-gcc-3* avr-gcc-42*
--- ports/devel/avr-gcc/files/patch-plugins
+++ ports/devel/avr-gcc/files/patch-plugins
@@ -0,0 +1,18 @@
+--- gcc/configure.orig
++++ gcc/configure
+@@ -25460,13 +25460,13 @@
+ $as_echo_n "checking for exported symbols... " >&6; }
+   echo "int main() {return 0;} int foobar() {return 0;}" > conftest.c
+   ${CC} ${CFLAGS} ${LDFLAGS} conftest.c -o conftest > /dev/null 2>&1
+-  if $gcc_cv_objdump -T conftest | grep foobar > /dev/null; then
++  if $ac_cv_prog_OBJDUMP -T conftest | grep foobar > /dev/null; then
+     : # No need to use a flag
+   else
+     { $as_echo "$as_me:${as_lineno-$LINENO}: checking for -rdynamic" >&5
+ $as_echo_n "checking for -rdynamic... " >&6; }
+     ${CC} ${CFLAGS} ${LDFLAGS} -rdynamic conftest.c -o conftest > /dev/null 2>&1
+-    if $gcc_cv_objdump -T conftest | grep foobar > /dev/null; then
++    if $ac_cv_prog_OBJDUMP -T conftest | grep foobar > /dev/null; then
+       plugin_rdynamic=yes
+       pluginlibs="-rdynamic"
+     else
--- ports/devel/avr-gcc/pkg-plist.orig
+++ ports/devel/avr-gcc/pkg-plist
@@ -196,6 +196,7 @@
 share/locale/el/LC_MESSAGES/gcc.mo
 share/locale/es/LC_MESSAGES/cpplib.mo
 share/locale/es/LC_MESSAGES/gcc.mo
+share/locale/fi/LC_MESSAGES/cpplib.mo
 share/locale/fi/LC_MESSAGES/gcc.mo
 share/locale/fr/LC_MESSAGES/cpplib.mo
 share/locale/fr/LC_MESSAGES/gcc.mo


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->joerg 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Feb 7 23:40:20 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164874 

From: Michael Scheidell <scheidell@secnap.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/164874: [patch] unbreak devel/avr-gcc
Date: Tue, 21 Feb 2012 15:39:47 -0500 (EST)

 --ELM1329856787-86149-0_
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain; charset="US-ASCII"
 
 Thought I would present this complete patch.
 (bump portrevision since pkg-plist change)
 
 portlints fine. added USE_GETTEXT=yes for completeness (it needs gettext anyway, via bison. , and keeps portlint happy)
 
Also, if user set WITHOUT_NLS when compiling bison, it would not have pulled in gettext.
(if gettext is not really needed in avr-gcc, you could so what the maintainer did in bison, wrap if !defined(), )

 looks fine in tinderbox, 8-i386, and 9-amd64
 
 logs
 
 http://people.freebsd.org/~scheidell/8_I386_avr-gcc-4.5.1_1.log
 http://people.freebsd.org/~scheidell/9_AMD64_avr-gcc-4.5.1_1.log
 
 -- 
 Michael Scheidell, CTO
 SECNAP Network Security Corporation
 (561) 999-5000 scheidell@secnap.net
 http://www.secnap.com/
 
 ______________________________________________________________________
 This email has been scanned and certified safe by SpammerTrap(r). 
 For Information please see http://www.spammertrap.com/
 ______________________________________________________________________  
   
 --ELM1329856787-86149-0_
 Content-Transfer-Encoding: 7bit
 Content-Type: text/x-patch
 Content-Disposition: attachment; filename="pr_164874_devel_avr-gcc.patch"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/devel/avr-gcc/Makefile,v
 retrieving revision 1.76
 diff -u -r1.76 Makefile
 --- Makefile	30 Dec 2011 19:25:08 -0000	1.76
 +++ Makefile	21 Feb 2012 20:36:09 -0000
 @@ -7,6 +7,7 @@
  
  PORTNAME=	gcc
  PORTVERSION=	4.5.1
 +PORTREVISION=	1
  CATEGORIES=	devel
  MASTER_SITES=	${MASTER_SITE_GCC}
  MASTER_SITES+=	http://people.freebsd.org/~joerg/:local
 @@ -39,13 +40,13 @@
  USE_BZIP2=	yes
  USE_GMAKE=	yes
  USE_BISON=	build
 +USE_GETTEXT=	yes
  GNU_CONFIGURE=	yes
  
  .include <bsd.port.pre.mk>
  
  .if (${ARCH} == "amd64")
  ARCH=		x86_64
 -BROKEN=		does not package
  .endif
  
  CONFLICTS=	avr-gcc-3* avr-gcc-42*
 Index: pkg-plist
 ===================================================================
 RCS file: /home/pcvs/ports/devel/avr-gcc/pkg-plist,v
 retrieving revision 1.35
 diff -u -r1.35 pkg-plist
 --- pkg-plist	17 Dec 2011 09:56:31 -0000	1.35
 +++ pkg-plist	21 Feb 2012 20:36:09 -0000
 @@ -196,6 +196,7 @@
  share/locale/el/LC_MESSAGES/gcc.mo
  share/locale/es/LC_MESSAGES/cpplib.mo
  share/locale/es/LC_MESSAGES/gcc.mo
 +share/locale/fi/LC_MESSAGES/cpplib.mo
  share/locale/fi/LC_MESSAGES/gcc.mo
  share/locale/fr/LC_MESSAGES/cpplib.mo
  share/locale/fr/LC_MESSAGES/gcc.mo
 Index: files/patch-plugins
 ===================================================================
 RCS file: files/patch-plugins
 diff -N files/patch-plugins
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/patch-plugins	21 Feb 2012 20:36:09 -0000
 @@ -0,0 +1,18 @@
 +--- gcc/configure.orig
 ++++ gcc/configure
 +@@ -25460,13 +25460,13 @@
 + $as_echo_n "checking for exported symbols... " >&6; }
 +   echo "int main() {return 0;} int foobar() {return 0;}" > conftest.c
 +   ${CC} ${CFLAGS} ${LDFLAGS} conftest.c -o conftest > /dev/null 2>&1
 +-  if $gcc_cv_objdump -T conftest | grep foobar > /dev/null; then
 ++  if $ac_cv_prog_OBJDUMP -T conftest | grep foobar > /dev/null; then
 +     : # No need to use a flag
 +   else
 +     { $as_echo "$as_me:${as_lineno-$LINENO}: checking for -rdynamic" >&5
 + $as_echo_n "checking for -rdynamic... " >&6; }
 +     ${CC} ${CFLAGS} ${LDFLAGS} -rdynamic conftest.c -o conftest > /dev/null 2>&1
 +-    if $gcc_cv_objdump -T conftest | grep foobar > /dev/null; then
 ++    if $ac_cv_prog_OBJDUMP -T conftest | grep foobar > /dev/null; then
 +       plugin_rdynamic=yes
 +       pluginlibs="-rdynamic"
 +     else
 
 --ELM1329856787-86149-0_--

From: Michael Scheidell <scheidell@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/164874: [patch] unbreak devel/avr-gcc
Date: Sat, 25 Feb 2012 06:06:31 -0500 (EST)

 --ELM1330167991-95097-0_
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain; charset="US-ASCII"
 
 ping?  Do you have any problem having this latest patch committed?
 -- 
 Michael Scheidell, CTO
 SECNAP Network Security Corporation
 http://people.freebsd.org/~scheidell
 
 ______________________________________________________________________
 This email has been scanned and certified safe by SpammerTrap(r). 
 For Information please see http://www.spammertrap.com/
 ______________________________________________________________________  
   
 --ELM1330167991-95097-0_
 Content-Transfer-Encoding: 7bit
 Content-Type: text/x-patch
 Content-Disposition: attachment; filename="pr_164874_devel_avr-gcc.patch"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/devel/avr-gcc/Makefile,v
 retrieving revision 1.76
 diff -u -r1.76 Makefile
 --- Makefile	30 Dec 2011 19:25:08 -0000	1.76
 +++ Makefile	21 Feb 2012 20:36:09 -0000
 @@ -7,6 +7,7 @@
  
  PORTNAME=	gcc
  PORTVERSION=	4.5.1
 +PORTREVISION=	1
  CATEGORIES=	devel
  MASTER_SITES=	${MASTER_SITE_GCC}
  MASTER_SITES+=	http://people.freebsd.org/~joerg/:local
 @@ -39,13 +40,13 @@
  USE_BZIP2=	yes
  USE_GMAKE=	yes
  USE_BISON=	build
 +USE_GETTEXT=	yes
  GNU_CONFIGURE=	yes
  
  .include <bsd.port.pre.mk>
  
  .if (${ARCH} == "amd64")
  ARCH=		x86_64
 -BROKEN=		does not package
  .endif
  
  CONFLICTS=	avr-gcc-3* avr-gcc-42*
 Index: pkg-plist
 ===================================================================
 RCS file: /home/pcvs/ports/devel/avr-gcc/pkg-plist,v
 retrieving revision 1.35
 diff -u -r1.35 pkg-plist
 --- pkg-plist	17 Dec 2011 09:56:31 -0000	1.35
 +++ pkg-plist	21 Feb 2012 20:36:09 -0000
 @@ -196,6 +196,7 @@
  share/locale/el/LC_MESSAGES/gcc.mo
  share/locale/es/LC_MESSAGES/cpplib.mo
  share/locale/es/LC_MESSAGES/gcc.mo
 +share/locale/fi/LC_MESSAGES/cpplib.mo
  share/locale/fi/LC_MESSAGES/gcc.mo
  share/locale/fr/LC_MESSAGES/cpplib.mo
  share/locale/fr/LC_MESSAGES/gcc.mo
 Index: files/patch-plugins
 ===================================================================
 RCS file: files/patch-plugins
 diff -N files/patch-plugins
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/patch-plugins	21 Feb 2012 20:36:09 -0000
 @@ -0,0 +1,18 @@
 +--- gcc/configure.orig
 ++++ gcc/configure
 +@@ -25460,13 +25460,13 @@
 + $as_echo_n "checking for exported symbols... " >&6; }
 +   echo "int main() {return 0;} int foobar() {return 0;}" > conftest.c
 +   ${CC} ${CFLAGS} ${LDFLAGS} conftest.c -o conftest > /dev/null 2>&1
 +-  if $gcc_cv_objdump -T conftest | grep foobar > /dev/null; then
 ++  if $ac_cv_prog_OBJDUMP -T conftest | grep foobar > /dev/null; then
 +     : # No need to use a flag
 +   else
 +     { $as_echo "$as_me:${as_lineno-$LINENO}: checking for -rdynamic" >&5
 + $as_echo_n "checking for -rdynamic... " >&6; }
 +     ${CC} ${CFLAGS} ${LDFLAGS} -rdynamic conftest.c -o conftest > /dev/null 2>&1
 +-    if $gcc_cv_objdump -T conftest | grep foobar > /dev/null; then
 ++    if $ac_cv_prog_OBJDUMP -T conftest | grep foobar > /dev/null; then
 +       plugin_rdynamic=yes
 +       pluginlibs="-rdynamic"
 +     else
 
 --ELM1330167991-95097-0_--

From: Michael Scheidell <scheidell@freebsd.org>
To: <bug-followup@FreeBSD.org>
Cc:  
Subject: Re: ports/164874: [patch] unbreak devel/avr-gcc
Date: Fri, 9 Mar 2012 08:27:02 -0500

 ping... just a reminder, I have tested this in 7,8,9, amd64 and i386 
 tinderbox, compiles and builds fine, and submitter has tested the 
 functionality.
 8.3 rc1 is here, and we are in a ports (slush), but this should qualify 
 for a Feature Safe tag.
 
 
 -- 
 Michael Scheidell, CTO
  >*| * SECNAP Network Security Corporation
 d: +1.561.948.2259
 w: http://people.freebsd.org/~scheidell
State-Changed-From-To: open->closed 
State-Changed-By: joerg 
State-Changed-When: Fri Mar 9 18:16:50 MET 2012 
State-Changed-Why:  
Provided fix applied, thanks a lot! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164874 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/164874: commit references a PR
Date: Fri,  9 Mar 2012 17:14:24 +0000 (UTC)

 joerg       2012-03-09 17:14:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/avr-gcc        Makefile pkg-plist 
   Added files:
     devel/avr-gcc/files  patch-plugins 
   Log:
   Unbreak devel/avr-gcc:
   
   . fix pkg-plist
   . mention gettext prerequisite
   . use the correct objdump utility
   
   PR:             ports/164874
   Submitted by:   Michael Scheidell
   Approved by:    portmgr (erwin)
   Feature safe:   yes
   
   Revision  Changes    Path
   1.77      +2 -1      ports/devel/avr-gcc/Makefile
   1.1       +18 -0     ports/devel/avr-gcc/files/patch-plugins (new)
   1.36      +1 -0      ports/devel/avr-gcc/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
