From nobody@FreeBSD.org  Tue Jan 31 10:58:44 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8CB61106568C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 Jan 2012 10:58:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 7A3108FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 Jan 2012 10:58:44 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0VAwi74051618
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 Jan 2012 10:58:44 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q0VAwicM051617;
	Tue, 31 Jan 2012 10:58:44 GMT
	(envelope-from nobody)
Message-Id: <201201311058.q0VAwicM051617@red.freebsd.org>
Date: Tue, 31 Jan 2012 10:58:44 GMT
From: Neil Darlow <neil@darlow.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Configuration introduced into postgresql91-contrib overwrites that of postgresql91-server|client
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         164662
>Category:       ports
>Synopsis:       databases/postgresql91-contrib: Configuration introduced overwrites postgresql91-server|client
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 31 11:00:32 UTC 2012
>Closed-Date:    Tue Jan 31 18:22:39 UTC 2012
>Last-Modified:  Wed Feb  1 11:00:25 UTC 2012
>Originator:     Neil Darlow
>Release:        8.2-RELENG
>Organization:
>Environment:
FreeBSD router.darlow.co.uk 8.2-RELEASE-p5 FreeBSD 8.2-RELEASE-p5 #0: Sat Dec 24 03:20:31 GMT 2011     root@router.darlow.co.uk:/usr/obj/usr/src/sys/ROUTER  i386
>Description:
The ossp-uuid option introduced into postgresql-contrib-9.1.2_3 overwrites options set through postgresql-server-9.1.2_3.
>How-To-Repeat:
1) make -C /usr/ports/databases/postgresql91-server config
2) Close options dialog with Save
3) Observe options correctly set in /var/db/ports/postgresql91/options
4) make -C /usr/ports/databases/postgresql91-contrib config
5) Close options dialog with Save
6) Observe server options overwritten in /var/db/ports/postgresql91/options

>Fix:
Can't the postgresql-contrib option be moved into postgresql91-server/Makefile?

Wouldn't the use of ossp-uuid need to be global throughout postgresql91-* builds anyway?

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: jgh 
Responsible-Changed-When: Tue Jan 31 14:42:15 UTC 2012 
Responsible-Changed-Why:  
update synopsis and assign 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164662 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Tue Jan 31 18:22:39 UTC 2012 
State-Changed-Why:  
Thanks for reporting.  I've fixed this by giving -contrib a different 
UNIQUENAME from -server and -client; the other two share options where 
-contrib does not. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164662 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/164662: commit references a PR
Date: Tue, 31 Jan 2012 18:21:46 +0000 (UTC)

 crees       2012-01-31 18:21:33 UTC
 
   FreeBSD ports repository
 
   Modified files:
     databases/postgresql91-contrib Makefile 
     databases/postgresql91-server Makefile 
   Log:
   - Stop clobbering postgresql-server/-client OPTIONS with -contrib OPTIONS
   - Minor optimisation (stop testing for !SLAVE_ONLY twice)
   
   PR:             ports/164662
   
   Revision  Changes    Path
   1.5       +0 -2      ports/databases/postgresql91-contrib/Makefile
   1.242     +5 -4      ports/databases/postgresql91-server/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Neil Darlow <neil@darlow.co.uk>
To: bug-followup@freebsd.org, neil@darlow.co.uk
Cc:  
Subject: Re: ports/164662: databases/postgresql91-contrib: Configuration introduced overwrites postgresql91-server|client
Date: Wed, 1 Feb 2012 10:39:50 +0000

 The UNIQUENAME construction isn't quite correct.
 
 PKGNAMESUFFIX is -contrib and UNIQUENAME is created with 
 ${...}-${PKGNAMESUFFIX}.
 
 This leads to the creation of /var/db/ports/postgresql91--contrib instead of 
 /var/db/ports/postgresql91-contrib.
 
 That is, two hyphens instead of one.
>Unformatted:
