From nobody@FreeBSD.org  Wed Jan 25 13:28:30 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6CC231065670
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Jan 2012 13:28:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 4B68E8FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Jan 2012 13:28:30 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0PDSUvg097153
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Jan 2012 13:28:30 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q0PDSTD4097152;
	Wed, 25 Jan 2012 13:28:29 GMT
	(envelope-from nobody)
Message-Id: <201201251328.q0PDSTD4097152@red.freebsd.org>
Date: Wed, 25 Jan 2012 13:28:29 GMT
From: Pierre DAVID <pdagog@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Upgrade database/pgtcl to 2.0.0 (patch included)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         164478
>Category:       ports
>Synopsis:       Upgrade databases/pgtcl to 2.0.0 (patch included)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 25 13:30:10 UTC 2012
>Closed-Date:    Fri Feb 24 21:39:17 UTC 2012
>Last-Modified:  Fri Feb 24 21:39:17 UTC 2012
>Originator:     Pierre DAVID
>Release:        9.0-RELEASE
>Organization:
>Environment:
FreeBSD vagabond.ma.maison 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC 2012     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Upgrade database/pgtcl from 1.9.0 to 2.0.0
and allow Tcl 8.6 use.
Since pgtcl 2.0.0 uses the Tcl dict command, minimum
Tcl version is this 8.5.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -rud pgtcl.orig/Makefile pgtcl/Makefile
--- pgtcl.orig/Makefile	2012-01-25 08:48:10.000000000 +0100
+++ pgtcl/Makefile	2012-01-25 13:36:16.000000000 +0100
@@ -6,10 +6,10 @@
 #
 
 PORTNAME=	pgtcl
-PORTVERSION=	1.9.0
+PORTVERSION=	2.0.0
 CATEGORIES=	databases tcl
 MASTER_SITES=	SF/pgtclng/pgtclng/${PORTVERSION}:src	\
-		SF/pgtclng/Manual/20110321:doc
+		SF/pgtclng/Manual/20110918:doc
 MASTER_SITE_SUBDIR=	pgtclng
 DISTNAME=	${PORTNAME}${PORTVERSION}
 DISTFILES=	${DISTNAME}${EXTRACT_SUFX}:src
@@ -19,7 +19,7 @@
 
 LICENSE=	BSD
 
-USE_TCL=	yes
+USE_TCL=	85+
 USE_PGSQL=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS+=--with-tcl=${TCL_LIBDIR} --with-tclinclude=${TCL_INCLUDEDIR}
@@ -27,7 +27,7 @@
 PLIST_SUB+=	PORTVERSION=${PORTVERSION}
 .if !defined(NOPORTDOCS)
 EXTRACT_ONLY=	${_DISTFILES:M*tar.gz}
-DISTFILES+=	pgtcldocs-20110321.zip:doc
+DISTFILES+=	pgtcldocs-20110918.zip:doc
 MASTER_SITES+=	http://pgfoundry.org/frs/download.php/2836/:doc
 BUILD_DEPENDS=	unzip:${PORTSDIR}/archivers/unzip
 .endif
diff -rud pgtcl.orig/distinfo pgtcl/distinfo
--- pgtcl.orig/distinfo	2011-07-11 06:35:49.000000000 +0200
+++ pgtcl/distinfo	2012-01-25 13:37:32.000000000 +0100
@@ -1,4 +1,4 @@
-SHA256 (pgtcl1.9.0.tar.gz) = b637955c1a6e0353c9308231935f83495c95f59901535a2a3f0bcdc42ac383a1
-SIZE (pgtcl1.9.0.tar.gz) = 189531
-SHA256 (pgtcldocs-20110321.zip) = 0e7eac560db6fbe772b1bfcde35a05ca2c2a3f6ccee730817b84b4bbc1f5260e
-SIZE (pgtcldocs-20110321.zip) = 148280
+SHA256 (pgtcl2.0.0.tar.gz) = f3d8195ecc140837f77985186b8618bb0e9f00a2e1681a46afd8af065ff35db2
+SIZE (pgtcl2.0.0.tar.gz) = 193257
+SHA256 (pgtcldocs-20110918.zip) = 1a86f0909b19358f4ade768f850ad02b27bc06b4cec32486783e133e37e8f344
+SIZE (pgtcldocs-20110918.zip) = 152847
diff -rud pgtcl.orig/pkg-plist pgtcl/pkg-plist
--- pgtcl.orig/pkg-plist	2011-07-11 06:35:49.000000000 +0200
+++ pgtcl/pkg-plist	2012-01-25 13:45:59.000000000 +0100
@@ -3,6 +3,7 @@
 @dirrm lib/pgtcl
 %%PORTDOCS%%%%DOCSDIR%%/index.html
 %%PORTDOCS%%%%DOCSDIR%%/legalnotice.html
+%%PORTDOCS%%%%DOCSDIR%%/pg-backend-pid.html
 %%PORTDOCS%%%%DOCSDIR%%/pg-blocking.html
 %%PORTDOCS%%%%DOCSDIR%%/pg-cancelrequest.html
 %%PORTDOCS%%%%DOCSDIR%%/pg-conndefaults.html
@@ -39,8 +40,9 @@
 %%PORTDOCS%%%%DOCSDIR%%/pg-result.html
 %%PORTDOCS%%%%DOCSDIR%%/pg-select.html
 %%PORTDOCS%%%%DOCSDIR%%/pg-sendquery-params.html
-%%PORTDOCS%%%%DOCSDIR%%/pg-sendquery.html
 %%PORTDOCS%%%%DOCSDIR%%/pg-sendquery-prepared.html
+%%PORTDOCS%%%%DOCSDIR%%/pg-sendquery.html
+%%PORTDOCS%%%%DOCSDIR%%/pg-server-version.html
 %%PORTDOCS%%%%DOCSDIR%%/pg-transaction-status.html
 %%PORTDOCS%%%%DOCSDIR%%/pg-unescape-bytea.html
 %%PORTDOCS%%%%DOCSDIR%%/pgtcl-example-async.html


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jgh 
Responsible-Changed-By: jgh 
Responsible-Changed-When: Wed Jan 25 16:22:02 UTC 2012 
Responsible-Changed-Why:  
I'll take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164478 
State-Changed-From-To: open->feedback 
State-Changed-By: jgh 
State-Changed-When: Wed Jan 25 18:40:17 UTC 2012 
State-Changed-Why:  
Can you please update this patch to take into account releases less than 
9.x having to use ports for unzip, and having unzip already installed in 
/usr/bin otherwise? 

Additionally, if unzip is only a build dependency, maybe it should be 
unzipped into the work directory in a do-build target, and then 
installed with an INSTALL macro, as someone may have unzip installed 
during the building of the code, but not during the installation (if on 
a release less than 9.x) 

Alternatively, you can have the port use tar for zip operations for
all releases.


http://www.freebsd.org/cgi/query-pr.cgi?pr=164478 

From: Pierre DAVID <pdagog@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/164478: Upgrade database pgtcl to 2.0.0 (patch included)
Date: Wed, 25 Jan 2012 22:20:08 +0100

 --FL5UXtIhxfXey3p5
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Here is a new patch using tar.
 
 --FL5UXtIhxfXey3p5
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="pgtcl-patch.txt"
 
 diff -rud pgtcl.orig/Makefile pgtcl/Makefile
 --- pgtcl.orig/Makefile	2012-01-25 08:48:10.000000000 +0100
 +++ pgtcl/Makefile	2012-01-25 22:18:34.000000000 +0100
 @@ -6,10 +6,10 @@
  #
  
  PORTNAME=	pgtcl
 -PORTVERSION=	1.9.0
 +PORTVERSION=	2.0.0
  CATEGORIES=	databases tcl
  MASTER_SITES=	SF/pgtclng/pgtclng/${PORTVERSION}:src	\
 -		SF/pgtclng/Manual/20110321:doc
 +		SF/pgtclng/Manual/20110918:doc
  MASTER_SITE_SUBDIR=	pgtclng
  DISTNAME=	${PORTNAME}${PORTVERSION}
  DISTFILES=	${DISTNAME}${EXTRACT_SUFX}:src
 @@ -19,7 +19,7 @@
  
  LICENSE=	BSD
  
 -USE_TCL=	yes
 +USE_TCL=	85+
  USE_PGSQL=	yes
  GNU_CONFIGURE=	yes
  CONFIGURE_ARGS+=--with-tcl=${TCL_LIBDIR} --with-tclinclude=${TCL_INCLUDEDIR}
 @@ -27,9 +27,8 @@
  PLIST_SUB+=	PORTVERSION=${PORTVERSION}
  .if !defined(NOPORTDOCS)
  EXTRACT_ONLY=	${_DISTFILES:M*tar.gz}
 -DISTFILES+=	pgtcldocs-20110321.zip:doc
 +DISTFILES+=	pgtcldocs-20110918.zip:doc
  MASTER_SITES+=	http://pgfoundry.org/frs/download.php/2836/:doc
 -BUILD_DEPENDS=	unzip:${PORTSDIR}/archivers/unzip
  .endif
  
  post-configure:
 @@ -42,7 +41,9 @@
  	${INSTALL_DATA} ${WRKSRC}/pkgIndex.tcl	\
  		${WRKSRC}/libpgtcl${PORTVERSION}.so ${LIBDIR}
  .if !defined(NOPORTDOCS)
 -	${UNZIP_CMD} -oj ${DISTDIR}/${_DISTFILES:M*.zip} -d ${DOCSDIR}
 +	${MKDIR} -p ${DOCSDIR}
 +	${TAR} -xf ${DISTDIR}/${_DISTFILES:M*.zip} -C ${DOCSDIR} \
 +		--strip-components 1 --no-same-permission --no-same-owner
  .endif
  
  .include <bsd.port.mk>
 diff -rud pgtcl.orig/distinfo pgtcl/distinfo
 --- pgtcl.orig/distinfo	2011-07-11 06:35:49.000000000 +0200
 +++ pgtcl/distinfo	2012-01-25 13:37:32.000000000 +0100
 @@ -1,4 +1,4 @@
 -SHA256 (pgtcl1.9.0.tar.gz) = b637955c1a6e0353c9308231935f83495c95f59901535a2a3f0bcdc42ac383a1
 -SIZE (pgtcl1.9.0.tar.gz) = 189531
 -SHA256 (pgtcldocs-20110321.zip) = 0e7eac560db6fbe772b1bfcde35a05ca2c2a3f6ccee730817b84b4bbc1f5260e
 -SIZE (pgtcldocs-20110321.zip) = 148280
 +SHA256 (pgtcl2.0.0.tar.gz) = f3d8195ecc140837f77985186b8618bb0e9f00a2e1681a46afd8af065ff35db2
 +SIZE (pgtcl2.0.0.tar.gz) = 193257
 +SHA256 (pgtcldocs-20110918.zip) = 1a86f0909b19358f4ade768f850ad02b27bc06b4cec32486783e133e37e8f344
 +SIZE (pgtcldocs-20110918.zip) = 152847
 diff -rud pgtcl.orig/pkg-plist pgtcl/pkg-plist
 --- pgtcl.orig/pkg-plist	2011-07-11 06:35:49.000000000 +0200
 +++ pgtcl/pkg-plist	2012-01-25 13:45:59.000000000 +0100
 @@ -3,6 +3,7 @@
  @dirrm lib/pgtcl
  %%PORTDOCS%%%%DOCSDIR%%/index.html
  %%PORTDOCS%%%%DOCSDIR%%/legalnotice.html
 +%%PORTDOCS%%%%DOCSDIR%%/pg-backend-pid.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-blocking.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-cancelrequest.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-conndefaults.html
 @@ -39,8 +40,9 @@
  %%PORTDOCS%%%%DOCSDIR%%/pg-result.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-select.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-sendquery-params.html
 -%%PORTDOCS%%%%DOCSDIR%%/pg-sendquery.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-sendquery-prepared.html
 +%%PORTDOCS%%%%DOCSDIR%%/pg-sendquery.html
 +%%PORTDOCS%%%%DOCSDIR%%/pg-server-version.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-transaction-status.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-unescape-bytea.html
  %%PORTDOCS%%%%DOCSDIR%%/pgtcl-example-async.html
 Only in pgtcl: work
 
 --FL5UXtIhxfXey3p5--
State-Changed-From-To: feedback->open 
State-Changed-By: jgh 
State-Changed-When: Thu Jan 26 05:52:09 UTC 2012 
State-Changed-Why:  
moving ahead with new patch 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164478 
Responsible-Changed-From-To: jgh->mi 
Responsible-Changed-By: jgh 
Responsible-Changed-When: Thu Jan 26 19:29:17 UTC 2012 
Responsible-Changed-Why:  
fix synopis and assign 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164478 

From: Jason Helfman <jgh@FreeBSD.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/164478: Upgrade database/pgtcl to 2.0.0 (patch included)
Date: Thu, 26 Jan 2012 13:55:11 -0800

 --G4iJoqBmSsgzjUCe
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Disposition: inline
 
 Here is a revised patch. My apologies for grabbing this, as the
 auto-assignment missed with the mis-spelled category.
 
 -jgh
 
 -- 
 Jason Helfman         | FreeBSD Committer
 jgh@FreeBSD.org       | http://people.freebsd.org/~jgh
 
 --G4iJoqBmSsgzjUCe
 Content-Type: text/x-diff; charset=us-ascii
 Content-Disposition: attachment; filename="pgtcl-patch.diff"
 
 ? work
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/databases/pgtcl/Makefile,v
 retrieving revision 1.8
 diff -u -r1.8 Makefile
 --- Makefile	11 Jul 2011 04:35:49 -0000	1.8
 +++ Makefile	26 Jan 2012 20:57:03 -0000
 @@ -6,30 +6,29 @@
  #
  
  PORTNAME=	pgtcl
 -PORTVERSION=	1.9.0
 +PORTVERSION=	2.0.0
  CATEGORIES=	databases tcl
 -MASTER_SITES=	SF/pgtclng/pgtclng/${PORTVERSION}:src	\
 -		SF/pgtclng/Manual/20110321:doc
 +MASTER_SITES=	SF/pgtclng/pgtclng/${PORTVERSION}/	\
 +		SF/pgtclng/Manual/${MANUALREL}/:doc	\
 +		http://pgfoundry.org/frs/download.php/2836/:doc
  MASTER_SITE_SUBDIR=	pgtclng
  DISTNAME=	${PORTNAME}${PORTVERSION}
 -DISTFILES=	${DISTNAME}${EXTRACT_SUFX}:src
 +DISTFILES=	${DISTNAME}${EXTRACT_SUFX}
  
  MAINTAINER=	mi@aldan.algebra.com
  COMMENT=	TCL extension for accessing a PostgreSQL server (PGTCL-NG)
  
  LICENSE=	BSD
  
 -USE_TCL=	yes
 +USE_TCL=	85+
 +MANUALREL=	20110918
  USE_PGSQL=	yes
  GNU_CONFIGURE=	yes
  CONFIGURE_ARGS+=--with-tcl=${TCL_LIBDIR} --with-tclinclude=${TCL_INCLUDEDIR}
  LIBDIR=		${PREFIX}/lib/${PORTNAME}
  PLIST_SUB+=	PORTVERSION=${PORTVERSION}
  .if !defined(NOPORTDOCS)
 -EXTRACT_ONLY=	${_DISTFILES:M*tar.gz}
 -DISTFILES+=	pgtcldocs-20110321.zip:doc
 -MASTER_SITES+=	http://pgfoundry.org/frs/download.php/2836/:doc
 -BUILD_DEPENDS=	unzip:${PORTSDIR}/archivers/unzip
 +DISTFILES+=	pgtcldocs-${MANUALREL}.zip:doc
  .endif
  
  post-configure:
 @@ -42,7 +41,9 @@
  	${INSTALL_DATA} ${WRKSRC}/pkgIndex.tcl	\
  		${WRKSRC}/libpgtcl${PORTVERSION}.so ${LIBDIR}
  .if !defined(NOPORTDOCS)
 -	${UNZIP_CMD} -oj ${DISTDIR}/${_DISTFILES:M*.zip} -d ${DOCSDIR}
 +	${MKDIR} ${DOCSDIR}
 +	@cd ${WRKDIR}/pgtcldocs-${MANUALREL} && \
 +	    ${COPYTREE_SHARE} \* ${DOCSDIR}
  .endif
  
  .include <bsd.port.mk>
 Index: distinfo
 ===================================================================
 RCS file: /home/pcvs/ports/databases/pgtcl/distinfo,v
 retrieving revision 1.4
 diff -u -r1.4 distinfo
 --- distinfo	11 Jul 2011 04:35:49 -0000	1.4
 +++ distinfo	26 Jan 2012 20:57:03 -0000
 @@ -1,4 +1,4 @@
 -SHA256 (pgtcl1.9.0.tar.gz) = b637955c1a6e0353c9308231935f83495c95f59901535a2a3f0bcdc42ac383a1
 -SIZE (pgtcl1.9.0.tar.gz) = 189531
 -SHA256 (pgtcldocs-20110321.zip) = 0e7eac560db6fbe772b1bfcde35a05ca2c2a3f6ccee730817b84b4bbc1f5260e
 -SIZE (pgtcldocs-20110321.zip) = 148280
 +SHA256 (pgtcl2.0.0.tar.gz) = f3d8195ecc140837f77985186b8618bb0e9f00a2e1681a46afd8af065ff35db2
 +SIZE (pgtcl2.0.0.tar.gz) = 193257
 +SHA256 (pgtcldocs-20110918.zip) = 1a86f0909b19358f4ade768f850ad02b27bc06b4cec32486783e133e37e8f344
 +SIZE (pgtcldocs-20110918.zip) = 152847
 Index: pkg-plist
 ===================================================================
 RCS file: /home/pcvs/ports/databases/pgtcl/pkg-plist,v
 retrieving revision 1.3
 diff -u -r1.3 pkg-plist
 --- pkg-plist	11 Jul 2011 04:35:49 -0000	1.3
 +++ pkg-plist	26 Jan 2012 20:57:03 -0000
 @@ -3,6 +3,7 @@
  @dirrm lib/pgtcl
  %%PORTDOCS%%%%DOCSDIR%%/index.html
  %%PORTDOCS%%%%DOCSDIR%%/legalnotice.html
 +%%PORTDOCS%%%%DOCSDIR%%/pg-backend-pid.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-blocking.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-cancelrequest.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-conndefaults.html
 @@ -39,8 +40,9 @@
  %%PORTDOCS%%%%DOCSDIR%%/pg-result.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-select.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-sendquery-params.html
 -%%PORTDOCS%%%%DOCSDIR%%/pg-sendquery.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-sendquery-prepared.html
 +%%PORTDOCS%%%%DOCSDIR%%/pg-sendquery.html
 +%%PORTDOCS%%%%DOCSDIR%%/pg-server-version.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-transaction-status.html
  %%PORTDOCS%%%%DOCSDIR%%/pg-unescape-bytea.html
  %%PORTDOCS%%%%DOCSDIR%%/pgtcl-example-async.html
 
 --G4iJoqBmSsgzjUCe--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/164478: commit references a PR
Date: Fri, 24 Feb 2012 21:21:50 +0000 (UTC)

 mi          2012-02-24 21:21:39 UTC
 
   FreeBSD ports repository
 
   Modified files:
     databases/pgtcl      Makefile distinfo pkg-plist 
   Log:
   Update from 1.9.0 to 2.0.0. Based on
   
   PR:     164478
   Submitted by:   Pierre DAVID, jgh@
   
   Author's readme continues to claim compatibility with Tcl older than 8.5.
   
   Revision  Changes    Path
   1.9       +10 -7     ports/databases/pgtcl/Makefile
   1.5       +4 -4      ports/databases/pgtcl/distinfo
   1.4       +3 -1      ports/databases/pgtcl/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: mi 
State-Changed-When: Fri Feb 24 21:38:25 UTC 2012 
State-Changed-Why:  
Port updated. Thank you very much! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164478 
>Unformatted:
