From jgh@FreeBSD.org  Fri Jan 20 18:38:43 2012
Return-Path: <jgh@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 59826106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 20 Jan 2012 18:38:43 +0000 (UTC)
	(envelope-from jgh@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 43A748FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 20 Jan 2012 18:38:43 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0KIchPA073308
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 20 Jan 2012 18:38:43 GMT
	(envelope-from jgh@freefall.freebsd.org)
Received: (from jgh@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0KIchg9073307;
	Fri, 20 Jan 2012 18:38:43 GMT
	(envelope-from jgh)
Message-Id: <201201201838.q0KIchg9073307@freefall.freebsd.org>
Date: Fri, 20 Jan 2012 18:38:43 GMT
From: Jason Helfman <jgh@FreeBSD.org>
Reply-To: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] sysutils/graid5: remove post-deinstall target
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         164341
>Category:       ports
>Synopsis:       [patch] sysutils/graid5: remove post-deinstall target
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jgh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 20 18:40:09 UTC 2012
>Closed-Date:    Mon Mar 12 05:18:06 UTC 2012
>Last-Modified:  Mon Mar 12 05:20:10 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 8.2-STABLE FreeBSD 8.2-STABLE #5 r227907: Wed Nov 23 21:55:50 UTC 2011 simon@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386


	
>Description:
remove post-deinstall target is bogus

+ add it substitutable pkg-deinstall.in
>How-To-Repeat:
	
>Fix:

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/sysutils/graid5/Makefile,v
retrieving revision 1.6
diff -u -r1.6 Makefile
--- Makefile	12 Dec 2011 00:34:41 -0000	1.6
+++ Makefile	20 Jan 2012 18:33:32 -0000
@@ -22,6 +22,8 @@
 
 KMODDIR?=	/boot/modules
 PLIST_SUB+=	KMODDIR=${KMODDIR:C,^/,,}
+SUB_LIST=	KMODDIR=${KMODDIR}
+SUB_FILES=	pkg-deinstall
 MAKE_ENV+=	KMODDIR=${KMODDIR}
 
 MANCOMPRESSED=	yes
@@ -36,7 +38,4 @@
 post-install:
 	kldxref ${KMODDIR}
 
-post-deinstall:
-	kldxref ${KMODDIR}
-
 .include <bsd.port.mk>
Index: files/pkg-deinstall.in
===================================================================
RCS file: files/pkg-deinstall.in
diff -N files/pkg-deinstall.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/pkg-deinstall.in	20 Jan 2012 18:33:32 -0000
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ $2 = "DEINSTALL" ]; then
+  /usr/sbin/kldxref %%KMODDIR%%
+fi
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->lev 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jan 20 18:40:19 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164341 
Responsible-Changed-From-To: lev->jgh 
Responsible-Changed-By: jgh 
Responsible-Changed-When: Tue Feb 28 01:11:46 UTC 2012 
Responsible-Changed-Why:  
maintainer timeout, I'll take this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164341 
State-Changed-From-To: open->closed 
State-Changed-By: jgh 
State-Changed-When: Mon Mar 12 05:18:05 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164341 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/164341: commit references a PR
Date: Mon, 12 Mar 2012 05:17:52 +0000 (UTC)

 jgh         2012-03-12 05:17:42 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/graid5      Makefile 
   Added files:
     sysutils/graid5/files pkg-deinstall.in 
   Log:
   - drop unknown post-deinstall target and move into SUB_FILES
   - bump PORTREVISION accordingly
   
   PR:     ports/164341
   Submitted by:   jgh@
   Approved by:    maintainer timeout ( 51 days )
   Feature safe:   yes
   
   Revision  Changes    Path
   1.7       +3 -3      ports/sysutils/graid5/Makefile
   1.1       +5 -0      ports/sysutils/graid5/files/pkg-deinstall.in (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
