From yuri.pankov@gmail.com  Sun Jan 15 13:09:04 2012
Return-Path: <yuri.pankov@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 932CB106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 15 Jan 2012 13:09:04 +0000 (UTC)
	(envelope-from yuri.pankov@gmail.com)
Received: from sirius.xvoid.org (sirius.xvoid.org [IPv6:2001:470:28:4ba:20c:29ff:fe62:9a22])
	by mx1.freebsd.org (Postfix) with ESMTP id 3F24E8FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 15 Jan 2012 13:09:03 +0000 (UTC)
Received: from sirius.xvoid.org (yuri@sirius.xvoid.org [IPv6:::1])
	by sirius.xvoid.org (8.14.5/8.14.5) with ESMTP id q0FD91EU097176;
	Sun, 15 Jan 2012 17:09:01 +0400 (MSK)
	(envelope-from yuri.pankov@gmail.com)
Received: (from yuri@localhost)
	by sirius.xvoid.org (8.14.5/8.14.5/Submit) id q0FD91QI097175;
	Sun, 15 Jan 2012 17:09:01 +0400 (MSK)
	(envelope-from yuri.pankov@gmail.com)
Message-Id: <201201151309.q0FD91QI097175@sirius.xvoid.org>
Date: Sun, 15 Jan 2012 17:09:01 +0400 (MSK)
From: Yuri Pankov <yuri.pankov@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: udo.schweigert@siemens.com
Subject: [PATCH] mail/mutt-devel: Fix ICONV option when world is built using WITH_ICONV
X-Send-Pr-Version: 3.113
X-GNATS-Notify: udo.schweigert@siemens.com

>Number:         164138
>Category:       ports
>Synopsis:       [PATCH] mail/mutt-devel: Fix ICONV option when world is built using WITH_ICONV
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 15 13:10:10 UTC 2012
>Closed-Date:    Tue Jan 17 22:37:12 UTC 2012
>Last-Modified:  Tue Jan 17 23:10:06 UTC 2012
>Originator:     Yuri Pankov
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD sirius.xvoid.org 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r229702: Fri Jan  6 19:49:41
>Description:
Explicitly tell configure to link against libiconv to fix the build when the world was built using WITH_ICONV.

Port maintainer (udo.schweigert@siemens.com) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- mutt-devel-1.5.21_3.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/mail/mutt-devel/Makefile,v
retrieving revision 1.325
diff -u -r1.325 Makefile
--- Makefile	22 Nov 2011 19:12:24 -0000	1.325
+++ Makefile	15 Jan 2012 13:06:00 -0000
@@ -392,6 +392,7 @@
 CONFIGURE_ARGS+=	--disable-iconv
 .else
 CONFIGURE_ARGS+=	--with-libiconv-prefix=${LOCALBASE}
+LDFLAGS+=		-liconv
 .endif
 .if defined(WITH_MUTT_IDN)
 CONFIGURE_ARGS+=	--with-idn
--- mutt-devel-1.5.21_3.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Jan 15 13:10:20 UTC 2012 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164138 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: udo.schweigert@siemens.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/164138: [PATCH] mail/mutt-devel: Fix ICONV option when world is built using WITH_ICONV
Date: Sun, 15 Jan 2012 13:10:18 UT

 Maintainer of mail/mutt-devel,
 
 Please note that PR ports/164138 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164138
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Schweigert, Udo CERT" <Udo.Schweigert@siemens.com>
To: "bug-followup@freebsd.org" <bug-followup@freebsd.org>
Cc:  
Subject: Re: ports/164138: [PATCH] mail/mutt-devel: Fix ICONV option when
 world is built using WITH_ICONV
Date: Tue, 17 Jan 2012 10:13:48 +0100

 The submitted patch breaks building on systems < 10.0. As I do not have a
 10.0 system at the moment I can't develop and test a patch for
 -CURRENT. As the port without a change works under -CURRENT (the iconv port
 will be installed and used instead of the system iconv - which is not a
 default part of the system anyway) I would simply close this PR at the
 moment. The iconv as part of the base system should be dealt with by the
 ports-system in a more general way.
 
 Udo
 
 On Sun, Jan 15, 2012 at 14:10:18 +0100, Edwin Groothuis wrote:
 > Maintainer of mail/mutt-devel,
 > 
 > Please note that PR ports/164138 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164138
 > 
 > -- 
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 > 
State-Changed-From-To: feedback->closed 
State-Changed-By: linimon 
State-Changed-When: Tue Jan 17 22:36:55 UTC 2012 
State-Changed-Why:  
Change was rejected by maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164138 

From: Yuri Pankov <yuri.pankov@gmail.com>
To: bug-followup@freebsd.org
Cc: udo.schweigert@siemens.com
Subject: Re: ports/164138: [PATCH] mail/mutt-devel: Fix ICONV option when
 world is built using WITH_ICONV
Date: Wed, 18 Jan 2012 03:02:58 +0400

 While I agree that this should be handled globally rather than in
 individual port Makefiles, I don't see if/how it breaks the build on <
 10.x.
 
 
 Yuri
>Unformatted:
