From nobody@FreeBSD.org  Thu Dec 29 00:29:21 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DEE85106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 29 Dec 2011 00:29:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id B3BD18FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 29 Dec 2011 00:29:21 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBT0TLXh061569
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 29 Dec 2011 00:29:21 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pBT0TLsu061568;
	Thu, 29 Dec 2011 00:29:21 GMT
	(envelope-from nobody)
Message-Id: <201112290029.pBT0TLsu061568@red.freebsd.org>
Date: Thu, 29 Dec 2011 00:29:21 GMT
From: Takeharu KATO <takeharu1219@ybb.ne.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: net/samba4-devel build stops
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         163688
>Category:       ports
>Synopsis:       net/samba4-devel build stops
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    timur
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 29 00:30:10 UTC 2011
>Closed-Date:    Fri Jan 13 11:52:05 UTC 2012
>Last-Modified:  Fri Jan 13 12:00:29 UTC 2012
>Originator:     Takeharu KATO
>Release:        8.2-RELEASE
>Organization:
>Environment:
8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011 
>Description:
Can not build samba4-devel whichh is need to build x11/gnome2.

error messages:
    param/pyparam_util.c: In function 'lp_from_py_object':
    param/pyparam_util.c:50: error: expected expression before 'struct'

same error occurs in  lib/talloc/pytalloc.c

>How-To-Repeat:
type make install in /usr/ports/net/samba4-devel.
>Fix:
Apply the attached patches.


Patch attached with submission follows:

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	patch-lib__talloc__pytalloc.c
#	patch-source4-param-pyparam_util.c
#
echo x - patch-lib__talloc__pytalloc.c
sed 's/^X//' >patch-lib__talloc__pytalloc.c << '9b446a1daafb203374432eb68707cf33'
X--- lib/talloc/pytalloc.c.orig	2011-12-28 04:17:32.076825692 +0900
X+++ lib/talloc/pytalloc.c	2011-12-28 04:22:03.628624873 +0900
X@@ -18,8 +18,8 @@
X */
X 
X #include "replace.h"
X-#include <talloc.h>
X-#include <pytalloc.h>
X+#include "talloc.h"
X+#include "pytalloc.h"
X 
X /**
X  * Simple dealloc for talloc-wrapping PyObjects
9b446a1daafb203374432eb68707cf33
echo x - patch-source4-param-pyparam_util.c
sed 's/^X//' >patch-source4-param-pyparam_util.c << '4dce954c747fc74cba6022905e0f9b1f'
X--- source4/param/pyparam_util.c.orig	2011-12-28 04:07:27.962289417 +0900
X+++ source4/param/pyparam_util.c	2011-12-28 04:04:04.891668850 +0900
X@@ -21,7 +21,7 @@
X #include "includes.h"
X #include "param/param.h"
X #include "param/loadparm.h"
X-#include "pytalloc.h"
X+#include "lib/talloc/pytalloc.h"
X 
X #define PyLoadparmContext_AsLoadparmContext(obj) py_talloc_get_type(obj, struct loadparm_context)
X 
4dce954c747fc74cba6022905e0f9b1f
exit



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->timur 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Dec 29 00:30:22 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163688 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Fri Jan 13 11:51:26 UTC 2012 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163688 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/163688: commit references a PR
Date: Fri, 13 Jan 2012 11:52:00 +0000 (UTC)

 pav         2012-01-13 11:51:51 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/samba4-devel     Makefile 
   Added files:
     net/samba4-devel/files patch-lib-talloc-pytalloc.c 
                            patch-source4-param-pyparam_util.c 
   Log:
   - Fix build and unbreak
   
   PR:             ports/163688
   Submitted by:   Takeharu KATO <takeharu1219@ybb.ne.jp>
   Approved by:    maintainer timeout (timur; 15 days)
   
   Revision  Changes    Path
   1.14      +0 -2      ports/net/samba4-devel/Makefile
   1.1       +11 -0     ports/net/samba4-devel/files/patch-lib-talloc-pytalloc.c (new)
   1.1       +11 -0     ports/net/samba4-devel/files/patch-source4-param-pyparam_util.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
