From delphij@FreeBSD.org  Wed Dec 28 04:28:32 2011
Return-Path: <delphij@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E06E3106564A;
	Wed, 28 Dec 2011 04:28:32 +0000 (UTC)
	(envelope-from delphij@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id CB0798FC0C;
	Wed, 28 Dec 2011 04:28:32 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBS4SWpK044470;
	Wed, 28 Dec 2011 04:28:32 GMT
	(envelope-from delphij@freefall.freebsd.org)
Received: (from delphij@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBS4SWl1044469;
	Wed, 28 Dec 2011 04:28:32 GMT
	(envelope-from delphij)
Message-Id: <201112280428.pBS4SWl1044469@freefall.freebsd.org>
Date: Wed, 28 Dec 2011 04:28:32 GMT
From: Xin LI <delphij@freebsd.org>
Reply-To: Xin LI <delphij@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: gnome@freebsd.org, marcus@freebsd.org
Subject: [PATCH] devel/dbus: use /tmp for socket files
X-Send-Pr-Version: 3.113
X-GNATS-Notify: d@delphij.net

>Number:         163653
>Category:       ports
>Synopsis:       [PATCH] devel/dbus: use /tmp for socket files
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 28 04:30:10 UTC 2011
>Closed-Date:    Wed Dec 28 21:19:18 UTC 2011
>Last-Modified:  Wed Dec 28 21:20:09 UTC 2011
>Originator:     Xin LI
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
iXsystems, Inc.
>Environment:
System: FreeBSD freefall.freebsd.org 8.2-STABLE FreeBSD 8.2-STABLE #5 r227907: Wed Nov 23 21:55:50 UTC 2011 simon@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386


>Description:
	Currently dbus uses /var/tmp as socket directory, which is not
cleaned up upon reboots by defination.

	The proposed patch changes the default place back to the default
/tmp.

>How-To-Repeat:
	Just see /var/tmp accumulating several dbus-* files over time.
>Fix:

--- dbus.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/dbus/Makefile,v
retrieving revision 1.86
diff -u -p -u -r1.86 Makefile
--- Makefile	23 Sep 2011 22:21:53 -0000	1.86
+++ Makefile	26 Dec 2011 12:14:06 -0000
@@ -8,7 +8,7 @@
 
 PORTNAME=	dbus
 PORTVERSION=	1.4.14
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	devel gnome
 MASTER_SITES=	http://dbus.freedesktop.org/releases/dbus/
 
@@ -25,7 +25,7 @@ CONFIGURE_ARGS=--localstatedir=/var \
 	        --with-test-socket-dir=${WRKDIR} \
 		--with-system-pid-file=/var/run/dbus/dbus.pid \
 		--with-system-socket=/var/run/dbus/system_bus_socket \
-		--with-session-socket-dir=/var/tmp \
+		--with-session-socket-dir=/tmp \
 		--disable-doxygen-docs \
 		--disable-xml-docs
 CONFIGURE_ENV=	PTHREAD_LIBS="${PTHREAD_LIBS}"
--- dbus.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Dec 28 04:30:21 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163653 

From: Doug Barton <dougb@FreeBSD.org>
To: bug-followup@FreeBSD.org, delphij@freebsd.org
Cc:  
Subject: Re: ports/163653: [PATCH] devel/dbus: use /tmp for socket files
Date: Tue, 27 Dec 2011 20:40:20 -0800

 Is there any reason not to use /var/run for this? Not everyone cleans
 out /tmp on reboot, but /var/run should always be cleaned (unless the
 user has done something wacky, in which case they are on their own).
 
 BTW, changing it away from /var/tmp is a great idea. I could then remove
 the code I have to clean it up at boot time.
 
 Doug
 
 -- 
 
 	You can observe a lot just by watching.	-- Yogi Berra
 
 	Breadth of IT experience, and depth of knowledge in the DNS.
 	Yours for the right price.  :)  http://SupersetSolutions.com/
 

From: Doug Barton <dougb@FreeBSD.org>
To: Xin LI <delphij@gmail.com>
Cc: bug-followup@freebsd.org, delphij@freebsd.org
Subject: Re: ports/163653: [PATCH] devel/dbus: use /tmp for socket files
Date: Tue, 27 Dec 2011 20:47:07 -0800

 On 12/27/2011 20:46, Xin LI wrote:
 > Yes, primarily because dbus expects random names and and all users
 > needs to be able to create the socket (so parent directory needs to be
 > 1777 rather than the normal ones).
 
 Fair enough. Thanks for clarifying.
 
 
 -- 
 
 	You can observe a lot just by watching.	-- Yogi Berra
 
 	Breadth of IT experience, and depth of knowledge in the DNS.
 	Yours for the right price.  :)  http://SupersetSolutions.com/
 

From: Xin LI <delphij@gmail.com>
To: Doug Barton <dougb@freebsd.org>
Cc: bug-followup@freebsd.org, delphij@freebsd.org
Subject: Re: ports/163653: [PATCH] devel/dbus: use /tmp for socket files
Date: Tue, 27 Dec 2011 20:46:07 -0800

 On Tue, Dec 27, 2011 at 8:40 PM, Doug Barton <dougb@freebsd.org> wrote:
 > Is there any reason not to use /var/run for this? Not everyone cleans
 > out /tmp on reboot, but /var/run should always be cleaned (unless the
 > user has done something wacky, in which case they are on their own).
 
 Yes, primarily because dbus expects random names and and all users
 needs to be able to create the socket (so parent directory needs to be
 1777 rather than the normal ones).
 
 By the way I really don't think /var/run would be cleaned (nor it
 should) because it's important to be able to create a subdirectory
 owned by particular user (e.g. a web server) so unprivileged part of
 these daemons can still make changes to e.g. pid files.
 
 > BTW, changing it away from /var/tmp is a great idea. I could then remove
 > the code I have to clean it up at boot time.
 >
 > Doug
 >
 > --
 >
 > =C2=A0 =C2=A0 =C2=A0 =C2=A0You can observe a lot just by watching. -- Yog=
 i Berra
 >
 > =C2=A0 =C2=A0 =C2=A0 =C2=A0Breadth of IT experience, and depth of knowled=
 ge in the DNS.
 > =C2=A0 =C2=A0 =C2=A0 =C2=A0Yours for the right price. =C2=A0:) =C2=A0http=
 ://SupersetSolutions.com/
 >
 
 
 
 --=20
 Xin LI <delphij@delphij.net> https://www.delphij.net/
 FreeBSD - The Power to Serve! Live free or die
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Wed Dec 28 21:19:05 UTC 2011 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163653 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/163653: commit references a PR
Date: Wed, 28 Dec 2011 21:19:12 +0000 (UTC)

 marcus      2011-12-28 21:18:58 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/dbus           Makefile 
   Log:
   Move the sockets from /var/tmp to /tmp so that they can be cleaned up
   by default on reboot.
   
   PR:             163653
   Submitted by:   delphij
   
   Revision  Changes    Path
   1.87      +2 -2      ports/devel/dbus/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
