From nobody@FreeBSD.org  Sun Dec 25 13:02:10 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 448A21065678
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Dec 2011 13:02:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 2F7AC8FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Dec 2011 13:02:10 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBPD29OS021172
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Dec 2011 13:02:09 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pBPD295w021171;
	Sun, 25 Dec 2011 13:02:09 GMT
	(envelope-from nobody)
Message-Id: <201112251302.pBPD295w021171@red.freebsd.org>
Date: Sun, 25 Dec 2011 13:02:09 GMT
From: Panagiotis Christias <p.christias@noc.ntua.gr>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] lang/v8: make sure that CFLAGS always contains -fno-strict-aliasing
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         163606
>Category:       ports
>Synopsis:       [patch] lang/v8: make sure that CFLAGS always contains -fno-strict-aliasing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    vanilla
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 25 13:10:11 UTC 2011
>Closed-Date:    Sun Dec 25 15:34:09 UTC 2011
>Last-Modified:  Sun Dec 25 15:40:05 UTC 2011
>Originator:     Panagiotis Christias
>Release:        7.4-amd64
>Organization:
NTUA NOC
>Environment:
FreeBSD builder7-amd64.noc.ntua.gr 7.4-RELEASE FreeBSD 7.4-RELEASE #0: Tue Apr  5 14:05:40 EEST 2011     root@thetis.noc.ntua.gr:/usr/obj/usr/src/sys/NTUA  amd64
>Description:
lang/v8 needs -fno-strict-aliasing to compile properly, so if CFLAGS is defined outside the port's Makefile (e.g. in /etc/make.conf) and does not contain -fno-strict-aliasing then default value of CFLAGS gets overwritten and building fails.

Merry Christmas,
Panagiotis

>How-To-Repeat:
Have something like "CFLAGS=-O -pipe" and try to build lang/v8:

# echo "CFLAGS=-O -pipe" >> /etc/make.conf
# cd /usr/ports/lang/v8
# make
>Fix:
See attached patch (could be done in a better way i suppose).

Patch attached with submission follows:

--- /usr/ports/lang/v8//Makefile.orig	2011-11-03 17:13:14.000000000 +0200
+++ /usr/ports/lang/v8//Makefile	2011-12-25 13:35:46.000000000 +0200
@@ -48,6 +48,14 @@
 .elif ${ARCH} == amd64
 V8ARCH=x64
 .endif
+
+.if defined(CFLAGS)
+CFLAGS:=	${CFLAGS:C/-fstrict-aliasing//}
+.if empty(CFLAGS:M-fno-strict-aliasing)
+CFLAGS+=	-fno-strict-aliasing
+.endif
+.endif
+
 PLIST_SUB+=	ARCH=${V8ARCH}
 SCONS_ARGS+=	arch=${V8ARCH}
 SCONS_BUILDENV+= CC="${CC} ${CFLAGS}" CXX="${CXX} ${CXXFLAGS}"


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->vanilla 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Dec 25 13:10:21 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163606 
State-Changed-From-To: open->closed 
State-Changed-By: vanilla 
State-Changed-When: Sun Dec 25 15:34:08 UTC 2011 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163606 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/163606: commit references a PR
Date: Sun, 25 Dec 2011 15:33:55 +0000 (UTC)

 vanilla     2011-12-25 15:33:41 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/v8              Makefile distinfo 
     lang/v8/files        patch-SConstruct 
   Removed files:
     lang/v8/files        patch-platform-freebsd.cc 
   Log:
   1: Upgrade to 3.8.2.
   2: handle '-fno-strict-aliasing'.
   
   PR:             ports/163606
   Submitted by:   Panagiotis Christias <p.christias at noc.ntua.gr> [2]
   
   Revision  Changes    Path
   1.12      +9 -1      ports/lang/v8/Makefile
   1.9       +2 -2      ports/lang/v8/distinfo
   1.3       +3 -3      ports/lang/v8/files/patch-SConstruct
   1.2       +0 -136    ports/lang/v8/files/patch-platform-freebsd.cc (dead)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
