From jbeich@tormail.net  Fri Dec 23 00:35:15 2011
Return-Path: <jbeich@tormail.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 142861065670
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 23 Dec 2011 00:35:15 +0000 (UTC)
	(envelope-from jbeich@tormail.net)
Received: from server2.hudsonvalleyhost.com (server2.hudsonvalleyhost.com [66.7.195.77])
	by mx1.freebsd.org (Postfix) with ESMTP id BAB6A8FC1A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 23 Dec 2011 00:35:14 +0000 (UTC)
Received: from rainbowwarrior.torservers.net ([77.247.181.164]:25896 helo=internal.tormail.net)
	by server2.hudsonvalleyhost.com with esmtpsa (TLSv1:RC4-SHA:128)
	(Exim 4.69)
	(envelope-from <jbeich@tormail.net>)
	id 1Rdt6P-002ldg-Gb
	for FreeBSD-gnats-submit@freebsd.org; Thu, 22 Dec 2011 19:35:13 -0500
Received: from jbeich by internal.tormail.net with local (Exim 4.63)
	(envelope-from <jbeich@tormail.net>)
	id 1Rdt5r-000GBs-A5
	for FreeBSD-gnats-submit@freebsd.org; Fri, 23 Dec 2011 00:34:41 +0000
Message-Id: <1Rdt5r-000GBs-A5@internal.tormail.net>
Date: Fri, 23 Dec 2011 08:34:22 +0800
From: Jan Beich <jbeich@tormail.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] ftp/vsftpd{,-ext}: respect CC/CFLAGS/STRIP uniformly
X-GNATS-Notify: dinoex@FreeBSD.org, gelraen.ua@gmail.com, scheidell@freebsd.org

>Number:         163550
>Category:       ports
>Synopsis:       [patch] ftp/vsftpd{,-ext}: respect CC/CFLAGS/STRIP uniformly
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 23 00:40:04 UTC 2011
>Closed-Date:    Thu Sep 06 16:43:57 CEST 2012
>Last-Modified:  Thu Sep 06 16:43:57 CEST 2012
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
# trap any attempt to not respect CC
$ export PATH=~/.bin:$PATH
$ for cc in CC cc c++ gcc g++ cpp; do ln -s /usr/bin/false ~/.bin/${cc}; done
>Description:
- respect CC (vsftpd-ext)
- respect CFLAGS[1], don't append -O2 as it breaks
  WITH_DEBUG/DEBUG_FLAGS/CFLAGS set in make.conf/Makefile.local
- don't strip unconditionally, rely INSTALL_PROGRAM respecting STRIP[2]
- remove -lwrap from LDFLAGS, rely on vsf_findlibs.sh adding it
- don't link against -lutil on FreeBSD, setproctitle() moved to libc
  more than 10 years ago, ports/ do not support FreeBSD < 7.
- unbreak ssl build by linking against -lssl (vsftpd-ext)

[1] superset of ports/163548
[2] apart from gdb it's also needed in case of system-wide profiling
    with pmcstat/dtrace
>How-To-Repeat:
# either vsftpd or vsftpd-ext
$ make install WITH_DEBUG=
$ command gdb -q /usr/local/libexec/vsftpd
(no debugging symbols found)...(gdb)

# vsftpd-ext
$ printf 'CC=clang\nCXX=clang++\nCPP=clang -E\n' >Makefile.local
$ __MAKE_CONF= make
gcc -c main.c -O2 -pipe -fno-strict-aliasing -O2 -pipe -march=prescott -fno-strict-aliasing -O2 -Wall -W -Wshadow -idirafter dummyinc
*** [main.o] Error code 1

# vsfptd-ext + VSFTPD_SSL option
$ make
===>  Building for vsftpd-ext-ssl-2.3.4.2
[...]
gcc -c ssl.c -O2 -pipe -fno-strict-aliasing -I/usr/include -O2 -pipe -fno-strict-aliasing       -O2 -Wall -W -Wshadow -idirafter dummyinc
[...]
gcc -o vsftpd main.o utility.o prelogin.o ftpcmdio.o postlogin.o privsock.o  tunables.o ftpdataio.o secbuf.o ls.o  postprivparent.o logging.o str.o netstr.o sysstr.o strlist.o  banner.o filestr.o parseconf.o secutil.o  ascii.o oneprocess.o twoprocess.o privops.o standalone.o hash.o  tcpwrap.o ipaddrparse.o access.o features.o readwrite.o opts.o  ssl.o sslslave.o ptracesandbox.o ftppolicy.o sysutil.o sysdeputil.o  charconv.o pasvrules.o usersip.o http.o http_msg.o http_str.o -Wl,-s -lpam  -lwrap  -L/usr/lib
ssl.o: In function `ssl_init':
WRKSRC/ssl.c:62: undefined reference to `SSL_library_init'
WRKSRC/ssl.c:63: undefined reference to `SSLv23_server_method'
WRKSRC/ssl.c:63: undefined reference to `SSL_CTX_new'
WRKSRC/ssl.c:81: undefined reference to `SSL_CTX_ctrl'
WRKSRC/ssl.c:89: undefined reference to `SSL_CTX_use_certificate_chain_file'
WRKSRC/ssl.c:93: undefined reference to `SSL_CTX_use_PrivateKey_file'
WRKSRC/ssl.c:105: undefined reference to `SSL_CTX_use_certificate_chain_file'
WRKSRC/ssl.c:109: undefined reference to `SSL_CTX_use_PrivateKey_file'
WRKSRC/ssl.c:115: undefined reference to `SSL_CTX_set_cipher_list'
WRKSRC/ssl.c:119: undefined reference to `RAND_status'
WRKSRC/ssl.c:133: undefined reference to `SSL_CTX_set_verify'
WRKSRC/ssl.c:137: undefined reference to `SSL_CTX_load_verify_locations'
WRKSRC/ssl.c:141: undefined reference to `SSL_load_client_CA_file'
WRKSRC/ssl.c:146: undefined reference to `SSL_CTX_set_client_CA_list'
WRKSRC/ssl.c:152: undefined reference to `SSL_CTX_set_session_id_context'
WRKSRC/ssl.c:157: undefined reference to `SSL_CTX_set_timeout'
ssl.o: In function `setup_bio_callbacks':
WRKSRC/ssl.c:646: undefined reference to `SSL_get_rbio'
WRKSRC/ssl.c:647: undefined reference to `BIO_set_callback'
WRKSRC/ssl.c:648: undefined reference to `SSL_get_wbio'
WRKSRC/ssl.c:649: undefined reference to `BIO_set_callback'
ssl.o: In function `get_ssl_error':
WRKSRC/ssl.c:640: undefined reference to `SSL_load_error_strings'
WRKSRC/ssl.c:641: undefined reference to `ERR_get_error'
WRKSRC/ssl.c:641: undefined reference to `ERR_error_string'
ssl.o: In function `ssl_read_common':
WRKSRC/ssl.c:268: undefined reference to `SSL_read'
WRKSRC/ssl.c:269: undefined reference to `SSL_get_error'
WRKSRC/ssl.c:276: undefined reference to `SSL_get_shutdown'
WRKSRC/ssl.c:268: undefined reference to `SSL_peek'
WRKSRC/ssl.c:269: undefined reference to `SSL_get_error'
WRKSRC/ssl.c:276: undefined reference to `SSL_get_shutdown'
ssl.o: In function `ssl_write':
WRKSRC/ssl.c:296: undefined reference to `SSL_write'
WRKSRC/ssl.c:297: undefined reference to `SSL_get_error'
ssl.o: In function `ssl_write_str':
WRKSRC/ssl.c:308: undefined reference to `SSL_write'
ssl.o: In function `ssl_data_close':
WRKSRC/ssl.c:392: undefined reference to `SSL_shutdown'
WRKSRC/ssl.c:396: undefined reference to `SSL_shutdown'
WRKSRC/ssl.c:416: undefined reference to `SSL_free'
ssl.o: In function `maybe_log_shutdown_state':
WRKSRC/ssl.c:337: undefined reference to `SSL_get_shutdown'
ssl.o: In function `get_ssl_error':
WRKSRC/ssl.c:640: undefined reference to `SSL_load_error_strings'
WRKSRC/ssl.c:641: undefined reference to `ERR_get_error'
WRKSRC/ssl.c:641: undefined reference to `ERR_error_string'
ssl.o: In function `setup_bio_callbacks':
WRKSRC/ssl.c:646: undefined reference to `SSL_get_rbio'
WRKSRC/ssl.c:647: undefined reference to `BIO_set_callback'
WRKSRC/ssl.c:648: undefined reference to `SSL_get_wbio'
WRKSRC/ssl.c:649: undefined reference to `BIO_set_callback'
ssl.o: In function `ssl_accept':
WRKSRC/ssl.c:442: undefined reference to `SSL_ctrl'
ssl.o: In function `get_ssl':
WRKSRC/ssl.c:518: undefined reference to `SSL_new'
WRKSRC/ssl.c:528: undefined reference to `SSL_set_fd'
WRKSRC/ssl.c:535: undefined reference to `SSL_free'
WRKSRC/ssl.c:538: undefined reference to `SSL_accept'
ssl.o: In function `get_ssl_error':
WRKSRC/ssl.c:640: undefined reference to `SSL_load_error_strings'
WRKSRC/ssl.c:641: undefined reference to `ERR_get_error'
WRKSRC/ssl.c:641: undefined reference to `ERR_error_string'
ssl.o: In function `get_ssl':
WRKSRC/ssl.c:554: undefined reference to `SSL_get_current_cipher'
WRKSRC/ssl.c:554: undefined reference to `SSL_CIPHER_get_version'
WRKSRC/ssl.c:556: undefined reference to `SSL_get_current_cipher'
WRKSRC/ssl.c:560: undefined reference to `SSL_CIPHER_get_name'
WRKSRC/ssl.c:561: undefined reference to `SSL_get_peer_certificate'
WRKSRC/ssl.c:562: undefined reference to `SSL_ctrl'
WRKSRC/ssl.c:578: undefined reference to `X509_free'
ssl.o: In function `ssl_cert_digest':
WRKSRC/ssl.c:606: undefined reference to `SSL_get_peer_certificate'
WRKSRC/ssl.c:615: undefined reference to `EVP_sha256'
WRKSRC/ssl.c:615: undefined reference to `X509_digest'
WRKSRC/ssl.c:620: undefined reference to `X509_free'
ssl.o: In function `ssl_add_entropy':
WRKSRC/ssl.c:689: undefined reference to `RAND_load_file'
ssl.o: In function `bio_callback':
WRKSRC/ssl.c:665: undefined reference to `BIO_ctrl'
gcc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [vsftpd] Error code 1
>Fix:
--- cc_cflags_strip.diff begins here ---
Index: ftp/vsftpd/Makefile
===================================================================
RCS file: /a/.csup/ports/ftp/vsftpd/Makefile,v
retrieving revision 1.48
diff -u -p -r1.48 Makefile
--- ftp/vsftpd/Makefile	23 Sep 2011 22:22:32 -0000	1.48
+++ ftp/vsftpd/Makefile	23 Dec 2011 00:19:51 -0000
@@ -23,8 +23,6 @@ DOCFILES=	AUDIT BENCHMARKS BUGS Changelo
 		README README.security README.ssl REFS REWARD \
 		SIZE SPEED TODO TUNING
 
-LDFLAGS+=	-lwrap
-
 OPTIONS=	RC_NG		"install RC_NG script"		off \
 		VSFTPD_SSL	"Include support for SSL"	off \
 		PIDFILE		"unofficial support for pidfile"	off
@@ -50,10 +48,11 @@ do-configure:
 	${REINPLACE_CMD} -e "s|/etc/vsftpd.conf|${PREFIX}/etc/vsftpd.conf|" \
 		${WRKSRC}/defs.h ${WRKSRC}/vsftpd.conf
 	${REINPLACE_CMD} \
-		-e "s|^CC 	=	gcc|CC	= ${CC}|" \
-		-e "s|^CFLAGS	=|CFLAGS	= ${CFLAGS}|" \
-		-e "s|	-Wl,-s| -Wl,-s ${LDFLAGS}|" \
+		-e '/^CC/s/=/?=/' \
+		-e '/^CFLAGS/{s/=/+=/;s/-O[0-9]//;}' \
+		-e '/^LINK/s/=.*/=/' \
 		${WRKSRC}/Makefile
+	${REINPLACE_CMD} -e '/-lutil/d' ${WRKSRC}/vsf_findlibs.sh
 	${REINPLACE_CMD} -e \
 		"s|#undef VSF_BUILD_TCPWRAPPERS|#define VSF_BUILD_TCPWRAPPERS 1|" \
 		${WRKSRC}/builddefs.h
Index: ftp/vsftpd-ext/Makefile
===================================================================
RCS file: /a/.csup/ports/ftp/vsftpd-ext/Makefile,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile
--- ftp/vsftpd-ext/Makefile	21 Dec 2011 13:18:23 -0000	1.5
+++ ftp/vsftpd-ext/Makefile	23 Dec 2011 00:20:22 -0000
@@ -28,8 +28,6 @@ DOCFILES=	AUDIT BENCHMARKS BUGS Changelo
 		README README.security README.ssl REFS REWARD \
 		SIZE SPEED TODO TUNING
 
-LDFLAGS+=	-lwrap
-
 OPTIONS=	RC_SCRIPT	"install RC_SCRIPT"		on \
 		VSFTPD_SSL	"Include support for SSL"	off
 
@@ -53,10 +51,12 @@ do-configure:
 	${REINPLACE_CMD} -e "s|/etc/vsftpd.conf|${PREFIX}/etc/vsftpd.conf|" \
 		${WRKSRC}/defs.h ${WRKSRC}/vsftpd.conf
 	${REINPLACE_CMD} \
-		-e "s|^CC 	=	gcc|CC	= ${CC}|" \
-		-e "s|^CFLAGS	=|CFLAGS	= ${CFLAGS}|" \
-		-e "s|	-Wl,-s| -Wl,-s ${LDFLAGS}|" \
+		-e '/^CC/s/=/?=/' \
+		-e '/^CFLAGS/{s/=/+=/;s/-O[0-9]//;}' \
+		-e '/^LIBS/s|=.*|= `./vsf_findlibs.sh`|' \
+		-e '/^LINK/s/=.*/=/' \
 		${WRKSRC}/Makefile
+	${REINPLACE_CMD} -e '/-lutil/d' ${WRKSRC}/vsf_findlibs.sh
 	${REINPLACE_CMD} -e \
 		"s|#undef VSF_BUILD_TCPWRAPPERS|#define VSF_BUILD_TCPWRAPPERS 1|" \
 		${WRKSRC}/builddefs.h
Index: ftp/vsftpd-ext/files/patch-Makefile
===================================================================
RCS file: ftp/vsftpd-ext/files/patch-Makefile
diff -N ftp/vsftpd-ext/files/patch-Makefile
--- ftp/vsftpd-ext/files/patch-Makefile	21 Dec 2011 13:19:37 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,14 +0,0 @@
---- ./Makefile.orig	2011-12-13 10:14:07.000000000 +0200
-+++ ./Makefile	2011-12-13 10:15:30.000000000 +0200
-@@ -3,9 +3,9 @@
- INSTALL	=       install
- IFLAGS  = -idirafter dummyinc
- #CFLAGS = -g
--CFLAGS	=       -O2 -Wall -W -Wshadow #-pedantic -Werror -Wconversion
-+CFLAGS	= -O2 -pipe -march=prescott -fno-strict-aliasing       -O2 -Wall -W -Wshadow #-pedantic -Werror -Wconversion
- 
--LIBS	=       -lcap -ldl -lcrypt    -lpam    -lwrap -lnsl    -lssl -lcrypto
-+LIBS=	-lpam
- #                                     |        |               + VSF_BUILD_SSL
- #                                     |        + VSF_BUILD_TCPWRAPPERS
- #                                     + VSF_BUILD_PAM
--- cc_cflags_strip.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Dec 23 00:40:14 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163550 
State-Changed-From-To: open->feedback  
State-Changed-By: scheidell 
State-Changed-When: Fri Dec 23 19:05:27 UTC 2011 
State-Changed-Why:  
Ill take this for vsftpd-ext, leaving vsftpd for maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163550 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/163550: commit references a PR
Date: Fri, 23 Dec 2011 19:19:08 +0000 (UTC)

 scheidell    2011-12-23 19:18:55 UTC
 
   FreeBSD ports repository
 
   Modified files:
     ftp/vsftpd-ext       Makefile 
   Log:
   - respect CC/CFLAGS/STRIP on vsftpd-ext
   
   PR:             ports/163550
   Submitted by:   Jan Beich <jbeich@tormail.net>
   Approved by:    gelraen.ua@gmail.com (maintainer), gabor(mentor)
   
   Revision  Changes    Path
   1.6       +6 -5      ports/ftp/vsftpd-ext/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->analyzed 
State-Changed-By: dinoex 
State-Changed-When: Sat Dec 24 11:27:54 CET 2011 
State-Changed-Why:  

> - respect CC (vsftpd-ext) 

You patch core vsftpd here too,  
I do not see any problems with the old code. 

> - respect CFLAGS[1], don't append -O2 as it breaks 
>  WITH_DEBUG/DEBUG_FLAGS/CFLAGS set in make.conf/Makefile.local 

I do not see any problems with the old code. 
make clean BATCH=1 WITH_VSFTPD_SSL=1 all WITH_DEBUG=1 DEBUG_FLAGS="-g -g" 

Where does -O2 breaks debugging? 

> - don't strip unconditionally, rely INSTALL_PROGRAM respecting STRIP[2] 

ok, INSTALL_PROGRAM should be used. 

> - remove -lwrap from LDFLAGS, rely on vsf_findlibs.sh adding it 

ok, vsf_findlibs does adding it 

> - don't link against -lutil on FreeBSD, setproctitle() moved to libc 
>   more than 10 years ago, ports/ do not support FreeBSD < 7. 

ok 


http://www.freebsd.org/cgi/query-pr.cgi?pr=163550 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/163550: commit references a PR
Date: Sat, 24 Dec 2011 10:51:44 +0000 (UTC)

 dinoex      2011-12-24 10:51:35 UTC
 
   FreeBSD ports repository
 
   Modified files:
     ftp/vsftpd           Makefile 
   Log:
   - remove duplicate -lwrap
   - drop usage of -lutil
   - honor INSTALL_PROGRAM
   PR:             163550
   
   Revision  Changes    Path
   1.49      +2 -2      ports/ftp/vsftpd/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Jan Beich <jbeich@tormail.net>
To: dinoex@FreeBSD.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/163550: [patch] ftp/vsftpd{,-ext}: respect CC/CFLAGS/STRIP uniformly
Date: Sat, 24 Dec 2011 18:52:14 -0100

 dinoex@FreeBSD.org writes:
 
 >> - respect CC (vsftpd-ext)
 >
 > You patch core vsftpd here too,  
 > I do not see any problems with the old code.
 
 I've tried to keep the diff small between vsftpd and vsftpd-ext.
 
   $ diff -up ftp/vsftpd{,-ext}/Makefile
 
 >
 >> - respect CFLAGS[1], don't append -O2 as it breaks 
 >>  WITH_DEBUG/DEBUG_FLAGS/CFLAGS set in make.conf/Makefile.local 
 >
 > I do not see any problems with the old code. 
 > make clean BATCH=1 WITH_VSFTPD_SSL=1 all WITH_DEBUG=1 DEBUG_FLAGS="-g -g" 
 
 WITH_DEBUG=1 won't work unless the port at least respects STRIP.
 
 > Where does -O2 breaks debugging?
 
 Try with DEBUG_FLAGS='-O0 -g3', notice how always -O2 overrides it.
 bsd.port.mk does smth similar by disabling -O* added by sys.mk. Don't
 you want to debug non-optimized code sometimes?
 
 Also, a user may want to override system optimization to -O0, -O1, -O3,
 -O4 or -Ofast for non-debug build, e.g. to benchmark different
 optimization levels. ports/ are supposed to be a tool not a policy how
 to build unless I'm misunderstanding CFLAGS chapter in PH.
 
 http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-cflags.html
 
 >
 >> - don't strip unconditionally, rely INSTALL_PROGRAM respecting STRIP[2] 
 >
 > ok, INSTALL_PROGRAM should be used.
 
 As vendor install target is unused, the port has its own do-install
 target. And INSTALL_PROGRAM is executed too late, the binary is
 stripped during build.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/163550: commit references a PR
Date: Thu,  6 Sep 2012 14:30:22 +0000 (UTC)

 Author: dinoex
 Date: Thu Sep  6 14:29:59 2012
 New Revision: 303756
 URL: http://svn.freebsd.org/changeset/ports/303756
 
 Log:
   - respect INSTALL_PROGRAM, STRIP and custom optimisations in CFLAGS
   PR:		163550
 
 Modified:
   head/ftp/vsftpd/Makefile
 
 Modified: head/ftp/vsftpd/Makefile
 ==============================================================================
 --- head/ftp/vsftpd/Makefile	Thu Sep  6 14:11:07 2012	(r303755)
 +++ head/ftp/vsftpd/Makefile	Thu Sep  6 14:29:59 2012	(r303756)
 @@ -44,6 +44,11 @@ LDFLAGS+=	-L${OPENSSLLIB}
  EXTRA_PATCHES+=	${FILESDIR}/pidfile.patch
  .endif
  
 +VSFTPD_OPTIMIZED=	${CFLAGS:M-O}
 +.if defined(CFLAGS) && !empty(VSFTPD_OPTIMIZED)
 +VSFTPD_NO_OPTIMIZED=	-e "s| -O2 ||"
 +.endif
 +
  # BROKEN on FreeBSD with undefined reference to `__stack_chk_fail_local'
  LDFLAGS+=	 -lssp_nonshared
  
 @@ -58,16 +63,16 @@ do-configure:
  		"s|#undef VSF_BUILD_TCPWRAPPERS|#define VSF_BUILD_TCPWRAPPERS 1|" \
  		${WRKSRC}/builddefs.h
  .endif
 -	${REINPLACE_CMD} -e "s|^listen=|#listen=|" \
 +	${REINPLACE_CMD} -e "s|^listen=.*|listen=NO|" \
  		-e "s|/etc/vsftpd.conf|${PREFIX}/etc/vsftpd.conf|" \
  		${WRKSRC}/defs.h ${WRKSRC}/vsftpd.conf
  	${REINPLACE_CMD} -e "s|/etc/v|${PREFIX}/etc/v|" \
  		${WRKSRC}/vsftpd.8 ${WRKSRC}/vsftpd.conf.5 ${WRKSRC}/tunables.c
 -	${REINPLACE_CMD} \
 +	${REINPLACE_CMD} ${VSFTPD_NO_OPTIMIZED} \
  		-e "s|^CC 	=	gcc|CC	= ${CC}|" \
  		-e "s|^CFLAGS	=|CFLAGS	= ${CFLAGS}|" \
 -		-e "s|^INSTALL	=|INSTALL	= ${INSTALL_PROGRAM}|" \
 -		-e "s|	-Wl,-s| -Wl,-s ${LDFLAGS:S/-rpath=/-Wl,-rpath,/g}|" \
 +		-e "s|$$(INSTALL) -m 755=|$${INSTALL_PROGRAM}|" \
 +		-e "s|	-Wl,-s| -Wl ${LDFLAGS:S/-rpath=/-Wl,-rpath,/g}|" \
  		${WRKSRC}/Makefile
  	${REINPLACE_CMD} -e '/-lutil/d' ${WRKSRC}/vsf_findlibs.sh
  	@${ECHO_CMD} "secure_chroot_dir=${PREFIX}/share/vsftpd/empty" >> \
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->closed 
State-Changed-By: dinoex 
State-Changed-When: Thu Sep 6 16:43:27 CEST 2012 
State-Changed-Why:  
all issues solved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163550 
>Unformatted:
