From nobody@FreeBSD.org  Thu Dec 22 14:05:15 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 37FBD1065679
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Dec 2011 14:05:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 26F648FC1B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Dec 2011 14:05:15 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBME5E2P017555
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Dec 2011 14:05:14 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pBME5EaB017554;
	Thu, 22 Dec 2011 14:05:14 GMT
	(envelope-from nobody)
Message-Id: <201112221405.pBME5EaB017554@red.freebsd.org>
Date: Thu, 22 Dec 2011 14:05:14 GMT
From: Oliver Heesakkers <dev2@heesakkers.info>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] /audio/clementine-player add option for lastfm (and thus ruby)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: g.veniamin@googlemail.com

>Number:         163534
>Category:       ports
>Synopsis:       [patch] audio/clementine-player add option for lastfm (and thus ruby)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 22 14:10:11 UTC 2011
>Closed-Date:    Fri Dec 23 10:19:03 UTC 2011
>Last-Modified:  Fri Dec 23 15:24:04 UTC 2011
>Originator:     Oliver Heesakkers
>Release:        9.0-RC3 amd64
>Organization:
>Environment:
>Description:
I'm trying to keep my system(s) free of ruby. The most recent update of clementine-player however pulls in ruby through the Last.fm service.

Clementine-player will successfully build when audio/liblastfm is not installed, so simply moving that LIB_DEPEND into an option makes it easily possible to avoid having to build ruby.

Since lastfm was heretofore automatic, I defaulted the option to on
>How-To-Repeat:
Do not have ruby installed. Start the installation of clementine-player and watch it pulling in ruby.
>Fix:
diff -ruN clementine-player.orig/Makefile clementine-player/Makefile
--- clementine-player.orig/Makefile     2011-12-21 05:24:01.000000000 +0100
+++ clementine-player/Makefile  2011-12-22 14:52:04.000000000 +0100
@@ -17,8 +17,7 @@
 
 LICENSE=       GPLv3
 
-LIB_DEPENDS=   lastfm.0:${PORTSDIR}/audio/liblastfm \
-               tag.1:${PORTSDIR}/audio/taglib \
+LIB_DEPENDS=   tag.1:${PORTSDIR}/audio/taglib \
                notify.4:${PORTSDIR}/devel/libnotify \
                xine.1:${PORTSDIR}/multimedia/libxine \
                mtp:${PORTSDIR}/audio/libmtp
@@ -37,7 +36,8 @@
 USE_GSTREAMER= gio ogg mp3 flac soup vorbis
 MAKE_JOBS_UNSAFE=      yes
 
-OPTIONS=       VISUALISATION "Visualisations from projectM" off
+OPTIONS=       VISUALISATION "Visualisations from projectM" off \
+               LASTFM "Support Last.fm service (requires ruby)" on
 
 .include <bsd.port.pre.mk>
 
@@ -48,4 +48,8 @@
 PLIST_SUB+=    VSL="@comment "
 .endif
 
+.if defined(WITH_LASTFM)
+LIB_DEPENDS+=  lastfm.0:${PORTSDIR}/audio/liblastfm
+.endif
+
 .include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Dec 22 14:10:22 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163534 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: g.veniamin@googlemail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/163534: [patch] /audio/clementine-player add option for lastfm (and thus ruby)
Date: Thu, 22 Dec 2011 14:10:20 UT

 Maintainer of audio/clementine-player,
 
 Please note that PR ports/163534 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/163534
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Veniamin Gvozdikov <g.veniamin@googlemail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/163534: [patch] /audio/clementine-player add option for
 lastfm (and thus ruby)
Date: Thu, 22 Dec 2011 21:49:47 +0300

 --e89a8f3ba103b4138f04b4b2c30c
 Content-Type: text/plain; charset=ISO-8859-1
 
 I'm agree.
 
 --e89a8f3ba103b4138f04b4b2c30c--
Responsible-Changed-From-To: freebsd-ports-bugs->rm 
Responsible-Changed-By: rm 
Responsible-Changed-When: Fri Dec 23 04:39:45 UTC 2011 
Responsible-Changed-Why:  
I will take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163534 
State-Changed-From-To: feedback->closed 
State-Changed-By: rm 
State-Changed-When: Fri Dec 23 10:19:02 UTC 2011 
State-Changed-Why:  
Committed, thank you! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163534 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/163534: commit references a PR
Date: Fri, 23 Dec 2011 10:17:07 +0000 (UTC)

 rm          2011-12-23 10:16:53 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/clementine-player Makefile 
   Log:
   - install dependency on audio/liblastfm conditionally via OPTIONS (default on)
   
   No need to bump PORTREVISION, because default dependency list is not changed.
   
   PR:             163534
   Submitted by:   Oliver Heesakkers <dev2 at heesakkers dot info>
   Approved by:    maintainer, novel (mentor, implicit)
   
   Revision  Changes    Path
   1.11      +7 -3      ports/audio/clementine-player/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
