From nobody@FreeBSD.org  Wed Dec 14 11:22:01 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B9B8B106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 14 Dec 2011 11:22:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id A3AFA8FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 14 Dec 2011 11:22:01 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBEBM1Cd056910
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 14 Dec 2011 11:22:01 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pBEBM1Rm056909;
	Wed, 14 Dec 2011 11:22:01 GMT
	(envelope-from nobody)
Message-Id: <201112141122.pBEBM1Rm056909@red.freebsd.org>
Date: Wed, 14 Dec 2011 11:22:01 GMT
From: "Denise H. G." <darcsis@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH]www/chromium: fix pulseaudio option
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         163277
>Category:       ports
>Synopsis:       [PATCH]www/chromium: fix pulseaudio option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rene
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 14 11:30:09 UTC 2011
>Closed-Date:    Sun Dec 18 19:51:29 UTC 2011
>Last-Modified:  Sun Dec 18 20:00:24 UTC 2011
>Originator:     Denise H. G.
>Release:        FreeBSD 9.0-PRERELEASE amd64
>Organization:
Pluton
>Environment:
FreeBSD pluton.xbsd.name 9.0-PRERELEASE FreeBSD 9.0-PRERELEASE #0: Fri Dec  9 07:39:16 CST 2011     dhg@pluton.xbsd.name:/opt/obj/sysbld/usr/src/sys/pluton-amd64  amd64

>Description:
Makefile option for 'pulseaudio' should be PULSE paired with WITH_PULSE, or PULSEAUDIO with WITH_PULSEAUDIO. My patch is in favor of the first pair.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- chromium/Makefile.orig	2011-12-14 19:13:37.522440253 +0800
+++ chromium/Makefile	2011-12-14 19:16:32.220437220 +0800
@@ -104,7 +104,7 @@
 GYP_DEFINES+=	use_gconf=0
 .endif
 
-.if defined(WITH_PULSEAUDIO)
+.if defined(WITH_PULSE)
 LIB_DEPENDS+=	pulse.0:${PORTSDIR}/audio/pulseaudio
 GYP_DEFINES+=	use_pulseaudio=1
 .else


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->chromium 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Dec 14 11:30:21 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163277 
Responsible-Changed-From-To: chromium->rene 
Responsible-Changed-By: rene 
Responsible-Changed-When: Wed Dec 14 22:05:35 UTC 2011 
Responsible-Changed-Why:  
I'm on it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163277 
State-Changed-From-To: open->closed 
State-Changed-By: rene 
State-Changed-When: Sun Dec 18 19:51:00 UTC 2011 
State-Changed-Why:  
Committed with some variation, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163277 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/163277: commit references a PR
Date: Sun, 18 Dec 2011 19:50:42 +0000 (UTC)

 rene        2011-12-18 19:50:31 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/chromium         Makefile 
   Log:
   Fix the pulseadio option (PULSEAUDIO instead of PULSE) and respect WITHOUT_PULSEAUDIO.
   
   PR:             ports/163277
   Submitted by:   Denise H.G.
   Discussed with:
   Obtained from:  Chruetertee Chromium development repository
   
   Revision  Changes    Path
   1.62      +2 -2      ports/www/chromium/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
