From jhelfman@experts-exchange.com  Tue Dec 13 17:23:23 2011
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7E554106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Dec 2011 17:23:23 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.experts-exchange.com (mail.experts-exchange.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 3BD2C8FC13
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Dec 2011 17:23:22 +0000 (UTC)
Received: from mail.experts-exchange.com (localhost [127.0.0.1])
	by mail.experts-exchange.com (Postfix) with ESMTP id 00CB96FD6CD
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Dec 2011 09:23:23 -0800 (PST)
Received: from mail.experts-exchange.com ([127.0.0.1])
	by mail.experts-exchange.com (mail.experts-exchange.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 6N+ncWkinUGa for <FreeBSD-gnats-submit@freebsd.org>;
	Tue, 13 Dec 2011 09:23:22 -0800 (PST)
Received: from experts-exchange.com (unknown [192.168.103.120])
	by mail.experts-exchange.com (Postfix) with SMTP id D23CB6FD6CA
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Dec 2011 09:23:22 -0800 (PST)
Received: (nullmailer pid 16796 invoked by uid 1001);
	Tue, 13 Dec 2011 17:22:57 -0000
Message-Id: <1323796977.518800.16795.nullmailer@experts-exchange.com>
Date: Tue, 13 Dec 2011 09:22:57 -0800
From: Jason Helfman <jhelfman@experts-exchange.com>
Reply-To: Jason Helfman <jhelfman@experts-exchange.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] devel/flex-sdk2: unbreak make readme
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         163251
>Category:       ports
>Synopsis:       [patch] devel/flex-sdk2: unbreak make readme
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jgh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 13 17:30:15 UTC 2011
>Closed-Date:    Thu Jan 05 07:38:48 UTC 2012
>Last-Modified:  Thu Jan  5 07:40:10 UTC 2012
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
Experts Exchange, LLC.
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011 root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64


	
>Description:
reassignment of echo_msg breaks make readme
similar fix to ports/163159
>How-To-Repeat:
	
>Fix:

Index: Makefile
===================================================================
RCS file: /home/jhelfman/ncvs/ports/devel/flex-sdk2/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile	21 Jul 2011 05:02:29 -0000	1.7
+++ Makefile	13 Dec 2011 17:20:38 -0000
@@ -35,8 +35,7 @@
 
 .for i in ${DISTFILES}
 .if !exists(${DISTDIR}/${i})
-ECHO_MSG=/usr/bin/printf
-IGNORE=		:\n\
+DISTFILE_INSTRUCTIONS=\n\
 You must fetch the distribution manually.\n\n\
 Please access \n\
 \n\
@@ -47,6 +46,12 @@
 .endif
 .endfor
 
+pre-fetch:
+.if defined(DISTFILE_INSTRUCTIONS)
+	@${PRINTF} "${DISTFILE_INSTRUCTIONS}"
+	@exit 1
+.endif
+
 do-install:
 .for i in asdoc compc fdb mxmlc
 	${INSTALL_SCRIPT} ${WRKSRC}/${i}.sh ${PREFIX}/bin/${i}
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kuriyama 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Dec 13 17:30:27 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163251 

From: Jason Helfman <jhelfman@e-e.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/163251: [patch] devel/flex-sdk2: unbreak make readme
Date: Tue, 13 Dec 2011 11:56:05 -0800

 --3siQDZowHQqNOShm
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Disposition: inline
 
 use ignore
 drop pre-fetch
 
 -- 
 Jason Helfman
 System Administrator
 experts-exchange.com
 http://www.experts-exchange.com/M_4830110.html
 E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
 
 --3siQDZowHQqNOShm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="patch.txt"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/jhelfman/ncvs/ports/devel/flex-sdk2/Makefile,v
 retrieving revision 1.7
 diff -u -r1.7 Makefile
 --- Makefile	21 Jul 2011 05:02:29 -0000	1.7
 +++ Makefile	13 Dec 2011 19:55:12 -0000
 @@ -35,15 +35,7 @@
  
  .for i in ${DISTFILES}
  .if !exists(${DISTDIR}/${i})
 -ECHO_MSG=/usr/bin/printf
 -IGNORE=		:\n\
 -You must fetch the distribution manually.\n\n\
 -Please access \n\
 -\n\
 - ${DOWNLOAD_URL}\n\
 -\n\
 -with a web browser.  Please place the downloaded ${i} \n\
 -in ${DISTDIR}.\n\n
 +IGNORE= You must fetch the distribution manually. Please access ${DOWNLOAD_URL} with a web browser.  Please place the downloaded ${i} in ${DISTDIR}
  .endif
  .endfor
  
 
 --3siQDZowHQqNOShm--
Responsible-Changed-From-To: kuriyama->jgh 
Responsible-Changed-By: jgh 
Responsible-Changed-When: Tue Jan 3 06:46:14 UTC 2012 
Responsible-Changed-Why:  
maintainer timeout -> I'll take this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163251 
State-Changed-From-To: open->closed 
State-Changed-By: jgh 
State-Changed-When: Thu Jan 5 07:38:46 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163251 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/163251: commit references a PR
Date: Thu,  5 Jan 2012 07:35:17 +0000 (UTC)

 jgh         2012-01-05 07:35:00 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/flex-sdk2      Makefile 
   Log:
   - Reassignment of ECHO_MSG breaks 'make readme', so remove and reformat IGNORE.
   
   PR:     ports/163251
   Submitted by:   jgh (me)
   Approved by:    maintainer (timeout), crees (mentor)
   
   Revision  Changes    Path
   1.8       +3 -9      ports/devel/flex-sdk2/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
