From jbeich@tormail.net  Tue Dec 13 06:04:25 2011
Return-Path: <jbeich@tormail.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B02EE106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Dec 2011 06:04:25 +0000 (UTC)
	(envelope-from jbeich@tormail.net)
Received: from server2.hudsonvalleyhost.com (server2.hudsonvalleyhost.com [66.7.195.77])
	by mx1.freebsd.org (Postfix) with ESMTP id 790DF8FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 13 Dec 2011 06:04:25 +0000 (UTC)
Received: from politkovskaja.torservers.net ([77.247.181.165]:30919 helo=internal.tormail.net)
	by server2.hudsonvalleyhost.com with esmtpsa (TLSv1:RC4-SHA:128)
	(Exim 4.69)
	(envelope-from <jbeich@tormail.net>)
	id 1RaLTS-002e91-ND
	for FreeBSD-gnats-submit@freebsd.org; Tue, 13 Dec 2011 01:04:24 -0500
Received: from jbeich by internal.tormail.net with local (Exim 4.63)
	(envelope-from <jbeich@tormail.net>)
	id 1RaLSg-000H5L-D9
	for FreeBSD-gnats-submit@freebsd.org; Tue, 13 Dec 2011 06:03:36 +0000
Message-Id: <1RaLSg-000H5L-D9@internal.tormail.net>
Date: Tue, 13 Dec 2011 12:06:29 +0800
From: Jan Beich <jbeich@tormail.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] vietnamese/libviet: respect CC/CFLAGS

>Number:         163226
>Category:       ports
>Synopsis:       [patch] vietnamese/libviet: respect CC/CFLAGS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    obrien
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 13 06:10:11 UTC 2011
>Closed-Date:    
>Last-Modified:  Sat Oct 20 12:13:10 UTC 2012
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
# slightly different from pointyhat
$ export PATH=~/.bin:$PATH
$ for cc in CC cc c++ gcc g++ cpp; do ln -s /usr/bin/false ~/.bin/${cc}; done
>Description:
>How-To-Repeat:
http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/e.9-exp.20110723205754/vi-libviet-20010210_1.log
>Fix:
--- cc.diff begins here ---
Index: vietnamese/libviet/Makefile
===================================================================
RCS file: /a/.csup/ports/vietnamese/libviet/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- vietnamese/libviet/Makefile	22 Nov 2008 08:43:25 -0000	1.8
+++ vietnamese/libviet/Makefile	13 Dec 2011 03:48:53 -0000
@@ -19,6 +19,8 @@ COMMENT=	VIQR<->VISCII conversion and VI
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}/lib
 USE_BZIP2=	yes
 
+MAKE_ARGS=	${MAKE_ENV:S/CFLAGS/FLAGS/}
+
 do-install:
 	@${INSTALL_DATA} ${WRKSRC}/libvntype.a ${WRKSRC}/libviqr.a  \
 		${PREFIX}/lib
--- cc.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->obrien 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Dec 13 06:10:28 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163226 
State-Changed-From-To: open->closed 
State-Changed-By: obrien 
State-Changed-When: Fri Sep 28 23:39:33 UTC 2012 
State-Changed-Why:  
This seems fixed to me. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163226 

Date: Fri, 28 Sep 2012 18:41:56 -0800
From: Jan Beich <jbeich@tormail.org>
To: obrien@FreeBSD.org
Subject: Re: [patch] vietnamese/libviet: respect CC/CFLAGS

 obrien@FreeBSD.org writes:
 
 > State-Changed-From-To: open->closed 
 > State-Changed-By: obrien 
 > State-Changed-When: Fri Sep 28 23:39:33 UTC 2012 
 > State-Changed-Why:  
 > This seems fixed to me. 
 
 Exactly when? I can still reproduce.
 
 If you're referring to clang -exp runs see last comment in ports/159117.
 Leaving aside the issue of portmgr@ embracing false positives
 
 # notice 'cc' is used with no clang-specific warnings (then 'cc' is 'gcc')
 # notice '-O2 -pipe -fno-strict-aliasing' are not actually used
 http://pointyhat-west.isc.freebsd.org/errorlogs/amd64-errorlogs/a.9-exp-clang.20120902011351.pointyhat-west/vi-libviet-20010210_1.log.bz2
 
 So, try USE_GCC=4.6+ and see if the log contains gcc46 or set CC yourself
 but place a few traps to prevent build from lying (see quote below).
 
 > >Environment:
 > # slightly different from pointyhat
 > $ export PATH=~/.bin:$PATH
 > $ for cc in CC cc c++ gcc g++ cpp; do ln -s /usr/bin/false ~/.bin/${cc}; done
 
 Note, assignment on command line has higher precedence than in Makefile.
 For example, the following
 
   $ make CC=gcc46
 
 overrides CC=cc in lib/viqr/Makefile but fails to work when CC is set
 via environment, make.conf or bsd.gcc.mk (USE_GCC).
State-Changed-From-To: closed->open 
State-Changed-By: beat 
State-Changed-When: Sat Oct 20 12:13:09 UTC 2012 
State-Changed-Why:  
Re-opened on submitters request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163226 
>Unformatted:
