From jbeich@tormail.net  Sat Dec 10 21:31:23 2011
Return-Path: <jbeich@tormail.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D5522106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Dec 2011 21:31:23 +0000 (UTC)
	(envelope-from jbeich@tormail.net)
Received: from server2.hudsonvalleyhost.com (server2.hudsonvalleyhost.com [66.7.195.77])
	by mx1.freebsd.org (Postfix) with ESMTP id A63078FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Dec 2011 21:31:23 +0000 (UTC)
Received: from jennifer.idxf.com ([85.17.122.36]:54946 helo=internal.tormail.net)
	by server2.hudsonvalleyhost.com with esmtpsa (TLSv1:RC4-SHA:128)
	(Exim 4.69)
	(envelope-from <jbeich@tormail.net>)
	id 1RZUVu-0048Pd-06
	for FreeBSD-gnats-submit@freebsd.org; Sat, 10 Dec 2011 16:31:23 -0500
Received: from jbeich by internal.tormail.net with local (Exim 4.63)
	(envelope-from <jbeich@tormail.net>)
	id 1RZUV4-0000vE-Hl
	for FreeBSD-gnats-submit@freebsd.org; Sat, 10 Dec 2011 21:30:33 +0000
Message-Id: <1RZUV4-0000vE-Hl@internal.tormail.net>
Date: Sun, 11 Dec 2011 02:24:13 +0500
From: Jan Beich <jbeich@tormail.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] mail/alpine: respect CC/CFLAGS

>Number:         163173
>Category:       ports
>Synopsis:       [patch] mail/alpine: respect CC/CFLAGS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 10 21:40:09 UTC 2011
>Closed-Date:    Fri Jan 20 10:04:14 UTC 2012
>Last-Modified:  Fri Jan 20 10:10:09 UTC 2012
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
# slightly different from pointyhat
$ export PATH=~/.bin:$PATH
$ for cc in CC cc c++ gcc g++ cpp; do ln -s /usr/bin/false ~/.bin/${cc}; done
>Description:
CC/CXX are already exported before CONFIGURE_ENV in bsd.port.mk,
so Makefile@1.14 commit was a no-op. The port lacks CC/CFLAGS
override for a non-automake makefile, e.g.

  imap/src/osdep/unix/Makefile:
  GCCOPTLEVEL= -O2
  ...
  GCCCFLAGS= -g $(GCCOPTLEVEL) -pipe -fno-omit-frame-pointer
  GCC4CFLAGS= $(GCCCFLAGS) -Wno-pointer-sign
  ...
  CC=cc
>How-To-Repeat:
http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/e.9-exp.20110723205754/pico-alpine-2.00_1.log
>Fix:
--- cc.diff begins here ---
Index: mail/alpine/Makefile
===================================================================
RCS file: /a/.csup/ports/mail/alpine/Makefile,v
retrieving revision 1.14
diff -u -p -r1.14 Makefile
--- mail/alpine/Makefile	26 Jun 2011 07:12:53 -0000	1.14
+++ mail/alpine/Makefile	10 Dec 2011 20:45:31 -0000
@@ -48,7 +48,7 @@ CONFIGURE_ARGS+=--with-system-pinerc=${P
 .endif
 CONFIGURE_ARGS+=--with-debug-level=2
 
-CONFIGURE_ENV+=	CC=${CC} CXX=${CXX}
+MAKE_ARGS+=	CC="${CC}" CXX="${CXX}" GCCCFLAGS="${CFLAGS}"
 
 USE_OPENSSL=	yes
 
--- cc.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dougb 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Dec 10 21:40:34 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163173 
State-Changed-From-To: open->closed 
State-Changed-By: dougb 
State-Changed-When: Fri Jan 20 10:04:00 UTC 2012 
State-Changed-Why:  

Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=163173 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/163173: commit references a PR
Date: Fri, 20 Jan 2012 10:04:07 +0000 (UTC)

 dougb       2012-01-20 10:03:47 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/alpine          Makefile pkg-descr 
   Log:
   Apply a better fix for CC
   
   While I'm here, remove the license info
   
   PR:             ports/163173
   Submitted by:   Jan Beich <jbeich@tormail.net>
   
   Revision  Changes    Path
   1.16      +1 -3      ports/mail/alpine/Makefile
   1.4       +0 -2      ports/mail/alpine/pkg-descr
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
