From freebsd@grem.de  Sat Nov 19 01:00:12 2011
Return-Path: <freebsd@grem.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 237E5106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Nov 2011 01:00:12 +0000 (UTC)
	(envelope-from freebsd@grem.de)
Received: from mail.bindone.de (mail.bindone.de [80.190.134.51])
	by mx1.freebsd.org (Postfix) with SMTP id 6C6CA8FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Nov 2011 01:00:11 +0000 (UTC)
Received: (qmail 73909 invoked by uid 0); 19 Nov 2011 00:47:43 -0000
Message-Id: <20111119004743.73908.qmail@mail.bindone.de>
Date: 19 Nov 2011 00:47:43 -0000
From: Michael Gmelin <freebsd@grem.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc: garga@FreeBSD.org
Subject: [PATCH] net/rinetd: [SUMMARIZE CHANGES]
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         162672
>Category:       ports
>Synopsis:       [PATCH] net/rinetd: [SUMMARIZE CHANGES]
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    garga
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 19 01:10:06 UTC 2011
>Closed-Date:    Sat Nov 19 14:27:15 UTC 2011
>Last-Modified:  Sat Nov 19 14:27:15 UTC 2011
>Originator:     Michael Gmelin
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
Grem Equity GmbH
>Environment:
System: FreeBSD bsd.grem.de 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat May  7 08:49:13 UTC
>Description:
rinetd fails to close the configuration file (fopen twice, fclose only once) when reading its configuration. Therefore on every configuration reload (through SIGHUP) one file descriptor is lost. In an environment where this is done frequently (e.g. to re-lookup DNS names) the system will run out of file descriptors soon (kern.maxfiles) until rinetd crashes.
(I informed the author through his webpage, but I'm not sure if there'll be a response anytime soon)

Port maintainer (garga@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:

Start rinetd, and use fstat to check the number of open file descriptors:
fstat | grep rinetd | wc -l

Give the process a SIGHUP (killall -HUP rinetd) and run check the number of open file descriptors using fstat again. On every SIGHUP the number of file descriptors used is increased by one.

>Fix:

--- rinetd-0.62_4.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/net/rinetd.orig/Makefile /usr/ports/net/rinetd/Makefile
--- /usr/ports/net/rinetd.orig/Makefile	2011-11-19 01:36:39.000000000 +0100
+++ /usr/ports/net/rinetd/Makefile	2011-11-19 01:35:19.000000000 +0100
@@ -7,7 +7,7 @@
 
 PORTNAME=	rinetd
 PORTVERSION=	0.62
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	net
 MASTER_SITES=	http://www.boutell.com/rinetd/http/ \
 		${MASTER_SITE_GENTOO}
diff -ruN --exclude=CVS /usr/ports/net/rinetd.orig/files/patch-rinetd.c /usr/ports/net/rinetd/files/patch-rinetd.c
--- /usr/ports/net/rinetd.orig/files/patch-rinetd.c	2011-11-19 01:36:39.000000000 +0100
+++ /usr/ports/net/rinetd/files/patch-rinetd.c	2011-11-19 01:35:30.000000000 +0100
@@ -8,3 +8,11 @@
  			initArrays();
  			readConfiguration();
  			RegisterPID();
+@@ -646,6 +646,7 @@
+ 			}
+ 		}
+ 	}
++	fclose(in);
+ 	/* Open the log file */
+ 	if (logFile) {
+ 		fclose(logFile);
--- rinetd-0.62_4.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->garga 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Nov 19 01:10:56 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162672 

From: Michael Gmelin <freebsd@grem.de>
To: FreeBSD-gnats-submit@FreeBSD.org,
 freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/162672: [PATCH] net/rinetd: [SUMMARIZE CHANGES]
Date: Sat, 19 Nov 2011 02:22:20 +0100

 This lacks a proper synopsis, please close/mark as duplicate in favor of =
 PR ports/162673
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=3D162673
 
State-Changed-From-To: open->closed 
State-Changed-By: garga 
State-Changed-When: Sat Nov 19 14:27:13 UTC 2011 
State-Changed-Why:  
Superseded by ports/162673 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162672 
>Unformatted:
