From nobody@FreeBSD.org  Wed Nov 16 00:16:21 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1267C106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 16 Nov 2011 00:16:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 028258FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 16 Nov 2011 00:16:21 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pAG0GKID081941
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 16 Nov 2011 00:16:20 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pAG0GJ3Z081920;
	Wed, 16 Nov 2011 00:16:19 GMT
	(envelope-from nobody)
Message-Id: <201111160016.pAG0GJ3Z081920@red.freebsd.org>
Date: Wed, 16 Nov 2011 00:16:19 GMT
From: Mark Delany <z2n@delta.emu.st>
To: freebsd-gnats-submit@FreeBSD.org
Subject: event.c missing from ports/devel/st/work/st-1.9/Makefile
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         162602
>Category:       ports
>Synopsis:       devel/st [patch] event.c missing from work/st-1.9/Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lippe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 16 00:20:06 UTC 2011
>Closed-Date:    Thu Feb 07 19:29:08 UTC 2013
>Last-Modified:  Thu Feb 07 19:29:08 UTC 2013
>Originator:     Mark Delany
>Release:        8.2
>Organization:
Self
>Environment:
FreeBSD f3.bushwire.net 8.2-STABLE FreeBSD 8.2-STABLE #0: Mon Nov 14 13:21:17 EST 2011     root@f3.bushwire.net:/var/obj/usr/src/sys/f3c  amd64

>Description:
The 1.9 version of state threads introduced a new source module called event.c

It looks like that module name has not been added to the SRCS take in the Makefile

The library still builds as event.c only presents user APIs and is not used by any other part of the st library, however the library is unusable by applications because of the missing entry-points.

>How-To-Repeat:

>Fix:
3# diff -c files/Makefile.main.orig files/Makefile.main
*** files/Makefile.main.orig	Mon Oct 20 01:58:53 2008
--- files/Makefile.main	Wed Nov 16 10:13:55 2011
***************
*** 8,14 ****
  LIB=		st
  NO_PROFILE=	yes
  
! SRCS=		io.c key.c sched.c stk.c sync.c
  CFLAGS+=	-DFREEBSD
  
  .include <bsd.lib.mk>
--- 8,14 ----
  LIB=		st
  NO_PROFILE=	yes
  
! SRCS=		io.c key.c sched.c stk.c sync.c event.c
  CFLAGS+=	-DFREEBSD
  
  .include <bsd.lib.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->lippe 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Nov 16 00:20:16 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162602 
Responsible-Changed-From-To: lippe->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Wed Feb 15 04:46:25 UTC 2012 
Responsible-Changed-Why:  
committer&maintainer timeout (lippe ; 91 days) / last commit: 198 days 
ago 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162602 
Responsible-Changed-From-To: pgollucci->lippe 
Responsible-Changed-By: lippe 
Responsible-Changed-When: Thu Apr 5 20:43:45 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162602 

From: "Mark Delany" <z2n@delta.emu.st>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/162602: event.c missing from
 ports/devel/st/work/st-1.9/Makefile
Date: 8 Dec 2012 04:17:10 +0000

 Hi Folks.
 
 Just following up on this report.
 
 In the original report I included the patch to fix the port about a
 year ago and it's not yet in the ports repo. Is there something I can
 do to help move this along?
 
 
 Mark.
 
 
 On 16Nov11, FreeBSD-gnats-submit@FreeBSD.org allegedly wrote:
 > Thank you very much for your problem report.
 > It has the internal identification `ports/162602'.
 > The individual assigned to look at your
 > report is: freebsd-ports-bugs. 
 > 
 > You can access the state of your problem report at any time
 > via this link:
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=162602
 > 
 > >Category:       ports
 > >Responsible:    freebsd-ports-bugs
 > >Synopsis:       event.c missing from ports/devel/st/work/st-1.9/Makefile
 > >Arrival-Date:   Wed Nov 16 00:20:06 UTC 2011

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162602: commit references a PR
Date: Thu,  7 Feb 2013 19:18:03 +0000 (UTC)

 Author: lippe
 Date: Thu Feb  7 19:17:55 2013
 New Revision: 311880
 URL: http://svnweb.freebsd.org/changeset/ports/311880
 
 Log:
   - Fix Makefile to install event module recently added
   - Make portlint happy
   
   PR:		ports/162602, ports/173447
   Submitted by:	Mark Delany <z2n@delta.emu.st>, Kevin Day <kevin@your.org>
 
 Modified:
   head/devel/st/Makefile   (contents, props changed)
   head/devel/st/files/Makefile.main   (contents, props changed)
 
 Modified: head/devel/st/Makefile
 ==============================================================================
 --- head/devel/st/Makefile	Thu Feb  7 19:07:07 2013	(r311879)
 +++ head/devel/st/Makefile	Thu Feb  7 19:17:55 2013	(r311880)
 @@ -1,12 +1,10 @@
 -# New ports collection makefile for:    st
 -# Date created:         Sun Feb 18 2001
 -# Whom:                 tobez@tobez.org
 -#
 +# Created by: tobez
  # $FreeBSD$
  #
  
  PORTNAME=	st
  PORTVERSION=	1.9
 +PORTREVISION=	1
  CATEGORIES=	devel
  MASTER_SITES=	SF/${PORTNAME}ate-threads/${PORTNAME}ate-threads/${PORTVERSION}
  
 @@ -30,9 +28,11 @@ post-patch:
  
  post-install:
  	@${CP} ${WRKSRC}/public.h ${PREFIX}/include/st.h
 -.if !defined(NOPORTDOCS)
 +.if ${PORT_OPTIONS:MDOCS}
  	@${MKDIR} ${DOCSDIR}
  	@${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/docs/,} ${DOCSDIR}/
 +.endif
 +.if ${PORT_OPTIONS:MEXAMPLES}
  	@${MKDIR} ${EXAMPLESDIR}
  	@${INSTALL_DATA} ${EXAMPLES:S,^,${WRKSRC}/examples/,} ${EXAMPLESDIR}/
  .endif
 
 Modified: head/devel/st/files/Makefile.main
 ==============================================================================
 --- head/devel/st/files/Makefile.main	Thu Feb  7 19:07:07 2013	(r311879)
 +++ head/devel/st/files/Makefile.main	Thu Feb  7 19:17:55 2013	(r311880)
 @@ -8,7 +8,7 @@ SHLIB_MINOR=	1
  LIB=		st
  NO_PROFILE=	yes
  
 -SRCS=		io.c key.c sched.c stk.c sync.c
 +SRCS=		io.c key.c sched.c stk.c sync.c event.c
  CFLAGS+=	-DFREEBSD
  
  .include <bsd.lib.mk>
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: lippe 
State-Changed-When: Thu Feb 7 19:29:07 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162602 
>Unformatted:
