From jbeich@tormail.net  Tue Nov 15 19:36:28 2011
Return-Path: <jbeich@tormail.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 368E4106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Nov 2011 19:36:28 +0000 (UTC)
	(envelope-from jbeich@tormail.net)
Received: from server2.hudsonvalleyhost.com (server2.hudsonvalleyhost.com [66.7.195.77])
	by mx1.freebsd.org (Postfix) with ESMTP id 042E88FC1B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Nov 2011 19:36:28 +0000 (UTC)
Received: from c-71-233-188-98.hsd1.ct.comcast.net ([71.233.188.98]:58876 helo=internal.tormail.net)
	by server2.hudsonvalleyhost.com with esmtpsa (TLSv1:RC4-SHA:128)
	(Exim 4.69)
	(envelope-from <jbeich@tormail.net>)
	id 1RQOnu-002l5O-Pd
	for FreeBSD-gnats-submit@freebsd.org; Tue, 15 Nov 2011 14:36:26 -0500
Received: from jbeich by internal.tormail.net with local (Exim 4.63)
	(envelope-from <jbeich@tormail.net>)
	id 1RQOmb-0003fj-Cu
	for FreeBSD-gnats-submit@freebsd.org; Tue, 15 Nov 2011 19:35:05 +0000
Message-Id: <1RQOmb-0003fj-Cu@internal.tormail.net>
Date: Wed, 16 Nov 2011 01:33:02 +0600
From: Jan Beich <jbeich@tormail.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] audio/py-ogg: respect CC

>Number:         162595
>Category:       ports
>Synopsis:       [patch] audio/py-ogg: respect CC
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 15 19:40:09 UTC 2011
>Closed-Date:    Sun Feb 12 22:39:22 UTC 2012
>Last-Modified:  Sun Feb 12 22:40:11 UTC 2012
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
# slightly different from pointyhat
$ export PATH=~/.bin:$PATH
$ for cc in CC cc c++ gcc g++ cpp; do ln -s /usr/bin/false ~/.bin/${cc}; done
>Description:
Alternatively, one can prepend CC=${CC} or even ${MAKE_ENV} before
${PYTHON_CMD} like it does bsd.port.mk for (HAS|GNU)_CONFIGURE.
>How-To-Repeat:
http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/e.9-exp.20110723205754/py27-ogg-1.3_4.log
>Fix:
--- cc.diff begins here ---
Index: audio/py-ogg/Makefile
===================================================================
RCS file: /a/.csup/ports/audio/py-ogg/Makefile,v
retrieving revision 1.14
diff -u -p -r1.14 Makefile
--- audio/py-ogg/Makefile	6 Jun 2010 20:43:39 -0000	1.14
+++ audio/py-ogg/Makefile	15 Nov 2011 18:25:28 -0000
@@ -21,8 +21,8 @@ LIB_DEPENDS=	ogg.7:${PORTSDIR}/audio/lib
 USE_PYTHON=		yes
 USE_PYDISTUTILS=	yes
 PYDISTUTILS_PKGNAME=	pyogg
-
-do-configure:
-	@cd ${WRKSRC} && ${PYTHON_CMD} config_unix.py --prefix ${LOCALBASE}
+HAS_CONFIGURE=		yes
+CONFIGURE_SCRIPT=	config_unix.py
+CONFIGURE_ARGS=		--prefix ${LOCALBASE}
 
 .include <bsd.port.mk>
--- cc.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->xride 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Nov 15 19:40:35 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162595 

From: Jan Beich <jbeich@tormail.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162595: [patch] audio/py-ogg: respect CC
Date: Tue, 15 Nov 2011 08:57:45 -1100

 --=-=-=
 Content-Type: text/plain
 
 Jan Beich <jbeich@tormail.net> writes:
 
 > +HAS_CONFIGURE=		yes
 > +CONFIGURE_SCRIPT=	config_unix.py
 > +CONFIGURE_ARGS=		--prefix ${LOCALBASE}
 
 Nevermind, turns out a bad idea as it's too easy to forget to respect PYTHON_VER
 by explicitly calling PYTHON_CMD rather than `python'. So, use MAKE_ENV
 approach as it's shorter than the above one + post-patch target to fix
 python shebang.
 
 
 --=-=-=
 Content-Type: text/x-patch
 Content-Disposition: attachment; filename=cc.diff
 
 Index: audio/py-ogg/Makefile
 ===================================================================
 RCS file: /a/.csup/ports/audio/py-ogg/Makefile,v
 retrieving revision 1.14
 diff -u -p -r1.14 Makefile
 --- audio/py-ogg/Makefile	6 Jun 2010 20:43:39 -0000	1.14
 +++ audio/py-ogg/Makefile	15 Nov 2011 19:53:06 -0000
 @@ -23,6 +23,7 @@ USE_PYDISTUTILS=	yes
  PYDISTUTILS_PKGNAME=	pyogg
  
  do-configure:
 -	@cd ${WRKSRC} && ${PYTHON_CMD} config_unix.py --prefix ${LOCALBASE}
 +	@cd ${WRKSRC} && ${MAKE_ENV} ${PYTHON_CMD} config_unix.py \
 +		--prefix ${LOCALBASE}
  
  .include <bsd.port.mk>
 
 --=-=-=--

From: Jan Beich <jbeich@tormail.net>
To: Soeren Straarup <xride@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/162595: [patch] audio/py-ogg: respect CC
Date: Thu, 17 Nov 2011 16:46:40 +1100

 Soeren Straarup <xride@freebsd.org> writes:
 
 > Does that mean that this PR can be closed?
 
 No, I've sent alternative patch. It uses MAKE_ENV, like bsd.python.mk
 does for do-configure. And MAKE_ENV always exports CC via bsd.port.mk.
Responsible-Changed-From-To: xride->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Sat Feb 11 23:46:34 UTC 2012 
Responsible-Changed-Why:  
committer&maintainer timeout (xride ; 86 days) / last commit: 86 days 
ago 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162595 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Sun Feb 12 22:39:20 UTC 2012 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162595 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162595: commit references a PR
Date: Sun, 12 Feb 2012 22:39:30 +0000 (UTC)

 pgollucci    2012-02-12 22:39:17 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/py-ogg         Makefile 
   Log:
   - Respect CC
   
   PR:             ports/162595
   Submitted by:   Jan Beich <jbeich@tormail.net>
   Approved by:    maintainer timeout (xride ; 86 days)
   
   Revision  Changes    Path
   1.15      +1 -1      ports/audio/py-ogg/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
