From nobody@FreeBSD.org  Mon Nov 14 10:55:15 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 293CD106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 14 Nov 2011 10:55:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 0EE678FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 14 Nov 2011 10:55:15 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pAEAtEJ5019750
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 14 Nov 2011 10:55:14 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pAEAtE6q019728;
	Mon, 14 Nov 2011 10:55:14 GMT
	(envelope-from nobody)
Message-Id: <201111141055.pAEAtE6q019728@red.freebsd.org>
Date: Mon, 14 Nov 2011 10:55:14 GMT
From: Ildar Hizbulin <hizel@vyborg.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: regression in ospfd after upgrade net/quagga to 0.99.20_2
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: boris@tagnet.ru

>Number:         162559
>Category:       ports
>Synopsis:       regression in ospfd after upgrade net/quagga to 0.99.20_2
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    sem
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 14 11:00:22 UTC 2011
>Closed-Date:    Thu Nov 17 13:02:42 UTC 2011
>Last-Modified:  Fri Jun 14 14:20:00 UTC 2013
>Originator:     Ildar Hizbulin
>Release:        FreeBSD 7.4-RELEASE-p2
>Organization:
Ariadna-Link, ISP 
>Environment:
FreeBSD ras 7.4-RELEASE-p2 FreeBSD 7.4-RELEASE-p2 #3: Mon May 30 15:25:48 MSD 2011     root@ras:/usr/obj/usr/src/sys/RAS72  i386
>Description:
after upgrade quagga to 0.99.20_2 in ospf.log:

2011/11/14 14:43:19 OSPF: ospf_recv_packet read length mismatch: ip_len is 64, but recvmsg returned 84                                                                                                                                         
2011/11/14 14:43:27 OSPF: ospf_recv_packet read length mismatch: ip_len is 76, but recvmsg returned 96
2011/11/14 14:43:28 OSPF: ospf_recv_packet read length mismatch: ip_len is 76, but recvmsg returned 96                                                                                                                                         
2011/11/14 14:43:28 OSPF: ospf_recv_packet read length mismatch: ip_len is 64, but recvmsg returned 84
2011/11/14 14:43:29 OSPF: ospf_recv_packet read length mismatch: ip_len is 64, but recvmsg returned 84                                                                                                                                         
2011/11/14 14:43:29 OSPF: ospf_recv_packet read length mismatch: ip_len is 64, but recvmsg returned 84
2011/11/14 14:43:37 OSPF: ospf_recv_packet read length mismatch: ip_len is 76, but recvmsg returned 96                                                                                                                                         
2011/11/14 14:43:38 OSPF: ospf_recv_packet read length mismatch: ip_len is 76, but recvmsg returned 96
2011/11/14 14:43:38 OSPF: ospf_recv_packet read length mismatch: ip_len is 64, but recvmsg returned 84                                                                                                                                         
2011/11/14 14:43:39 OSPF: ospf_recv_packet read length mismatch: ip_len is 64, but recvmsg returned 84
2011/11/14 14:43:39 OSPF: ospf_recv_packet read length mismatch: ip_len is 64, but recvmsg returned 84                                                                                                                                         
2011/11/14 14:43:39 OSPF: ospf_recv_packet read length mismatch: ip_len is 100, but recvmsg returned 120
2011/11/14 14:43:39 OSPF: ospf_recv_packet read length mismatch: ip_len is 100, but recvmsg returned 120                   
>How-To-Repeat:
upgrade quagga to 0.99.20_2 with options:

>Fix:
remove net/quagga/files/patch-ospfd__ospf_packet.c solve my problem

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Nov 14 11:00:33 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162559 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: boris@tagnet.ru
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/162559: regression in ospfd after upgrade net/quagga to 0.99.20_2
Date: Mon, 14 Nov 2011 11:00:31 UT

 Maintainer of net/quagga,
 
 Please note that PR ports/162559 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162559
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Boris Kovalenko <boris@tagnet.ru>
To: bug-followup@FreeBSD.org, hizel@vyborg.ru
Cc:  
Subject: Re: ports/162559: regression in ospfd after upgrade net/quagga to
 0.99.20_2
Date: Mon, 14 Nov 2011 17:58:48 +0600

 This is a multi-part message in MIME format.
 --------------070902090200030102020408
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Hello!
 
      Would You please check this patch?
 
 -- 
 Regards,
 Boris
 
 
 
 --------------070902090200030102020408
 Content-Type: text/plain;
  name="quagga.txt"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="quagga.txt"
 
 LS0tIG9zcGZkL29zcGZfcGFja2V0LmMub3JpZwkyMDExLTExLTA5IDE3OjEzOjE4LjAwMDAw
 MDAwMCArMDQwMA0KKysrIG9zcGZkL29zcGZfcGFja2V0LmMJMjAxMS0xMS0wOSAxNzoxNToz
 MS4wMDAwMDAwMDAgKzA0MDANCkBAIC0yMTE2LDcgKzIxMTYsNyBAQA0KICAgDQogICBpcF9s
 ZW4gPSBpcGgtPmlwX2xlbjsNCiAgIA0KLSNpZiAhZGVmaW5lZChHTlVfTElOVVgpICYmIChP
 cGVuQlNEIDwgMjAwMzExKQ0KKyNpZiAhZGVmaW5lZChHTlVfTElOVVgpICYmIChPcGVuQlNE
 IDwgMjAwMzExKSAmJiAoX19GcmVlQlNEX3ZlcnNpb24gPCA5MDAwNDUpDQogICAvKg0KICAg
 ICogS2VybmVsIG5ldHdvcmsgY29kZSB0b3VjaGVzIGluY29taW5nIElQIGhlYWRlciBwYXJh
 bWV0ZXJzLA0KICAgICogYmVmb3JlIHByb3RvY29sIHNwZWNpZmljIHByb2Nlc3NpbmcuDQo=
 --------------070902090200030102020408--

From: Boris Kovalenko <boris@tagnet.ru>
To: bug-followup@FreeBSD.org, hizel@vyborg.ru
Cc:  
Subject: Re: ports/162559: regression in ospfd after upgrade net/quagga to
 0.99.20_2
Date: Mon, 14 Nov 2011 19:27:48 +0600

 This is a multi-part message in MIME format.
 --------------030308080900060003070609
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Yes, it's really my regression. Since FreeBSD 9 has iph->len rolled 
 back, only FreeBSD 10 should be checked.
 
 -- 
 Regards,
 Boris
 
 
 
 --------------030308080900060003070609
 Content-Type: text/plain;
  name="quagga.txt"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="quagga.txt"
 
 PT09PiBHZW5lcmF0aW5nIHBhdGNoDQo9PT0+IFZpZXdpbmcgZGlmZiB3aXRoIG1vcmUNCmRp
 ZmYgLXJ1TiAtLWV4Y2x1ZGU9Q1ZTIC9tbnQvd29yay9wb3J0cy9uZXQvcXVhZ2dhLm9yaWcv
 TWFrZWZpbGUgL21udC93b3JrL3BvcnRzL25ldC9xdWFnZ2EvTWFrZWZpbGUNCi0tLSAvbW50
 L3dvcmsvcG9ydHMvbmV0L3F1YWdnYS5vcmlnL01ha2VmaWxlCTIwMTEtMTEtMTIgMjM6NTE6
 MDcuMDAwMDAwMDAwICswNjAwDQorKysgL21udC93b3JrL3BvcnRzL25ldC9xdWFnZ2EvTWFr
 ZWZpbGUJMjAxMS0xMS0xNCAxOToyNjo0MS4wMDAwMDAwMDAgKzA2MDANCkBAIC03LDcgKzcs
 NyBAQA0KIA0KIFBPUlROQU1FPQlxdWFnZ2ENCiBQT1JUVkVSU0lPTj0JMC45OS4yMA0KLVBP
 UlRSRVZJU0lPTj0JMg0KK1BPUlRSRVZJU0lPTj0JMw0KIENBVEVHT1JJRVM9CW5ldCBpcHY2
 DQogTUFTVEVSX1NJVEVTPQlodHRwOi8vcXVhZ2dhLm5ldC9kb3dubG9hZC8gXA0KIAkJaHR0
 cDovL3d3dy5ydS5xdWFnZ2EubmV0L2Rvd25sb2FkLyBcDQpkaWZmIC1ydU4gLS1leGNsdWRl
 PUNWUyAvbW50L3dvcmsvcG9ydHMvbmV0L3F1YWdnYS5vcmlnL2ZpbGVzL3BhdGNoLW9zcGZk
 X19vc3BmX3BhY2tldC5jIC9tbnQvd29yay9wb3J0cy9uZXQvcXVhZ2dhL2ZpbGVzL3BhdGNo
 LW9zcGZkX19vc3BmX3BhY2tldC5jDQotLS0gL21udC93b3JrL3BvcnRzL25ldC9xdWFnZ2Eu
 b3JpZy9maWxlcy9wYXRjaC1vc3BmZF9fb3NwZl9wYWNrZXQuYwkyMDExLTExLTEyIDIzOjUx
 OjA3LjAwMDAwMDAwMCArMDYwMA0KKysrIC9tbnQvd29yay9wb3J0cy9uZXQvcXVhZ2dhL2Zp
 bGVzL3BhdGNoLW9zcGZkX19vc3BmX3BhY2tldC5jCTIwMTEtMTEtMTQgMTg6NDU6NTkuMDAw
 MDAwMDAwICswNjAwDQpAQCAtNSw3ICs1LDcgQEANCiAgICBpcF9sZW4gPSBpcGgtPmlwX2xl
 bjsNCiAgICANCiAtI2lmICFkZWZpbmVkKEdOVV9MSU5VWCkgJiYgKE9wZW5CU0QgPCAyMDAz
 MTEpDQotKyNpZiAhZGVmaW5lZChHTlVfTElOVVgpICYmIChPcGVuQlNEIDwgMjAwMzExKSAm
 JiAoX19GcmVlQlNEX3ZlcnNpb24gPj0gMTAwMDAwMCkNCisrI2lmICFkZWZpbmVkKEdOVV9M
 SU5VWCkgJiYgKE9wZW5CU0QgPCAyMDAzMTEpICYmIChfX0ZyZWVCU0RfdmVyc2lvbiA8IDEw
 MDAwMDApDQogICAgLyoNCiAgICAgKiBLZXJuZWwgbmV0d29yayBjb2RlIHRvdWNoZXMgaW5j
 b21pbmcgSVAgaGVhZGVyIHBhcmFtZXRlcnMsDQogICAgICogYmVmb3JlIHByb3RvY29sIHNw
 ZWNpZmljIHByb2Nlc3NpbmcuDQo9PT0+IERvbmUNCg==
 --------------030308080900060003070609--

From: "Ildar Hizbulin" <hizel@vyborg.ru>
To: bug-followup@freebsd.org, "Boris Kovalenko" <boris@tagnet.ru>
Cc:  
Subject: Re: ports/162559: regression in ospfd after upgrade net/quagga to
 0.99.20_2
Date: Mon, 14 Nov 2011 17:07:44 +0400

 On Mon, 14 Nov 2011 15:58:48 +0400, Boris Kovalenko <boris@tagnet.ru>  
 wrote:
 
 > Hello!
 >
 >      Would You please check this patch?
 >
 
 Hello!
 
 patch work for me
 
 --- ospfd/ospf_packet.c.orig    2011-09-29 18:59:32.000000000 +0600
 +++ ospfd/ospf_packet.c 2011-11-12 12:02:58.000000000 +0600
 @@ -2116,7 +2116,7 @@
 
     ip_len = iph->ip_len;
 
 -#if !defined(GNU_LINUX) && (OpenBSD < 200311)
 +#if !defined(GNU_LINUX) && (OpenBSD < 200311) && (__FreeBSD_version <=  
 900045)
     /*
      * Kernel network code touches incoming IP header parameters,
      * before protocol specific processing.
 
 
 thank you!
 
 -- 
 e-mail: hizel@vyborg.ru
 jid: hizel@vyborg.ru

From: "Ildar Hizbulin" <hizel@vyborg.ru>
To: bug-followup@freebsd.org, "Boris Kovalenko" <boris@tagnet.ru>
Cc:  
Subject: Re: ports/162559: regression in ospfd after upgrade net/quagga to
 0.99.20_2
Date: Wed, 16 Nov 2011 12:19:46 +0400

 On Mon, 14 Nov 2011 17:27:48 +0400, Boris Kovalenko <boris@tagnet.ru>  
 wrote:
 
 > Yes, it's really my regression. Since FreeBSD 9 has iph->len rolled
 > back, only FreeBSD 10 should be checked.
 >
 
 Please commit this patch!
 I also checked in 8.2-RELESE. In quagga-0.99.20_2 ospfd broken,  
 quagga-0.99.20_3 works ok
 
 -- 
 e-mail: hizel@vyborg.ru
 jid: hizel@vyborg.ru
Responsible-Changed-From-To: freebsd-ports-bugs->sem 
Responsible-Changed-By: sem 
Responsible-Changed-When: Thu Nov 17 12:50:09 UTC 2011 
Responsible-Changed-Why:  
Take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162559 
State-Changed-From-To: feedback->closed 
State-Changed-By: sem 
State-Changed-When: Thu Nov 17 13:02:40 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162559 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162559: commit references a PR
Date: Thu, 17 Nov 2011 13:02:21 +0000 (UTC)

 sem         2011-11-17 13:02:07 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/quagga           Makefile 
     net/quagga/files     patch-ospfd__ospf_packet.c 
   Log:
   - Fix regression in ospfd after upgrade to 0.99.20_2
   
   PR:             ports/162559
   Submitted by:   Ildar Hizbulin <hizel_at_vyborg.ru>
   Fixed by:       maintainer
   Feature safe:   Yes
   
   Revision  Changes    Path
   1.116     +1 -1      ports/net/quagga/Makefile
   1.2       +1 -1      ports/net/quagga/files/patch-ospfd__ospf_packet.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: "Eugene M. Zheganin" <emz@norma.perm.ru>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162559: regression in ospfd after upgrade net/quagga to
 0.99.20_2
Date: Fri, 14 Jun 2013 20:17:58 +0600

 This appeared again on fresh 10.x.
 For some reason this compiler condition isn't blocking FreeBSD 10.x from
 adding this line, so it should be corrected.
 
 I deleted the whole block and got quagga's OSPF working. Until this I
 was getting same error messages as the author of the original pr.
>Unformatted:
 >cat /var/db/ports/quagga/options
 # This file is auto-generated by 'make config'.
 # No user-servicable parts inside!
 # Options for quagga-0.99.15_5
 _OPTIONS_READ=quagga-0.99.15_5
 WITHOUT_ISISD=true
 WITHOUT_PAM=true
 WITH_OSPF_NSSA=true
 WITH_OSPF_OPAQUE_LSA=true
 WITHOUT_RTADV=true
 WITH_SNMP=true
 WITH_TCPSOCKETS=true
 WITH_DLMALLOC=true
 WITHOUT_NO_BGP_ANNOUNCE=true
 
