From jbeich@tormail.net  Fri Nov 11 20:34:21 2011
Return-Path: <jbeich@tormail.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7BB95106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 11 Nov 2011 20:34:21 +0000 (UTC)
	(envelope-from jbeich@tormail.net)
Received: from server2.hudsonvalleyhost.com (server2.hudsonvalleyhost.com [66.7.195.77])
	by mx1.freebsd.org (Postfix) with ESMTP id 343098FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 11 Nov 2011 20:34:20 +0000 (UTC)
Received: from tor4.anonymizer.ccc.de ([80.237.226.74]:37009 helo=internal.tormail.net)
	by server2.hudsonvalleyhost.com with esmtpsa (TLSv1:RC4-SHA:128)
	(Exim 4.69)
	(envelope-from <jbeich@tormail.net>)
	id 1ROxnl-001GvH-Ot
	for FreeBSD-gnats-submit@freebsd.org; Fri, 11 Nov 2011 15:34:20 -0500
Received: from jbeich by internal.tormail.net with local (Exim 4.63)
	(envelope-from <jbeich@tormail.net>)
	id 1ROxmY-0007TT-25
	for FreeBSD-gnats-submit@freebsd.org; Fri, 11 Nov 2011 20:33:05 +0000
Message-Id: <1ROxmY-0007TT-25@internal.tormail.net>
Date: Fri, 11 Nov 2011 21:32:45 +0100
From: Jan Beich <jbeich@tormail.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] mail/qmail: respect CC/STRIP

>Number:         162492
>Category:       ports
>Synopsis:       [patch] mail/qmail: respect CC/STRIP
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    garga
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 11 20:40:07 UTC 2011
>Closed-Date:    Wed Nov 16 21:20:14 UTC 2011
>Last-Modified:  Wed Nov 16 21:20:14 UTC 2011
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
# slightly different from pointyhat
$ export PATH=~/.bin:$PATH
$ for cc in CC cc c++ gcc g++ cpp; do ln -s /usr/bin/false ~/.bin/${cc}; done
>Description:
Makefile.in@1.154 wasn't tested with similar environment ports/159117's
-exp run was done with. The build still uses `cc' during linking and
the next -exp run will likely reveal this.
>How-To-Repeat:
$ make install WITH_DEBUG=
$ file -b /usr/local/bin/* | fgrep strip | uniq
ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked (uses shared libs), for FreeBSD 10.0 (1000001), stripped
$ gdb -q qmail-pop3d
(no debugging symbols found)...(gdb)

$ make CC=clang
[...]
./load auto-str substdio.a error.a str.a
*** Error code 1
>Fix:
--- cc.diff begins here ---
Index: mail/qmail/Makefile
===================================================================
RCS file: /a/.csup/ports/mail/qmail/Makefile,v
retrieving revision 1.155
diff -u -p -r1.155 Makefile
--- mail/qmail/Makefile	9 Sep 2011 17:28:30 -0000	1.155
+++ mail/qmail/Makefile	11 Nov 2011 20:02:11 -0000
@@ -756,6 +756,7 @@ post-patch:
 
 do-configure:
 	@${ECHO_CMD} "${CC} ${CFLAGS}" > ${WRKSRC}/conf-cc
+	@${ECHO_CMD} "${CC} ${LDFLAGS}" > ${WRKSRC}/conf-ld
 	@${ECHO_CMD} ${PREFIX} > ${WRKSRC}/conf-qmail
 .if defined(WITH_BIG_CONCURRENCY_PATCH) \
 	&& !defined(BARRIER_BIG_CONCURRENCY_PATCH) \
--- cc.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->garga 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Nov 11 20:40:55 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162492 

From: Jan Beich <jbeich@tormail.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162492: [patch] mail/qmail: respect CC/STRIP
Date: Fri, 11 Nov 2011 21:43:51 +0100

 --=-=-=
 Content-Type: text/plain
 Content-Disposition: inline
 
 Jan Beich <jbeich@tormail.net> writes:
 
 >  do-configure:
 >  	@${ECHO_CMD} "${CC} ${CFLAGS}" > ${WRKSRC}/conf-cc
 > +	@${ECHO_CMD} "${CC} ${LDFLAGS}" > ${WRKSRC}/conf-ld
 
 Oops, I've sent the old version without strip fix. Trying again
 
 
 --=-=-=
 Content-Type: text/x-patch
 Content-Disposition: attachment; filename=cc.diff
 
 Index: mail/qmail/Makefile
 ===================================================================
 RCS file: /a/.csup/ports/mail/qmail/Makefile,v
 retrieving revision 1.155
 diff -u -p -r1.155 Makefile
 --- mail/qmail/Makefile	9 Sep 2011 17:28:30 -0000	1.155
 +++ mail/qmail/Makefile	11 Nov 2011 20:06:55 -0000
 @@ -756,6 +756,7 @@ post-patch:
  
  do-configure:
  	@${ECHO_CMD} "${CC} ${CFLAGS}" > ${WRKSRC}/conf-cc
 +	@${ECHO_CMD} "${CC} ${STRIP} ${LDFLAGS}" > ${WRKSRC}/conf-ld
  	@${ECHO_CMD} ${PREFIX} > ${WRKSRC}/conf-qmail
  .if defined(WITH_BIG_CONCURRENCY_PATCH) \
  	&& !defined(BARRIER_BIG_CONCURRENCY_PATCH) \
 
 --=-=-=--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162492: commit references a PR
Date: Wed, 16 Nov 2011 21:18:43 +0000 (UTC)

 garga       2011-11-16 21:18:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/qmail           Makefile 
   Log:
   Respect CC and STRIP
   
   PR:             ports/162492
   Submitted by:   Jan Beich <jbeich@tormail.net>
   Feature safe:   yes
   
   Revision  Changes    Path
   1.156     +1 -0      ports/mail/qmail/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: garga 
State-Changed-When: Wed Nov 16 21:20:09 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162492 
>Unformatted:
