From g.olgeni@colby.it  Wed Nov  9 23:22:00 2011
Return-Path: <g.olgeni@colby.it>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EFD5A106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  9 Nov 2011 23:21:59 +0000 (UTC)
	(envelope-from g.olgeni@colby.it)
Received: from mail.colby.tv (93-62-141-58.ip22.fastwebnet.it [93.62.141.58])
	by mx1.freebsd.org (Postfix) with ESMTP id 73F868FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  9 Nov 2011 23:21:59 +0000 (UTC)
Received: from server.colby.local (localhost [127.0.0.1])
	by server.colby.local (8.14.4/8.14.4) with ESMTP id pA9NLu9I085588;
	Thu, 10 Nov 2011 00:21:56 +0100 (CET)
	(envelope-from g.olgeni@colby.it)
Received: from exchange.colby.local ([192.168.1.11] helo=exchange.colby.local)
	with IPv4:25 by server.colby.local; 10 Nov 2011 00:21:56 +0100
Received: from backoffice.colby.local ([192.168.1.56]) by exchange.colby.local over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);
	 Thu, 10 Nov 2011 00:21:56 +0100
Received: from backoffice.colby.local (localhost [127.0.0.1])
	by backoffice.colby.local (8.14.5/8.14.4) with ESMTP id pA9NLu8K038334;
	Thu, 10 Nov 2011 00:21:56 +0100 (CET)
	(envelope-from olgeni@backoffice.colby.local)
Received: (from olgeni@localhost)
	by backoffice.colby.local (8.14.5/8.14.4/Submit) id pA9NLuE0038333;
	Thu, 10 Nov 2011 00:21:56 +0100 (CET)
	(envelope-from olgeni)
Message-Id: <201111092321.pA9NLuE0038333@backoffice.colby.local>
Date: Thu, 10 Nov 2011 00:21:56 +0100 (CET)
From: Jimmy Olgeni <olgeni@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: mainland@apeiron.net
Subject: [PATCH] math/py27-matplotlib: add missing RUN_DEPENDS and fix warnings
X-Send-Pr-Version: 3.113
X-GNATS-Notify: mainland@apeiron.net

>Number:         162418
>Category:       ports
>Synopsis:       [PATCH] math/py27-matplotlib: add missing RUN_DEPENDS and fix warnings
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    olgeni
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 09 23:30:09 UTC 2011
>Closed-Date:    Thu Nov 10 13:22:11 UTC 2011
>Last-Modified:  Thu Nov 10 13:30:10 UTC 2011
>Originator:     Jimmy Olgeni
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD backoffice 8.2-STABLE FreeBSD 8.2-STABLE #1: Wed Oct 12 21:16:42 CEST 2011
>Description:
Matplotlib requires dateutil to run, so I added both dateutil and
pytz to RUN_DEPENDS (from BUILD_DEPENDS). I found out the hard way
by using precompiled packages...

A few portlint whitespace warnings are also fixed.

Port maintainer (mainland@apeiron.net) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- py27-matplotlib-1.0.1_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/math/py-matplotlib/Makefile,v
retrieving revision 1.39
diff -u -u -r1.39 Makefile
--- Makefile	29 Jun 2011 01:59:58 -0000	1.39
+++ Makefile	9 Nov 2011 23:18:00 -0000
@@ -8,7 +8,7 @@
 
 PORTNAME=	matplotlib
 PORTVERSION=	1.0.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	math python
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTNAME}-${PORTVERSION}/
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
@@ -21,13 +21,15 @@
 		${PYTHON_PKGNAMEPREFIX}pytz>0:${PORTSDIR}/devel/py-pytz
 LIB_DEPENDS=	freetype.9:${PORTSDIR}/print/freetype2 \
 		png.6:${PORTSDIR}/graphics/png
-RUN_DEPENDS=	${PYNUMPY}
+RUN_DEPENDS=	${PYNUMPY} \
+		${PYTHON_PKGNAMEPREFIX}dateutil>=1.4:${PORTSDIR}/devel/py-dateutil \
+		${PYTHON_PKGNAMEPREFIX}pytz>0:${PORTSDIR}/devel/py-pytz
 
 USE_PYTHON=	2.4+
-USE_PYDISTUTILS=	yes
+USE_PYDISTUTILS=yes
 CFLAGS+=	-I${LOCALBASE}/include
 
-OPTIONS=        GTKBACKEND	"GTK backend support"		ON \
+OPTIONS=	GTKBACKEND	"GTK backend support"		ON \
 		GTKAGGBACKEND	"GTKAgg backend support"	ON \
 		TKAGGBACKEND	"TKAgg backend support"		ON \
 		WXAGGBACKEND	"WXAgg backend support"		OFF
@@ -47,23 +49,23 @@
 .endif
 
 .if defined(WITH_GTKBACKEND) && !defined(WITHOUT_GTKBACKEND)
-GTK_BACKEND=True
+GTK_BACKEND=	True
 
-PLIST_SUB+= GTKBACKEND=""
+PLIST_SUB+=	GTKBACKEND=""
 .else
-GTK_BACKEND=False
+GTK_BACKEND=	False
 
-PLIST_SUB+= GTKBACKEND="@comment "
+PLIST_SUB+=	GTKBACKEND="@comment "
 .endif
 
 .if defined(WITH_GTKAGGBACKEND)
-GTKAGG_BACKEND=True
+GTKAGG_BACKEND=	True
 
-PLIST_SUB+= GTKAGGBACKEND=""
+PLIST_SUB+=	GTKAGGBACKEND=""
 .else
-GTKAGG_BACKEND=False
+GTKAGG_BACKEND=	False
 
-PLIST_SUB+= GTKAGGBACKEND="@comment "
+PLIST_SUB+=	GTKAGGBACKEND="@comment "
 .endif
 
 .if defined(WITH_TKAGGBACKEND)
@@ -73,27 +75,27 @@
 USE_TCL_RUN=	yes
 USE_TK_RUN=	yes
 
-TKAGG_BACKEND=True
+TKAGG_BACKEND=	True
 
-PLIST_SUB+= TKAGGBACKEND=""
+PLIST_SUB+=	TKAGGBACKEND=""
 .else
-TKAGG_BACKEND=False
+TKAGG_BACKEND=	False
 
-PLIST_SUB+= TKAGGBACKEND="@comment "
+PLIST_SUB+=	TKAGGBACKEND="@comment "
 .endif
 
 .if defined(WITH_WXAGGBACKEND)
-USE_WX=	2.6
+USE_WX=		2.6
 WX_COMPS=	python
 CONFIGURE_ENV+=	WX_CONFIG="${WX_CONFIG}"
 
-WXAGG_BACKEND=True
+WXAGG_BACKEND=	True
 
-PLIST_SUB+= WXAGGBACKEND=""
+PLIST_SUB+=	WXAGGBACKEND=""
 .else
-WXAGG_BACKEND=False
+WXAGG_BACKEND=	False
 
-PLIST_SUB+= WXAGGBACKEND="@comment "
+PLIST_SUB+=	WXAGGBACKEND="@comment "
 .endif
 
 .include <bsd.port.pre.mk>
--- py27-matplotlib-1.0.1_2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->olgeni 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Nov 9 23:30:22 UTC 2011 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162418 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Nov 9 23:30:32 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162418 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: mainland@apeiron.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/162418: [PATCH] math/py27-matplotlib: add missing RUN_DEPENDS and fix warnings
Date: Wed, 9 Nov 2011 23:30:28 UT

 Maintainer of math/py-matplotlib,
 
 Please note that PR ports/162418 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162418
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Geoffrey Mainland <mainland@apeiron.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162418: [PATCH] math/py27-matplotlib: add missing
 RUN_DEPENDS and fix warnings
Date: Wed, 9 Nov 2011 23:32:30 +0000

 I approve the patch.
 
 Thanks,
 Geoff
 
State-Changed-From-To: feedback->closed 
State-Changed-By: olgeni 
State-Changed-When: Thu Nov 10 13:21:54 UTC 2011 
State-Changed-Why:  
Committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162418 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162418: commit references a PR
Date: Thu, 10 Nov 2011 13:20:35 +0000 (UTC)

 olgeni      2011-11-10 13:20:21 UTC
 
   FreeBSD ports repository
 
   Modified files:
     math/py-matplotlib   Makefile 
   Log:
   Copy dateutil and pytz from BUILD_DEPENDS to RUN_DEPENDS, since
   they are required.
   
   Fix a few portlint nits while I'm here.
   
   PR:             ports/162418
   Submitted by:   olgeni
   Approved by:    maintainer
   Feature safe:   yes
   
   Revision  Changes    Path
   1.40      +23 -21    ports/math/py-matplotlib/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
