From nobody@FreeBSD.org  Wed Nov  9 19:12:19 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 361AC106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  9 Nov 2011 19:12:19 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 267A88FC1B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  9 Nov 2011 19:12:19 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pA9JCIYs023505
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 9 Nov 2011 19:12:18 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pA9JCIh0023502;
	Wed, 9 Nov 2011 19:12:18 GMT
	(envelope-from nobody)
Message-Id: <201111091912.pA9JCIh0023502@red.freebsd.org>
Date: Wed, 9 Nov 2011 19:12:18 GMT
From: "4720@hushmail.com" <4720@hushmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] graphics/libGL not fully make jobs safe
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         162412
>Category:       ports
>Synopsis:       [patch] graphics/libGL not fully make jobs safe
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-x11
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 09 19:20:08 UTC 2011
>Closed-Date:    Mon Sep 03 19:05:57 UTC 2012
>Last-Modified:  Mon Sep  3 19:10:14 UTC 2012
>Originator:     4720@hushmail.com
>Release:        
>Organization:
>Environment:
>Description:
graphics/libGL sometimes fail to build when using 20 make jobs. occasionally
matypes.h is not finished generating before things that need matypes.h to
compile are sent to the compiler.

x86/common_x86_asm.S:42:21: error: matypes.h: No such file or directory
gmake[2]: *** [x86/common_x86_asm.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
x86/x86_xform2.S:33:21: error: matypes.h: No such file or directory
x86/x86_cliptest.S:33:21: error: matypes.h: No such file or directory
gmake[2]: *** [x86/x86_cliptest.o] Error 1
gmake[2]: *** [x86/x86_xform2.o] Error 1
x86/sse_normal.S:35:21: error: matypes.h: No such file or directory
gmake[2]: *** [x86/sse_normal.o] Error 1
./gen_matypes > matypes.h
gmake[3]: Leaving directory `/work/a/ports/graphics/libGL/work/Mesa-7.6.1/src/mesa/x86'
>How-To-Repeat:

>Fix:
attached patch marks port as make jobs unsafe.

Patch attached with submission follows:

Index: graphics/libGL/bsd.mesalib.mk
===================================================================
RCS file: /home/ncvs/ports/graphics/libGL/bsd.mesalib.mk,v
retrieving revision 1.18
diff -u -r1.18 bsd.mesalib.mk
--- graphics/libGL/bsd.mesalib.mk	23 Sep 2011 22:23:18 -0000	1.18
+++ graphics/libGL/bsd.mesalib.mk	9 Nov 2011 19:03:51 -0000
@@ -41,7 +41,7 @@
 USE_GMAKE=		yes
 USE_LDCONFIG=	yes
 GNU_CONFIGURE=	yes
-MAKE_JOBS_SAFE=	yes
+MAKE_JOBS_UNSAFE=	yes
 
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-x11 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Nov 9 19:20:18 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162412 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Thu Nov 10 06:45:29 UTC 2011 
State-Changed-Why:  
fixed in the xorg repo 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162412 

From: Chris Rees <utisoft@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/162412
Date: Mon, 3 Sep 2012 19:33:32 +0100

 Hm, that doesn't help people with the current ports tree, does it?
 
 The submitter tells me it's still an issue.
 
 Chris
State-Changed-From-To: closed->patched 
State-Changed-By: eadler 
State-Changed-When: Mon Sep 3 18:57:12 UTC 2012 
State-Changed-Why:  
correct state 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162412 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Mon Sep 3 19:05:54 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162412 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162412: commit references a PR
Date: Mon,  3 Sep 2012 19:04:41 +0000 (UTC)

 Author: eadler
 Date: Mon Sep  3 19:04:31 2012
 New Revision: 303610
 URL: http://svn.freebsd.org/changeset/ports/303610
 
 Log:
   After a report of an error, mark graphics/libGL as not MAKE_JOBS_SAFE
   
   PR:		ports/162412
   Submitted by:	4720@hushmail.com
   Reviewed by:	zeising
 
 Modified:
   head/graphics/libGL/bsd.mesalib.mk
 
 Modified: head/graphics/libGL/bsd.mesalib.mk
 ==============================================================================
 --- head/graphics/libGL/bsd.mesalib.mk	Mon Sep  3 19:01:55 2012	(r303609)
 +++ head/graphics/libGL/bsd.mesalib.mk	Mon Sep  3 19:04:31 2012	(r303610)
 @@ -44,7 +44,7 @@ USE_BZIP2=	yes
  USE_GMAKE=	yes
  USE_LDCONFIG=	yes
  GNU_CONFIGURE=	yes
 -MAKE_JOBS_SAFE=	yes
 +MAKE_JOBS_UNSAFE=	yes
  
  CPPFLAGS+=	-I${LOCALBASE}/include
  LDFLAGS+=	-L${LOCALBASE}/lib
 _______________________________________________
 svn-ports-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
 
>Unformatted:
