From dm@home8.dinoex.sub.de  Tue Nov  8 19:54:55 2011
Return-Path: <dm@home8.dinoex.sub.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 44ADB1065670
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  8 Nov 2011 19:54:55 +0000 (UTC)
	(envelope-from dm@home8.dinoex.sub.de)
Received: from uucp.dinoex.sub.de (uucp.dinoex.sub.de [194.45.71.2])
	by mx1.freebsd.org (Postfix) with ESMTP id A3ABC8FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  8 Nov 2011 19:54:54 +0000 (UTC)
Received: from home8.dinoex.sub.de (home8.dinoex.sub.de [194.45.71.48])
	by uucp.dinoex.sub.de (8.14.4/8.14.4) with ESMTP id pA8JsZb8063921
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 8 Nov 2011 20:54:52 +0100 (CET)
	(envelope-from dm@home8.dinoex.sub.de)
Received: (from dm@localhost)
	by home8.dinoex.sub.de (8.14.5/8.14.5/Submit) id pA8JsXYV041289;
	Tue, 8 Nov 2011 20:54:33 +0100 (CET)
	(envelope-from dm)
Message-Id: <201111081954.pA8JsXYV041289@home8.dinoex.sub.de>
Date: Tue, 8 Nov 2011 20:54:33 +0100 (CET)
From: dirk.meyer@dinoex.sub.org
Reply-To: dirk.meyer@dinoex.sub.org
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] sysutils/smartmontools Remove cd* from the list of
X-Send-Pr-Version: 3.113
X-GNATS-Notify: samm@os2.kiev.ua

>Number:         162383
>Category:       ports
>Synopsis:       [PATCH] sysutils/smartmontools Remove cd* from the list of
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 08 20:00:24 UTC 2011
>Closed-Date:    Fri Dec 02 07:06:19 CET 2011
>Last-Modified:  Fri Dec 02 07:06:19 CET 2011
>Originator:     Dirk Meyer
>Release:        FreeBSD 8.2-RELEASE
>Organization:
privat
>Environment:

>Description:

Initially cd* was just skipped in the checking loop.
This was broken in the last change, which resulted in this script exiting with status badconfig.
Now cd* is only removed when auto is used.
If cd* is specified manually, the script still exits with badconfig.

>How-To-Repeat:

>Fix:

apply this patch:
Submitted by:	 Christoph Mallon

---
 sysutils/smartmontools/Makefile       |    2 +-
 sysutils/smartmontools/files/smart.in |    3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/sysutils/smartmontools/Makefile b/sysutils/smartmontools/Makefile
index c929393..f709508 100644
--- a/sysutils/smartmontools/Makefile
+++ b/sysutils/smartmontools/Makefile
@@ -7,7 +7,7 @@
 
 PORTNAME=	smartmontools
 PORTVERSION=	5.42
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	sysutils
 MASTER_SITES=	SF
 
diff --git a/sysutils/smartmontools/files/smart.in b/sysutils/smartmontools/files/smart.in
index 8cee79e..39acb88 100644
--- a/sysutils/smartmontools/files/smart.in
+++ b/sysutils/smartmontools/files/smart.in
@@ -16,7 +16,7 @@ smartctl=%%PREFIX%%/sbin/smartctl
 case "${daily_status_smart_devices}" in
 	# XXX AUTO mode selects only regular ad/da disks 
 	[Aa][Uu][Tt][Oo])
-		daily_status_smart_devices=`sysctl -n kern.disks`
+		daily_status_smart_devices="$(sysctl -n kern.disks | sed -E 's/[[:<:]]cd[0-9]+//g')"
 		;;
 	*)	;;
 esac
@@ -42,7 +42,6 @@ case "${daily_status_smart_enable}" in
 			device="${device#/dev/}"
 			devflags=""
 			case ${device} in
-			cd*) ;;
 			tw[ae]*) devflags="-d3ware,${device##tw[ae][0-9]*,}"
 				device="/dev/${device%,[0-9]*}"
 				;;
-- 

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Nov 8 20:00:39 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162383 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: samm@os2.kiev.ua
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/162383: [PATCH] sysutils/smartmontools Remove cd* from the list of
Date: Tue, 8 Nov 2011 20:00:36 UT

 Maintainer of sysutils/smartmontools,
 
 Please note that PR ports/162383 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162383
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: dinoex 
Responsible-Changed-When: Thu Dec 1 21:53:47 CET 2011 
Responsible-Changed-Why:  
I will take care of followups. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162383 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162383: commit references a PR
Date: Thu,  1 Dec 2011 20:53:40 +0000 (UTC)

 dinoex      2011-12-01 20:53:31 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/smartmontools Makefile 
     sysutils/smartmontools/files smart.in 
   Log:
   - fix handling of cd*
   PR:             162383
   Submitted by:   Christoph Mallon
   Approved by:    (maintainer timeout)
   Feature safe:   yes
   
   Revision  Changes    Path
   1.56      +1 -1      ports/sysutils/smartmontools/Makefile
   1.12      +2 -3      ports/sysutils/smartmontools/files/smart.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: dinoex 
State-Changed-When: Fri Dec 2 07:06:04 CET 2011 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162383 
>Unformatted:
  automatically detected disks
