From osho@nozomi.pcc-software.org  Thu Nov  3 11:35:03 2011
Return-Path: <osho@nozomi.pcc-software.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BD6171065675;
	Thu,  3 Nov 2011 11:35:03 +0000 (UTC)
	(envelope-from osho@nozomi.pcc-software.org)
Received: from nozomi.pcc-software.org (d203141144045.ddo.jp [203.141.144.45])
	by mx1.freebsd.org (Postfix) with ESMTP id 5FD508FC13;
	Thu,  3 Nov 2011 11:35:03 +0000 (UTC)
Received: from nozomi.pcc-software.org (localhost [127.0.0.1])
	by nozomi.pcc-software.org (8.14.4/8.14.4) with ESMTP id pA39kGMp038463;
	Thu, 3 Nov 2011 18:46:16 +0900 (JST)
	(envelope-from osho@nozomi.pcc-software.org)
Received: (from osho@localhost)
	by nozomi.pcc-software.org (8.14.4/8.14.4/Submit) id pA39kFgM038462;
	Thu, 3 Nov 2011 18:46:15 +0900 (JST)
	(envelope-from osho)
Message-Id: <201111030946.pA39kFgM038462@nozomi.pcc-software.org>
Date: Thu, 3 Nov 2011 18:46:15 +0900 (JST)
From: Yoshisato YANAGISAWA <osho@pcc-software.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: tota@freebsd.org
Subject: [PATCH] www/tdiary: runtime dependency iconv is missing.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         162269
>Category:       ports
>Synopsis:       [PATCH] www/tdiary: runtime dependency iconv is missing.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tota
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 03 11:40:07 UTC 2011
>Closed-Date:    Sat Nov 05 01:00:57 UTC 2011
>Last-Modified:  Sat Nov  5 01:10:10 UTC 2011
>Originator:     Yoshisato YANAGISAWA
>Release:        FreeBSD 8.2-RELEASE-p4 amd64
>Organization:
>Environment:
System: FreeBSD nozomi.pcc-software.org 8.2-RELEASE-p4 FreeBSD 8.2-RELEASE-p4 #15: Sat Oct  8 09:04:40 JST
>Description:
When I updated tDiary using the port, I saw "no such file to load -- iconv"
instead of the top page I usually see.  Since FreeBSD's ruby port is not
including iconv, which is included in the regular ruby tarball, we should
install it by ourselves from converters/ruby-iconv.
After I installed the ruby-iconv package, the problem above is fixed.

I request the port Makefile to show the runtime dependency to the iconv package
as I have written in the following patch.

Port maintainer (tota@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
Uninstall converters/ruby-iconv if installed, and you will see the error
message when you connect to the tdiary web page.

>Fix:
Show runtime dependency:

--- tdiary-3.1.1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/www/tdiary/Makefile /home/osho/tdiary/Makefile
--- /usr/ports/www/tdiary/Makefile	2011-10-30 01:09:56.000000000 +0900
+++ /home/osho/tdiary/Makefile	2011-11-03 18:19:07.458511000 +0900
@@ -20,7 +20,8 @@
 
 RUN_DEPENDS=	hikidoc:${PORTSDIR}/textproc/ruby-hikidoc \
 		rubygem-imagesize>=0.1.1:${PORTSDIR}/graphics/rubygem-imagesize \
-		rubygem-json_pure>=1.6.1:${PORTSDIR}/devel/rubygem-json_pure
+		rubygem-json_pure>=1.6.1:${PORTSDIR}/devel/rubygem-json_pure \
+		${RUBY_ARCHLIBDIR}/iconv.so:${PORTSDIR}/converters/ruby-iconv
 
 NO_BUILD=	yes
 USE_RUBY=	yes
--- tdiary-3.1.1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->tota 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Nov 3 11:40:19 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162269 

From: TAKATSU Tomonari <tota@FreeBSD.org>
To: bug-followup@FreeBSD.org, osho@pcc-software.org
Cc:  
Subject: Re: ports/162269: [PATCH] www/tdiary: runtime dependency iconv is missing.
Date: Thu, 3 Nov 2011 22:50:36 +0900

 --0015175caebe81d3b504b0d4df00
 Content-Type: text/plain; charset=ISO-8859-1
 
 If RUBY_VER < 1.9, ruby-iconv must be installed by the dependency defined in
 devel/rubygem-json_pure/Makefile as follows.
 
 .include <bsd.port.pre.mk>
 
 .if ${RUBY_VER} < 1.9
 USE_RUBY_FEATURES=      iconv
 .endif
 
 .include <bsd.port.post.mk>
 
 See also http://www.freebsd.org/cgi/query-pr.cgi?pr=158984.
 
 So, I have not noticed that tDiary has required ruby-iconv dependency.
 Since 2011-09-06, tDiary has checked whether String class has encode
 method or not
 as following codes.
 
 https://github.com/tdiary/tdiary-core/blob/631e2286be498de321797974840b1ccd8f0866e1/tdiary/config.rb#L99
 https://github.com/tdiary/tdiary-core/blob/8ac01232e17ae1e1927a9e32e61080e64b9d38a1/tdiary/lang/ja.rb#L43
 
 We should define ruby-iconv dependency in www/tdiary/Makefile
 just as you say.
 I have prepared a patch, attached in this e-mail, to fix above the issue.
 Please confirm that the error does not occur with my patch if you can.
 
 If RUBY_VER == 1.9 in your environment, please send to me a log
 when you execute 'make install' in www/tdiary directory.
 
 Thanks in advance,
 
 -- 
 TAKATSU Tomonari
 
 --0015175caebe81d3b504b0d4df00
 Content-Type: application/octet-stream; name="tdiary.patch"
 Content-Disposition: attachment; filename="tdiary.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_gujssdbv0
 
 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL25jdnMvcG9ydHMvd3d3
 L3RkaWFyeS9NYWtlZmlsZSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMQpkaWZmIC11IC1yMS4z
 MSBNYWtlZmlsZQotLS0gTWFrZWZpbGUJMjkgT2N0IDIwMTEgMTY6MDk6NTYgLTAwMDAJMS4zMQor
 KysgTWFrZWZpbGUJMyBOb3YgMjAxMSAxMzoyMDo1MyAtMDAwMApAQCAtNyw2ICs3LDcgQEAKIAog
 UE9SVE5BTUU9CXRkaWFyeQogUE9SVFZFUlNJT049CTMuMS4xCitQT1JUUkVWSVNJT049CTEKIENB
 VEVHT1JJRVM/PQl3d3cgcnVieQogTUFTVEVSX1NJVEVTPQlTRi8ke1BPUlROQU1FfS8ke1BPUlRO
 QU1FfS8gXAogCQlodHRwOi8vd3d3LnRkaWFyeS5vcmcvZG93bmxvYWQvCkBAIC0yNCw2ICsyNSw3
 IEBACiAKIE5PX0JVSUxEPQl5ZXMKIFVTRV9SVUJZPQl5ZXMKK1VTRV9SVUJZX0ZFQVRVUkVTPQlp
 Y29udgogUlVCWV9SRVFVSVJFPQlSdWJ5ID49IDE4NQogCiBSVUJZX1NIRUJBTkdfRklMRVM9CWlu
 ZGV4LmZjZ2kgXApAQCAtNzAsNiArNzIsNyBAQAogLmlmICFkZWZpbmVkKFJVQllfUFJPVklERUQp
 CiBJR05PUkU9CXJlcXVpcmVzIFJ1YnkgMS44LjUgb3IgbGF0ZXIKIC5lbmRpZgorVVNFX1JVQllf
 RkVBVFVSRT0JaWNvbnYKIC5pZiAhZGVmaW5lZChXSVRIT1VUX1RESUFSWV9OT1JBKQogUlVOX0RF
 UEVORFMrPQkke1JVQllfU0lURUFSQ0hMSUJESVJ9L3dlYi9lc2NhcGVfZXh0LnNvOiR7UE9SVFNE
 SVJ9L3d3dy9ydWJ5LW5vcmEKIC5lbmRpZgo=
 --0015175caebe81d3b504b0d4df00--

From: TAKATSU Tomonari <tota@FreeBSD.org>
To: bug-followup@freebsd.org, osho@pcc-software.org
Cc:  
Subject: Re: ports/162269: [PATCH] www/tdiary: runtime dependency iconv is missing.
Date: Thu, 3 Nov 2011 23:29:01 +0900

 --0015174c1622ecadec04b0d56831
 Content-Type: text/plain; charset=ISO-8859-1
 
 Please use tdiary2.patch instead of tdiary.patch in previous mail.
 
 Thanks,
 
 -- 
 TAKATSU Tomonari
 
 --0015174c1622ecadec04b0d56831
 Content-Type: application/octet-stream; name="tdiary2.patch"
 Content-Disposition: attachment; filename="tdiary2.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_gujuor211
 
 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL25jdnMvcG9ydHMvd3d3
 L3RkaWFyeS9NYWtlZmlsZSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMQpkaWZmIC11IC1yMS4z
 MSBNYWtlZmlsZQotLS0gTWFrZWZpbGUJMjkgT2N0IDIwMTEgMTY6MDk6NTYgLTAwMDAJMS4zMQor
 KysgTWFrZWZpbGUJMyBOb3YgMjAxMSAxNDoyNzoyNSAtMDAwMApAQCAtNyw2ICs3LDcgQEAKIAog
 UE9SVE5BTUU9CXRkaWFyeQogUE9SVFZFUlNJT049CTMuMS4xCitQT1JUUkVWSVNJT049CTEKIENB
 VEVHT1JJRVM/PQl3d3cgcnVieQogTUFTVEVSX1NJVEVTPQlTRi8ke1BPUlROQU1FfS8ke1BPUlRO
 QU1FfS8gXAogCQlodHRwOi8vd3d3LnRkaWFyeS5vcmcvZG93bmxvYWQvCkBAIC03MCw2ICs3MSw3
 IEBACiAuaWYgIWRlZmluZWQoUlVCWV9QUk9WSURFRCkKIElHTk9SRT0JcmVxdWlyZXMgUnVieSAx
 LjguNSBvciBsYXRlcgogLmVuZGlmCitVU0VfUlVCWV9GRUFUVVJFUz0JaWNvbnYKIC5pZiAhZGVm
 aW5lZChXSVRIT1VUX1RESUFSWV9OT1JBKQogUlVOX0RFUEVORFMrPQkke1JVQllfU0lURUFSQ0hM
 SUJESVJ9L3dlYi9lc2NhcGVfZXh0LnNvOiR7UE9SVFNESVJ9L3d3dy9ydWJ5LW5vcmEKIC5lbmRp
 Zgo=
 --0015174c1622ecadec04b0d56831--
State-Changed-From-To: open->feedback 
State-Changed-By: tota 
State-Changed-When: Thu Nov 3 14:47:20 UTC 2011 
State-Changed-Why:  
Awaiting confirmation 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162269 

From: Yoshisato YANAGISAWA <osho@pcc-software.org>
To: TAKATSU Tomonari <tota@FreeBSD.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/162269: [PATCH] www/tdiary: runtime dependency iconv is
 missing.
Date: Fri, 04 Nov 2011 00:42:23 +0900

 I tried your latest patch (tdiary2.patch) but it does not install 
 ruby-iconv.  Like this:
 ===>  License GPLv2 accepted by the user
 ===>  Extracting for ja-tdiary-3.1.1_1
 ===>  License GPLv2 accepted by the user
 => SHA256 Checksum OK for tdiary-full-3.1.1.tar.gz.
 ===>   ja-tdiary-3.1.1_1 depends on file: /usr/local/bin/ruby18 - found
 ===>  Patching for ja-tdiary-3.1.1_1
 ===>   ja-tdiary-3.1.1_1 depends on file: /usr/local/bin/ruby18 - found
 ===>  Fixing the #! line of index.fcgi
 ===>  Fixing the #! line of index.rb
 ===>  Fixing the #! line of update.fcgi
 ===>  Fixing the #! line of update.rb
 ===>  Fixing the #! line of misc/convert2.rb
 ===>  Fixing the #! line of misc/migrate.rb
 ===>  Fixing the #! line of misc/plugin/amazon/amazonimg.rb
 ===>  Fixing the #! line of misc/plugin/squeeze.rb
 ===>  Fixing the #! line of misc/plugin/xmlrpc/xmlrpc.rb
 ===>  Fixing the #! line of misc/standalone_cgi/bin/server
 /usr/local/bin/ruby18 -i -pe "sub %r|((\s*)require 'json')|, 
 %Q|\\\2require 'rubygems'\n\\\1|" 
 /usr/ports/japanese/tdiary/work/tdiary-3.1.1/tdiary.rb
 ===>   ja-tdiary-3.1.1_1 depends on file: /usr/local/bin/ruby18 - found
 ===>  Configuring for ja-tdiary-3.1.1_1
 ===>  Installing for ja-tdiary-3.1.1_1
 ===>   ja-tdiary-3.1.1_1 depends on executable: hikidoc - found
 ===>   ja-tdiary-3.1.1_1 depends on package: rubygem-imagesize>=0.1.1 - 
 found
 ===>   ja-tdiary-3.1.1_1 depends on package: rubygem-json_pure>=1.6.1 - 
 found
 ===>   ja-tdiary-3.1.1_1 depends on file: /usr/local/bin/ruby18 - found
 ===>   ja-tdiary-3.1.1_1 depends on file: 
 /usr/local/lib/ruby/site_ruby/1.8/amd64-freebsd8/web/escape_ext.so - found
 ===>   Generating temporary packing list
 ===>  Checking if japanese/tdiary already installed
 
 =============================================================================
 There is a script to install tDiary in a user directory.
 This script should be run manually.
 
    # /usr/local/bin/ja-tdiary-inst.rb --user=User
     or
    % /usr/local/bin/ja-tdiary-inst.rb
 
   * Option: --suexec Use suExec for CGI execution
             --help   Display Help information
 
 ---
 There are documents in the following directories.
    See ...
    /usr/local/share/doc/ja-tdiary
 =============================================================================
 
 ===>   Registering installation for ja-tdiary-3.1.1_1
 
 
 As far as I noticed, USE_RUBY_FEATURES=iconv should be defined before 
 the line of .include <bsd.port.pre.mk>.  If I put there it is executed 
 like this:
 ===>  License GPLv2 accepted by the user
 ===>  Extracting for ja-tdiary-3.1.1_1
 ===>  License GPLv2 accepted by the user
 => SHA256 Checksum OK for tdiary-full-3.1.1.tar.gz.
 ===>   ja-tdiary-3.1.1_1 depends on file: /usr/local/bin/ruby18 - found
 ===>  Patching for ja-tdiary-3.1.1_1
 ===>   ja-tdiary-3.1.1_1 depends on file: /usr/local/bin/ruby18 - found
 ===>  Fixing the #! line of index.fcgi
 ===>  Fixing the #! line of index.rb
 ===>  Fixing the #! line of update.fcgi
 ===>  Fixing the #! line of update.rb
 ===>  Fixing the #! line of misc/convert2.rb
 ===>  Fixing the #! line of misc/migrate.rb
 ===>  Fixing the #! line of misc/plugin/amazon/amazonimg.rb
 ===>  Fixing the #! line of misc/plugin/squeeze.rb
 ===>  Fixing the #! line of misc/plugin/xmlrpc/xmlrpc.rb
 ===>  Fixing the #! line of misc/standalone_cgi/bin/server
 /usr/local/bin/ruby18 -i -pe "sub %r|((\s*)require 'json')|, 
 %Q|\\\2require 'rubygems'\n\\\1|" 
 /usr/ports/japanese/tdiary/work/tdiary-3.1.1/tdiary.rb
 ===>   ja-tdiary-3.1.1_1 depends on file: /usr/local/bin/ruby18 - found
 ===>   ja-tdiary-3.1.1_1 depends on file: 
 /usr/local/lib/ruby/1.8/amd64-freebsd8/iconv.so - not found
 ===>    Verifying install for 
 /usr/local/lib/ruby/1.8/amd64-freebsd8/iconv.so in 
 /usr/ports/converters/ruby-iconv
 ===>  License check disabled, port has not defined LICENSE
 ===>  Extracting for ruby18-iconv-1.8.7.352,1
 ===>   ruby18-iconv-1.8.7.352,1 depends on file: /usr/local/bin/ruby18 - 
 found
 /bin/mkdir -p /usr/ports/converters/ruby-iconv/work
 /bin/ln -sf /usr/ports/lang/ruby18/work/iconv 
 /usr/ports/converters/ruby-iconv/work/
 ===>  Patching for ruby18-iconv-1.8.7.352,1
 ===>   ruby18-iconv-1.8.7.352,1 depends on file: /usr/local/bin/ruby18 - 
 found
 ===>   ruby18-iconv-1.8.7.352,1 depends on file: /nonexistent - not found
 ===>    Verifying patch for /nonexistent in /usr/ports/lang/ruby18
 ===>  License check disabled, port has not defined LICENSE
 ===>  Found saved configuration for ruby-1.8.7.160_4,1
 ===>  Extracting for ruby-1.8.7.352_2,1
 => SHA256 Checksum OK for ruby/ruby-1.8.7-p352.tar.bz2.
 /bin/mv /usr/ports/lang/ruby18/work/ruby-1.8.7-p352/ext/dl/h2rb 
 /usr/ports/lang/ruby18/work/ruby-1.8.7-p352/bin/
 ===>  Patching for ruby-1.8.7.352_2,1
 ===>  Applying FreeBSD patches for ruby-1.8.7.352_2,1
 /bin/rm -rf /usr/ports/lang/ruby18/work/ruby-1.8.7-p352/ext/Win32API
 /bin/rm -rf /usr/ports/lang/ruby18/work/ruby-1.8.7-p352/ext/win32ole
 /bin/mv /usr/ports/lang/ruby18/work/ruby-1.8.7-p352/ext/gdbm 
 /usr/ports/lang/ruby18/work/
 /bin/mv /usr/ports/lang/ruby18/work/ruby-1.8.7-p352/ext/iconv 
 /usr/ports/lang/ruby18/work/
 /bin/mv /usr/ports/lang/ruby18/work/ruby-1.8.7-p352/ext/tk 
 /usr/ports/lang/ruby18/work/
 ===>   Returning to build of ruby18-iconv-1.8.7.352,1
 ===>   ruby18-iconv-1.8.7.352,1 depends on file: /usr/local/bin/ruby18 - 
 found
 ===>   ruby18-iconv-1.8.7.352,1 depends on shared library: iconv.3 - found
 ===>  Configuring for ruby18-iconv-1.8.7.352,1
 ===>  Running extconf.rb to configure
 checking for iconv() in iconv.h... no
 checking for iconv() in -liconv... yes
 checking for const of iconv() 2nd argument... yes
 creating Makefile
 ===>  Building for ruby18-iconv-1.8.7.352,1
 cc -I. -I. -I/usr/local/lib/ruby/1.8/amd64-freebsd8 -I. 
 -DICONV_INPTR_CONST -I/usr/local/include -I/usr/include   -I/usr/include 
 -fPIC -I/usr/include -O2 -pipe -fno-strict-aliasing  -fPIC  -c iconv.c
 cc -shared -o iconv.so iconv.o -L. -L/usr/local/lib -Wl,-R/usr/local/lib 
 -L/usr/local/lib -Wl,-R/usr/local/lib -L. -L/usr/lib 
 -rpath=/usr/lib:/usr/local/lib -pthread -rdynamic -Wl,-soname,iconv.so 
   -Wl,-R -Wl,/usr/local/lib -L/usr/local/lib -lruby18 -liconv  -lcrypt 
 -lm -L/usr/lib  -rpath=/usr/lib:/usr/local/lib -pthread
 ===>  Installing for ruby18-iconv-1.8.7.352,1
 ===>   ruby18-iconv-1.8.7.352,1 depends on file: /usr/local/bin/ruby18 - 
 found
 ===>   Generating temporary packing list
 ===>  Checking if converters/ruby-iconv already installed
 /usr/bin/install -c -o root -g wheel -m 0755 iconv.so 
 /usr/local/lib/ruby/1.8/amd64-freebsd8
 ===>   Registering installation for ruby18-iconv-1.8.7.352,1
 ===>   Returning to build of ja-tdiary-3.1.1_1
 ===>  Configuring for ja-tdiary-3.1.1_1
 ===>  Installing for ja-tdiary-3.1.1_1
 ===>   ja-tdiary-3.1.1_1 depends on executable: hikidoc - found
 ===>   ja-tdiary-3.1.1_1 depends on package: rubygem-imagesize>=0.1.1 - 
 found
 ===>   ja-tdiary-3.1.1_1 depends on package: rubygem-json_pure>=1.6.1 - 
 found
 ===>   ja-tdiary-3.1.1_1 depends on file: /usr/local/bin/ruby18 - found
 ===>   ja-tdiary-3.1.1_1 depends on file: 
 /usr/local/lib/ruby/1.8/amd64-freebsd8/iconv.so - found
 ===>   ja-tdiary-3.1.1_1 depends on file: 
 /usr/local/lib/ruby/site_ruby/1.8/amd64-freebsd8/web/escape_ext.so - found
 ===>   Generating temporary packing list
 ===>  Checking if japanese/tdiary already installed
 
 =============================================================================
 There is a script to install tDiary in a user directory.
 This script should be run manually.
 
    # /usr/local/bin/ja-tdiary-inst.rb --user=User
     or
    % /usr/local/bin/ja-tdiary-inst.rb
 
   * Option: --suexec Use suExec for CGI execution
             --help   Display Help information
 
 ---
 There are documents in the following directories.
    See ...
    /usr/local/share/doc/ja-tdiary
 =============================================================================
 
 ===>   Registering installation for ja-tdiary-3.1.1_1
 
 
 It checks iconv.so.
 
 Can I ask you why you cannot put USE_RUBY_FEATURES=iconv just after 
 USE_RUBY as you did in the first patch?
 
 diff -ruN tdiary.bak/Makefile tdiary/Makefile
 --- tdiary.bak/Makefile 2011-10-30 01:09:56.000000000 +0900
 +++ tdiary/Makefile     2011-11-04 00:28:09.181554512 +0900
 @@ -7,6 +7,7 @@
 
   PORTNAME=      tdiary
   PORTVERSION=   3.1.1
 +PORTREVISION=    1
   CATEGORIES?=   www ruby
   MASTER_SITES=  SF/${PORTNAME}/${PORTNAME}/ \
                  http://www.tdiary.org/download/
 @@ -24,6 +25,7 @@
 
   NO_BUILD=      yes
   USE_RUBY=      yes
 +USE_RUBY_FEATURES=        iconv
   RUBY_REQUIRE=  Ruby >= 185
 
   RUBY_SHEBANG_FILES=    index.fcgi \
 
 

From: TAKATSU Tomonari <tota@freebsd.org>
To: Yoshisato YANAGISAWA <osho@pcc-software.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/162269: [PATCH] www/tdiary: runtime dependency iconv is missing.
Date: Sat, 5 Nov 2011 03:48:14 +0900

 --001517401ac4c92c1c04b0ed25bb
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 On Fri, Nov 4, 2011 at 12:42 AM, Yoshisato YANAGISAWA
 <osho@pcc-software.org> wrote:
 > I tried your latest patch (tdiary2.patch) but it does not install
 > ruby-iconv. =A0Like this:
 (snip)
 > Can I ask you why you cannot put USE_RUBY_FEATURES=3Diconv just after USE=
 _RUBY
 > as you did in the first patch?
 (snip)
 
 Because tDiary does not need to require iconv in Ruby 1.9 environment.
 
 Can you try tdiary3.patch?
 
 
 --=20
 TAKATSU Tomonari
 
 --001517401ac4c92c1c04b0ed25bb
 Content-Type: application/octet-stream; name="tdiary3.patch"
 Content-Disposition: attachment; filename="tdiary3.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_guljb0t60
 
 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL25jdnMvcG9ydHMvd3d3
 L3RkaWFyeS9NYWtlZmlsZSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMQpkaWZmIC11IC1yMS4z
 MSBNYWtlZmlsZQotLS0gTWFrZWZpbGUJMjkgT2N0IDIwMTEgMTY6MDk6NTYgLTAwMDAJMS4zMQor
 KysgTWFrZWZpbGUJMyBOb3YgMjAxMSAyMTo0OTo0NCAtMDAwMApAQCAtNyw2ICs3LDcgQEAKIAog
 UE9SVE5BTUU9CXRkaWFyeQogUE9SVFZFUlNJT049CTMuMS4xCitQT1JUUkVWSVNJT049CTEKIENB
 VEVHT1JJRVM/PQl3d3cgcnVieQogTUFTVEVSX1NJVEVTPQlTRi8ke1BPUlROQU1FfS8ke1BPUlRO
 QU1FfS8gXAogCQlodHRwOi8vd3d3LnRkaWFyeS5vcmcvZG93bmxvYWQvCkBAIC03MCw2ICs3MSw4
 IEBACiAuaWYgIWRlZmluZWQoUlVCWV9QUk9WSURFRCkKIElHTk9SRT0JcmVxdWlyZXMgUnVieSAx
 LjguNSBvciBsYXRlcgogLmVuZGlmCitCVUlMRF9ERVBFTkRTKz0JJHtERVBFTkRfUlVCWV9JQ09O
 Vn0KK1JVTl9ERVBFTkRTKz0JJHtERVBFTkRfUlVCWV9JQ09OVn0KIC5pZiAhZGVmaW5lZChXSVRI
 T1VUX1RESUFSWV9OT1JBKQogUlVOX0RFUEVORFMrPQkke1JVQllfU0lURUFSQ0hMSUJESVJ9L3dl
 Yi9lc2NhcGVfZXh0LnNvOiR7UE9SVFNESVJ9L3d3dy9ydWJ5LW5vcmEKIC5lbmRpZgo=
 --001517401ac4c92c1c04b0ed25bb--
State-Changed-From-To: feedback->closed 
State-Changed-By: tota 
State-Changed-When: Sat Nov 5 01:00:11 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162269 

From: Yoshisato YANAGISAWA <osho@pcc-software.org>
To: TAKATSU Tomonari <tota@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: ports/162269: [PATCH] www/tdiary: runtime dependency iconv is
 missing.
Date: Sat, 05 Nov 2011 09:51:49 +0900

 This is a multi-part message in MIME format.
 --------------080709010807070305080805
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Your tdiary3.patch worked.  However, it do not need build dependency 
 like tdiary4.txt.
 
 --------------080709010807070305080805
 Content-Type: text/plain;
  name="tdiary4.txt"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="tdiary4.txt"
 
 ZGlmZiAtcnVOIHRkaWFyeS5iYWsvTWFrZWZpbGUgdGRpYXJ5L01ha2VmaWxlDQotLS0gdGRp
 YXJ5LmJhay9NYWtlZmlsZSAyMDExLTEwLTMwIDAxOjA5OjU2LjAwMDAwMDAwMCArMDkwMA0K
 KysrIHRkaWFyeS9NYWtlZmlsZSAgICAgMjAxMS0xMS0wNSAwOTozODozOC40MTA0NzEyNjMg
 KzA5MDANCkBAIC03LDYgKzcsNyBAQA0KDQogUE9SVE5BTUU9ICAgICAgdGRpYXJ5DQogUE9S
 VFZFUlNJT049ICAgMy4xLjENCitQT1JUUkVWSVNJT049ICAgIDENCiBDQVRFR09SSUVTPz0g
 ICB3d3cgcnVieQ0KIE1BU1RFUl9TSVRFUz0gIFNGLyR7UE9SVE5BTUV9LyR7UE9SVE5BTUV9
 LyBcDQogICAgICAgICAgICAgICAgaHR0cDovL3d3dy50ZGlhcnkub3JnL2Rvd25sb2FkLw0K
 QEAgLTcwLDYgKzcxLDcgQEANCiAuaWYgIWRlZmluZWQoUlVCWV9QUk9WSURFRCkNCiBJR05P
 UkU9ICAgICAgICByZXF1aXJlcyBSdWJ5IDEuOC41IG9yIGxhdGVyDQogLmVuZGlmDQorUlVO
 X0RFUEVORFMrPSAgICAgJHtERVBFTkRfUlVCWV9JQ09OVn0NCiAuaWYgIWRlZmluZWQoV0lU
 SE9VVF9URElBUllfTk9SQSkNCiBSVU5fREVQRU5EUys9ICAke1JVQllfU0lURUFSQ0hMSUJE
 SVJ9L3dlYi9lc2NhcGVfZXh0LnNvOiR7UE9SVFNESVJ9L3d3dy9ydWJ5LW5vcmENCiAuZW5k
 aWY=
 --------------080709010807070305080805--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162269: commit references a PR
Date: Sat,  5 Nov 2011 00:58:40 +0000 (UTC)

 tota        2011-11-05 00:58:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/tdiary           Makefile 
   Log:
   - Add missing runtime dependency on ruby-iconv
   
   PR:             ports/162269
   Submitted by:   Yoshisato YANAGISAWA <osho_AT_pcc-software_DOT_org>
   
   Revision  Changes    Path
   1.32      +2 -0      ports/www/tdiary/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
