From conrads@serene.no-ip.org  Thu Nov  3 03:06:31 2011
Return-Path: <conrads@serene.no-ip.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EC727106566B
	for <freebsd-gnats-submit@freebsd.org>; Thu,  3 Nov 2011 03:06:30 +0000 (UTC)
	(envelope-from conrads@serene.no-ip.org)
Received: from eastrmfepo103.cox.net (eastrmfepo103.cox.net [68.230.241.215])
	by mx1.freebsd.org (Postfix) with ESMTP id 8F0108FC14
	for <freebsd-gnats-submit@freebsd.org>; Thu,  3 Nov 2011 03:06:30 +0000 (UTC)
Received: from eastrmimpo210.cox.net ([68.230.241.225])
          by eastrmfepo103.cox.net
          (InterMail vM.8.01.04.00 201-2260-137-20101110) with ESMTP
          id <20111103030624.KUM3804.eastrmfepo103.cox.net@eastrmimpo210.cox.net>;
          Wed, 2 Nov 2011 23:06:24 -0400
Received: from serene.no-ip.org ([98.164.86.236])
	by eastrmimpo210.cox.net with bizsmtp
	id sT6E1h00955wwzE02T6K2k; Wed, 02 Nov 2011 23:06:24 -0400
Received: from serene.no-ip.org (localhost [127.0.0.1])
	by serene.no-ip.org (8.14.5/8.14.5) with ESMTP id pA3369hp070635;
	Wed, 2 Nov 2011 22:06:09 -0500 (CDT)
	(envelope-from conrads@serene.no-ip.org)
Received: (from conrads@localhost)
	by serene.no-ip.org (8.14.5/8.14.5/Submit) id pA335x9t070634;
	Wed, 2 Nov 2011 22:05:59 -0500 (CDT)
	(envelope-from conrads)
Message-Id: <201111030305.pA335x9t070634@serene.no-ip.org>
Date: Wed, 2 Nov 2011 22:05:59 -0500 (CDT)
From: "Conrad J. Sabatier" <conrads@cox.net>
Reply-To: "Conrad J. Sabatier" <conrads@cox.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Eitan Adler <lists@eitanadler.com>
Subject: x11-toolkits/swt-devel: workaround for build failure caused by webkit
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         162263
>Category:       ports
>Synopsis:       x11-toolkits/swt-devel: workaround for build failure caused by webkit
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 03 03:10:09 UTC 2011
>Closed-Date:    Thu Nov 03 19:20:48 UTC 2011
>Last-Modified:  Thu Nov  3 19:30:11 UTC 2011
>Originator:     Conrad J. Sabatier
>Release:        FreeBSD 9.0-RC1 amd64
>Organization:
>Environment:
System: FreeBSD serene.no-ip.org 9.0-RC1 FreeBSD 9.0-RC1 #4: Mon Oct 31 19:06:02 CDT 2011 conrads@serene.no-ip.org:/usr/obj/usr/src/sys/CUSTOM amd64


>Description:
	x11-toolkits/swt-devel currently fails to build if webkit-gtk2 is installed.
	The work/build.sh script automatically detects the existence of webkit and enables
	it in the build, causing the build to eventually fail at line 62 of work/build.xml.

>How-To-Repeat:
	Install www/webkit-gtk2, then try building x11-toolkits/swt-devel.

>Fix:
	The following patch is a very simple temporary workaround, unconditionally disabling 
	webkit in the build (until a better solution may be found).

--- swt-devel.diff begins here ---
Index: ports/x11-toolkits/swt-devel/files/patch-build.sh
===================================================================
RCS file: /home/ncvs/ports/x11-toolkits/swt-devel/files/patch-build.sh,v
retrieving revision 1.9
diff -r1.9 patch-build.sh
1,2c1,2
< --- build.sh.orig	2011-02-10 17:29:10.000000000 +0000
< +++ build.sh	2011-10-01 22:32:40.000000000 +0000
---
> --- build.sh.orig	2011-11-02 21:46:45.000000000 -0500
> +++ build.sh	2011-11-02 21:46:57.000000000 -0500
44c44
< @@ -146,30 +152,17 @@
---
> @@ -146,40 +152,28 @@
48,49c48
< +fi
<  
---
> -
72a72,76
>  fi
>  
> -if [ x`pkg-config --exists webkit-1.0 && echo YES` = "xYES" ]; then
> -	echo "WebKit found, compiling webkit embedded browser support."
> -	MAKE_WEBKIT=make_webkit
79c83,85
< +else
---
>  else
> -	echo "WebKit not found:"
> -	echo "    *** WebKit embedding support will not be compiled."
84c90,101
<  if [ x`pkg-config --exists webkit-1.0 && echo YES` = "xYES" ]; then
---
> +#if [ x`pkg-config --exists webkit-1.0 && echo YES` = "xYES" ]; then
> +#	echo "WebKit found, compiling webkit embedded browser support."
> +#	MAKE_WEBKIT=make_webkit
> +#else
> +#	echo "WebKit not found:"
> +	echo "    *** WebKit embedding support will not be compiled, causes build to fail."
> +	echo "    *** (temporary workaround until a better solution can be found)"
> +#fi
> +
>  # Find AWT if available
>  if [ -z "${AWT_LIB_PATH}" ]; then
>  	if [ -f ${JAVA_HOME}/jre/lib/${AWT_ARCH}/libjawt.* ]; then
--- swt-devel.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Thu Nov 3 18:34:50 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162263 
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Thu Nov 3 19:20:47 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162263 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162263: commit references a PR
Date: Thu,  3 Nov 2011 19:20:20 +0000 (UTC)

 eadler      2011-11-03 19:20:11 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11-toolkits/swt-devel/files patch-build.sh 
   Log:
   Fix build of swt-devel when webkit is installed
   
   PR:             ports/162263
   Submitted by:   "Conrad J. Sabatier" <conrads@cox.net> (patch)
   Submitted by:   "Kevin Oberman" <kob6558@gmail.com> (bug report)
   Submitted by:   "Leslie Jensen" <leslie@eskk.nu> (bug report)
   Approved by:    bapt,sahil (mentors, implicit)
   
   Revision  Changes    Path
   1.10      +24 -7     ports/x11-toolkits/swt-devel/files/patch-build.sh
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
