From amdmi3@amdmi3.ru  Wed Nov  2 22:30:50 2011
Return-Path: <amdmi3@amdmi3.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8D6EA1065670
	for <freebsd-gnats-submit@freebsd.org>; Wed,  2 Nov 2011 22:30:50 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15])
	by mx1.freebsd.org (Postfix) with ESMTP id 442DB8FC08
	for <freebsd-gnats-submit@freebsd.org>; Wed,  2 Nov 2011 22:30:49 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256)
	(Exim 4.76)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1RLjKa-0001qz-6f
	for FreeBSD-gnats-submit@freebsd.org; Thu, 03 Nov 2011 02:30:48 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id D98B3B853
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Nov 2011 02:30:47 +0400 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
	id BC0A9B846; Thu,  3 Nov 2011 02:30:47 +0400 (MSK)
Message-Id: <20111102223047.BC0A9B846@hades.panopticon>
Date: Thu,  3 Nov 2011 02:30:47 +0400 (MSK)
From: Dmitry Marakasov <amdmi3@FreeBSD.org>
Reply-To: Dmitry Marakasov <amdmi3@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [bsd.gnome.mk] don't add useless dependency for INSTALLS_ICONS
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         162260
>Category:       ports
>Synopsis:       [bsd.gnome.mk] don't add useless dependency for INSTALLS_ICONS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 02 22:40:08 UTC 2011
>Closed-Date:    Sun Mar 25 02:06:56 UTC 2012
>Last-Modified:  Sun Mar 25 02:06:56 UTC 2012
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 8.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Tue Mar 8 09:48:52 MSK 2011 root@hades.panopticon:/async/obj/usr/src/sys/HADES i386


>Description:
There is INSTALLS_ICONS knob which runs gtk-update-icon-cache when its present to update gtk icon cache. Though there are "|| /usr/bin/true" guards which make gtk-update-icon-cache commands to always succeed, there explicit dependency on gtk-update-icon-cache is still added when INSTALLS_ICONS is present, though it's completely unneeded. The patch removes it.
>How-To-Repeat:
>Fix:

--- bsd.gnome.mk.patch begins here ---
Index: bsd.gnome.mk
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/Mk/bsd.gnome.mk,v
retrieving revision 1.173
diff -u -r1.173 bsd.gnome.mk
--- bsd.gnome.mk	12 Aug 2011 08:03:18 -0000	1.173
+++ bsd.gnome.mk	2 Nov 2011 22:26:05 -0000
@@ -557,10 +557,6 @@
 . endif
 .endif
 
-.if defined(INSTALLS_ICONS)
-USE_GNOME+=	gtk-update-icon-cache
-.endif
-
 # End component definition section
 
 # This section defines tests for optional software.  These work off four
--- bsd.gnome.mk.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Nov 2 22:40:18 UTC 2011 
Responsible-Changed-Why:  
bsd.gnome.mk is gnome territory (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162260 
State-Changed-From-To: open->closed 
State-Changed-By: mezz 
State-Changed-When: Sun Mar 25 02:04:50 UTC 2012 
State-Changed-Why:  
It is not useless dependency. It is very much need to update the cache to 
allow the menu or other application to be able to update (refresh) by 
theirselves to have new icons, theme or whatever. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162260 
>Unformatted:
