From nobody@FreeBSD.org  Wed Nov  2 10:53:50 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 47E44106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Nov 2011 10:53:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 37F428FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Nov 2011 10:53:50 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pA2AroTt079387
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 2 Nov 2011 10:53:50 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pA2ArnVB079355;
	Wed, 2 Nov 2011 10:53:49 GMT
	(envelope-from nobody)
Message-Id: <201111021053.pA2ArnVB079355@red.freebsd.org>
Date: Wed, 2 Nov 2011 10:53:49 GMT
From: "4720@hushmail.com" <4720@hushmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] devel/avr-binutils conflicts with devel/binutils
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         162248
>Category:       ports
>Synopsis:       [patch] devel/avr-binutils conflicts with devel/binutils
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    joerg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 02 11:00:21 UTC 2011
>Closed-Date:    Fri Dec 16 23:21:25 MET 2011
>Last-Modified:  Fri Dec 16 23:21:25 MET 2011
>Originator:     4720@hushmail.com
>Release:        
>Organization:
>Environment:
>Description:
devel/binutils and devel/avr-binutils install info files to the same place,
overwriting each others files in the process.

pkg_info -W /usr/local/info/as.info 
pkg_info: both avr-binutils-2.20_1 and binutils-2.21.1 claim to have installed /usr/local/info/as.info
>How-To-Repeat:

>Fix:
attached patch installs devel/avr-binutils info files into a separate directory
to resolve files conflict.

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/avr-binutils/Makefile,v
retrieving revision 1.52
diff -u -r1.52 Makefile
--- Makefile	23 Sep 2011 22:21:50 -0000	1.52
+++ Makefile	2 Nov 2011 05:35:47 -0000
@@ -49,5 +49,10 @@
 		avr-windmc.1 \
 		avr-windres.1
 INFO=		as binutils gprof ld
+INFO_PATH=	${PKGNAMEPREFIX:S/-$//}/info
+
+add-plist-post:
+	@${ECHO_CMD} "@unexec rmdir %D/${INFO_PATH} 2> /dev/null || true" >> ${TMPPLIST}
+	@${ECHO_CMD} "@unexec rmdir %D/${PKGNAMEPREFIX:S/-$//} 2> /dev/null || true" >> ${TMPPLIST}
 
 .include <bsd.port.mk>
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/devel/avr-binutils/pkg-plist,v
retrieving revision 1.17
diff -u -r1.17 pkg-plist
--- pkg-plist	4 Mar 2010 13:38:29 -0000	1.17
+++ pkg-plist	2 Nov 2011 05:35:48 -0000
@@ -157,4 +157,3 @@
 @dirrm avr/lib/ldscripts
 @dirrm avr/lib
 @dirrm avr/bin
-@dirrm avr


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->joerg 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Nov 2 11:00:32 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162248 
Responsible-Changed-From-To: joerg->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Mon Nov 28 20:48:17 UTC 2011 
Responsible-Changed-Why:  
Timeout. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162248 
State-Changed-From-To: open->feedback 
State-Changed-By: joerg 
State-Changed-When: Wed Dec 14 16:25:03 MET 2011 
State-Changed-Why:  
Questions to the suggested patch: 

How useful is it to install the info files into a directory that won't 
be searched by any of the info tools?  Wouldn't it be better to 
perhaps not install them at all? 

Why has the removal of the avr subdirectory been dropped from the 
pkg-plist file (or conditionalized into the Makefile)?  If someone 
wants to be remove the entire AVR toolchain properly, the binutils are 
the last component to remove, and as such, they are responsible to 
cleanup the ${prefix}/avr subdirectory they once created. 


Responsible-Changed-From-To: crees->joerg 
Responsible-Changed-By: joerg 
Responsible-Changed-When: Wed Dec 14 16:25:03 MET 2011 
Responsible-Changed-Why:  
Questions to the suggested patch: 

How useful is it to install the info files into a directory that won't 
be searched by any of the info tools?  Wouldn't it be better to 
perhaps not install them at all? 

Why has the removal of the avr subdirectory been dropped from the 
pkg-plist file (or conditionalized into the Makefile)?  If someone 
wants to be remove the entire AVR toolchain properly, the binutils are 
the last component to remove, and as such, they are responsible to 
cleanup the ${prefix}/avr subdirectory they once created. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162248 
State-Changed-From-To: feedback->closed 
State-Changed-By: joerg 
State-Changed-When: Fri Dec 16 23:20:43 MET 2011 
State-Changed-Why:  
Suggested patch applied. 

Thanks again, and thanks for the quick response! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162248 
>Unformatted:
