From g.olgeni@colby.it  Mon Oct 31 13:47:22 2011
Return-Path: <g.olgeni@colby.it>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BF099106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 31 Oct 2011 13:47:22 +0000 (UTC)
	(envelope-from g.olgeni@colby.it)
Received: from mail.colby.tv (93-62-141-58.ip22.fastwebnet.it [93.62.141.58])
	by mx1.freebsd.org (Postfix) with ESMTP id D8AAC8FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 31 Oct 2011 13:47:20 +0000 (UTC)
Received: from server.colby.local (localhost [127.0.0.1])
	by server.colby.local (8.14.4/8.14.4) with ESMTP id p9VDlJls054831;
	Mon, 31 Oct 2011 14:47:19 +0100 (CET)
	(envelope-from g.olgeni@colby.it)
Received: from exchange.colby.local ([192.168.1.11] helo=exchange.colby.local)
	with IPv4:25 by server.colby.local; 31 Oct 2011 14:47:19 +0100
Received: from backoffice.colby.local ([192.168.1.56]) by exchange.colby.local over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);
	 Mon, 31 Oct 2011 14:47:18 +0100
Received: from backoffice.colby.local (localhost [127.0.0.1])
	by backoffice.colby.local (8.14.5/8.14.4) with ESMTP id p9VDlIbR063863;
	Mon, 31 Oct 2011 14:47:18 +0100 (CET)
	(envelope-from olgeni@backoffice.colby.local)
Received: (from olgeni@localhost)
	by backoffice.colby.local (8.14.5/8.14.4/Submit) id p9VDlI1Y063862;
	Mon, 31 Oct 2011 14:47:18 +0100 (CET)
	(envelope-from olgeni)
Message-Id: <201110311347.p9VDlI1Y063862@backoffice.colby.local>
Date: Mon, 31 Oct 2011 14:47:18 +0100 (CET)
From: Jimmy Olgeni <olgeni@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: martymac@freebsd.org
Subject: [PATCH] multimedia/libdvdread: add option for libdvdcss
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         162197
>Category:       ports
>Synopsis:       [PATCH] multimedia/libdvdread: add option for libdvdcss
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    martymac
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 31 13:50:12 UTC 2011
>Closed-Date:    Tue Jan 17 14:50:25 UTC 2012
>Last-Modified:  Tue Jan 17 14:50:25 UTC 2012
>Originator:     Jimmy Olgeni
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD backoffice 8.2-STABLE FreeBSD 8.2-STABLE #1: Wed Oct 12 21:16:42 CEST 2011
>Description:
Add libdvdcss option, thus allowing tinderbox builds with libdvdcss enabled.

The default behavior was not changed.

Port maintainer (martymac@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- libdvdread-4.1.4.r1219.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/multimedia/libdvdread/Makefile,v
retrieving revision 1.39
diff -u -u -r1.39 Makefile
--- Makefile	3 Dec 2010 13:11:46 -0000	1.39
+++ Makefile	31 Oct 2011 13:44:45 -0000
@@ -22,10 +22,6 @@
 MAINTAINER=	martymac@FreeBSD.org
 COMMENT=	MPlayer version of the libdvdread project
 
-.if !defined(PACKAGE_BUILDING)
-LIB_DEPENDS=	dvdcss.${DVDCSS_LIBVERSION}:${PORTSDIR}/multimedia/libdvdcss
-.endif
-
 LICENSE=	GPLv2
 
 USE_BZIP2=	yes
@@ -42,6 +38,20 @@
 USE_GMAKE=	yes
 USE_LDCONFIG=	yes
 
+.if defined(PACKAGE_BUILDING)
+DVDCSS_OPTION=	off
+.else
+DVDCSS_OPTION=	on
+.endif
+
+OPTIONS=	DVDCSS "Include libdvdcss support" ${DVDCSS_OPTION}
+
+.include <bsd.port.pre.mk>
+
+.if !defined(WITH_DVDCSS)
+LIB_DEPENDS=	dvdcss.${DVDCSS_LIBVERSION}:${PORTSDIR}/multimedia/libdvdcss
+.endif
+
 # DVDCSS version hardcoded in src/dvd_input.c (dlopen'ed)
 DVDCSS_LIBVERSION=	3
 
@@ -51,4 +61,4 @@
 	@${REINPLACE_CMD} -E -e 's|(libdvdcss.so)\.2|\1.${DVDCSS_LIBVERSION}|' \
 		${WRKSRC}/src/dvd_input.c
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- libdvdread-4.1.4.r1219.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->martymac 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Oct 31 13:50:21 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162197 

From: "Ganael LAPLANCHE" <martymac@FreeBSD.org>
To: Jimmy Olgeni <olgeni@freebsd.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/162197: [PATCH] multimedia/libdvdread: add option for libdvdcss
Date: Thu,  3 Nov 2011 15:49:15 +0100 (CET)

 Hi Jimmy,
 
 > Add libdvdcss option, thus allowing tinderbox builds with
 > libdvdcss enabled.
 
 Thanks a lot for your patch (BTW I think you meant 'if
 !defined(WITHOUT_DVDCSS) [...]').
 
 As it could have a potential impact on several other ports (it should
 not, who knows...), I'll wait for 9.0-RELEASE to be out before
 committing it.
 
 Best regards,
 
 --
 Ganael LAPLANCHE <ganael.laplanche@martymac.org>
 http://www.martymac.org | http://contribs.martymac.org
 FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162197: commit references a PR
Date: Tue, 17 Jan 2012 14:35:33 +0000 (UTC)

 martymac    2012-01-17 14:35:18 UTC
 
   FreeBSD ports repository
 
   Modified files:
     multimedia/bombono   Makefile 
     multimedia/dvdauthor Makefile 
     multimedia/gmerlin-avdecoder Makefile 
     multimedia/gstreamer-plugins-dvd Makefile 
     multimedia/gstreamer-plugins-resindvd Makefile 
     multimedia/handbrake Makefile 
     multimedia/k9copy    Makefile 
     multimedia/kissdx    Makefile 
     multimedia/libdvdnav Makefile distinfo pkg-descr pkg-plist 
     multimedia/libdvdnav/files patch-configure2 
     multimedia/libdvdplay Makefile 
     multimedia/libdvdread Makefile distinfo pkg-descr pkg-plist 
     multimedia/libdvdread/files patch-configure2 
     multimedia/libxine   Makefile 
     multimedia/lsdvd     Makefile 
     multimedia/lxdvdrip  Makefile 
     multimedia/mmpython  Makefile 
     multimedia/mplayerxp Makefile 
     multimedia/ogmrip    Makefile 
     multimedia/ogmtools  Makefile 
     multimedia/py-kaa-metadata Makefile 
     multimedia/streamanalyze Makefile 
     multimedia/transcode Makefile 
     multimedia/vamps     Makefile 
     multimedia/vlc       Makefile 
     multimedia/xbmc      Makefile 
     multimedia/xbmc-pvr  Makefile 
     net/wizd             Makefile 
     sysutils/dvdbackup   Makefile 
     sysutils/k3b         Makefile 
     sysutils/k3b-kde4    Makefile 
     sysutils/vobcopy     Makefile 
     sysutils/vstrip      Makefile 
   Added files:
     multimedia/libdvdread/files patch-src.md5.c 
   Log:
   - Update libdvdread and libdvdnav to 4.2.0 and bump dependent ports' revisions
   - libdvdread: allow package building with libdvdcss if WITH_DVDCSS is set [1]
   - libdvdread/libdvdnav: fix endianness handling [2]
   
   Submitted by: olgeni [1], richo <richo@psych0tik.net> [2] (via mail to ports@)
   PR: ports/162197 [1]
   
   Revision  Changes    Path
   1.16      +1 -0      ports/multimedia/bombono/Makefile
   1.50      +1 -1      ports/multimedia/dvdauthor/Makefile
   1.28      +1 -1      ports/multimedia/gmerlin-avdecoder/Makefile
   1.17      +1 -1      ports/multimedia/gstreamer-plugins-dvd/Makefile
   1.3       +1 -1      ports/multimedia/gstreamer-plugins-resindvd/Makefile
   1.32      +1 -0      ports/multimedia/handbrake/Makefile
   1.21      +1 -1      ports/multimedia/k9copy/Makefile
   1.11      +1 -1      ports/multimedia/kissdx/Makefile
   1.41      +5 -11     ports/multimedia/libdvdnav/Makefile
   1.11      +2 -2      ports/multimedia/libdvdnav/distinfo
   1.3       +33 -3     ports/multimedia/libdvdnav/files/patch-configure2
   1.3       +1 -1      ports/multimedia/libdvdnav/pkg-descr
   1.10      +2 -2      ports/multimedia/libdvdnav/pkg-plist
   1.17      +1 -1      ports/multimedia/libdvdplay/Makefile
   1.40      +18 -14    ports/multimedia/libdvdread/Makefile
   1.11      +2 -2      ports/multimedia/libdvdread/distinfo
   1.3       +10 -5     ports/multimedia/libdvdread/files/patch-configure2
   1.1       +16 -0     ports/multimedia/libdvdread/files/patch-src.md5.c (new)
   1.5       +1 -1      ports/multimedia/libdvdread/pkg-descr
   1.8       +1 -1      ports/multimedia/libdvdread/pkg-plist
   1.176     +1 -1      ports/multimedia/libxine/Makefile
   1.21      +1 -1      ports/multimedia/lsdvd/Makefile
   1.32      +1 -1      ports/multimedia/lxdvdrip/Makefile
   1.26      +1 -1      ports/multimedia/mmpython/Makefile
   1.79      +1 -1      ports/multimedia/mplayerxp/Makefile
   1.68      +1 -1      ports/multimedia/ogmrip/Makefile
   1.31      +1 -1      ports/multimedia/ogmtools/Makefile
   1.11      +1 -1      ports/multimedia/py-kaa-metadata/Makefile
   1.8       +1 -1      ports/multimedia/streamanalyze/Makefile
   1.149     +1 -1      ports/multimedia/transcode/Makefile
   1.13      +1 -1      ports/multimedia/vamps/Makefile
   1.279     +1 -0      ports/multimedia/vlc/Makefile
   1.4       +1 -1      ports/multimedia/xbmc-pvr/Makefile
   1.14      +1 -1      ports/multimedia/xbmc/Makefile
   1.7       +1 -1      ports/net/wizd/Makefile
   1.20      +1 -1      ports/sysutils/dvdbackup/Makefile
   1.78      +1 -1      ports/sysutils/k3b-kde4/Makefile
   1.75      +1 -1      ports/sysutils/k3b/Makefile
   1.35      +1 -1      ports/sysutils/vobcopy/Makefile
   1.10      +1 -1      ports/sysutils/vstrip/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: martymac 
State-Changed-When: Tue Jan 17 14:50:23 UTC 2012 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162197 
>Unformatted:
