From ajk@tsunami.waterspout.com  Thu Jan 20 07:34:57 2000
Return-Path: <ajk@tsunami.waterspout.com>
Received: from tsunami.waterspout.com (tsunami.waterspout.com [208.13.56.11])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1E9C314D42; Thu, 20 Jan 2000 07:34:56 -0800 (PST)
	(envelope-from ajk@tsunami.waterspout.com)
Received: (from ajk@localhost)
	by tsunami.waterspout.com (8.9.3/8.9.2) id KAA89182;
	Thu, 20 Jan 2000 10:34:54 -0500 (EST)
	(envelope-from ajk)
Message-Id: <200001201534.KAA89182@tsunami.waterspout.com>
Date: Thu, 20 Jan 2000 10:34:54 -0500 (EST)
From: ajk@waterspout.com
Sender: ajk@tsunami.waterspout.com
Reply-To: ajk@waterspout.com
To: FreeBSD-gnats-submit@freebsd.org
Cc: ade@freebsd.org
Subject: [PATCH] gnome-terminal incompatible with ispell
X-Send-Pr-Version: 3.2

>Number:         16218
>Category:       ports
>Synopsis:       [PATCH] gnome-terminal incompatible with ispell
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ade
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 20 07:40:00 PST 2000
>Closed-Date:    Thu Jan 20 19:56:04 PST 2000
>Last-Modified:  Thu Jan 20 19:56:14 PST 2000
>Originator:     Andrew J. Korty
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
Waterspout Communmications
>Environment:

FreeBSD tempest.waterspout.com 4.0-CURRENT FreeBSD 4.0-CURRENT #24:
Sat Dec  4 08:11:45 EST 1999
root@tempest.waterspout.com:/usr/src/sys/compile/TEMPEST  i386

>Description:

Within gnome-terminal ispell locks up and starts beeping incessantly
when it starts accepting tty input.

>How-To-Repeat:

Run ispell within gnome-terminal.

>Fix:
	
Unlike other terminal emulators, gnome-terminal initializes VMIN
to 0 rather than 1.  I don't fully understand why this concept,
but setting VMIN to 1 (as in the following patch) fixes the problem.
Of course "stty min 1" also works.

I also took the liberty of setting sane deafults for the delayed
suspend and status characters.

--- gnome-pty-helper.c~	Wed Jan 19 17:51:43 2000
+++ gnome-pty-helper.c	Wed Jan 19 17:50:44 2000
@@ -454,7 +454,7 @@
 
 	/* These two may overlap so set them first */
 	term.c_cc[VTIME] =  0;
-	term.c_cc[VMIN] = 0;
+	term.c_cc[VMIN] = 1;
 	
 	/*
 	 * Now set the characters. This is of course a religious matter
@@ -484,6 +484,9 @@
 #ifdef VREPRINT	
 	term.c_cc[VREPRINT] = 'R'-64;
 #endif
+#ifdef VSTATUS
+	term.c_cc[VDSUSP] = 'T'-64;
+#endif
 #ifdef VDISCARD	
 	term.c_cc[VDISCARD] = 'O'-64;
 #endif
@@ -492,6 +495,9 @@
 #endif	
 #ifdef VLNEXT
 	term.c_cc[VLNEXT] =  'V'-64;
+#endif
+#ifdef VDSUSP
+	term.c_cc[VDSUSP] = 'Y'-64;
 #endif
 #ifdef VEOL2	
 	term.c_cc[VEOL2] = 0;

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->ade 
Responsible-Changed-By: ade 
Responsible-Changed-When: Thu Jan 20 14:46:48 PST 2000 
Responsible-Changed-Why:  
My port - I'll handle it 
State-Changed-From-To: open->closed 
State-Changed-By: ade 
State-Changed-When: Thu Jan 20 19:56:04 PST 2000 
State-Changed-Why:  
Update committed (with modifications), thanks! 
>Unformatted:
