From nalitoja@gmail.com  Wed Oct 26 01:19:43 2011
Return-Path: <nalitoja@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 13B171065678
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 26 Oct 2011 01:19:43 +0000 (UTC)
	(envelope-from nalitoja@gmail.com)
Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 9A6298FC16
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 26 Oct 2011 01:19:42 +0000 (UTC)
Received: by faar19 with SMTP id r19so1584338faa.13
        for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Oct 2011 18:19:41 -0700 (PDT)
Received: by 10.223.61.138 with SMTP id t10mr40220484fah.20.1319591981448;
        Tue, 25 Oct 2011 18:19:41 -0700 (PDT)
Received: from nil (exit-01c.noisetor.net. [173.254.216.68])
        by mx.google.com with ESMTPS id o16sm868341fag.21.2011.10.25.18.19.38
        (version=SSLv3 cipher=OTHER);
        Tue, 25 Oct 2011 18:19:40 -0700 (PDT)
Message-Id: <86vcrch7mt.fsf@gmail.com>
Date: Wed, 26 Oct 2011 01:19:22 +0000
From: Nali Toja <nalitoja@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] lang/sbcl: mark BROKEN on freebsd 9/10 (THREADS option)

>Number:         162017
>Category:       ports
>Synopsis:       [patch] lang/sbcl: mark BROKEN on freebsd 9/10 (THREADS option)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 26 01:20:07 UTC 2011
>Closed-Date:    Mon Nov 21 00:51:56 UTC 2011
>Last-Modified:  Fri Dec  9 13:00:21 UTC 2011
>Originator:     Nali Toja
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
>Description:
sb-thread is going to be broken on the upcoming 9.0-RELEASE. It doesn't
work with more than one thread, e.g. with editors/slime by default

  ;; excerpt from swank-sbcl.lisp
  (defimplementation preferred-communication-style ()
    (cond
      ;; fixme: when SBCL/win32 gains better select() support, remove
      ;; this.
      ((member :sb-thread *features*) :spawn)
      ((member :win32 *features*) nil)
      (t :fd-handler)))

cf. http://docs.freebsd.org/cgi/mid.cgi?86mxd7qdzk.fsf (call for help)
>How-To-Repeat:
>Fix:
--- broken.diff begins here ---
Index: lang/sbcl/Makefile
===================================================================
RCS file: /a/.csup/ports/lang/sbcl/Makefile,v
retrieving revision 1.90
diff -u -p -r1.90 Makefile
--- lang/sbcl/Makefile	14 Jul 2011 21:35:19 -0000	1.90
+++ lang/sbcl/Makefile	26 Oct 2011 01:01:29 -0000
@@ -88,6 +88,10 @@ WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVER
 
 .include <bsd.port.pre.mk>
 
+.if defined(WITH_THREADS) && ${OSVERSION} > 900027
+BROKEN=		'thread was already on queue' crash since libthr@r216641
+.endif
+
 .if !defined(NOPORTDOCS) || !defined(WITHOUT_PDF) || !defined(WITHOUT_PS)
 BUILD_DEPENDS=	dot:${PORTSDIR}/graphics/graphviz
 .endif
--- broken.diff ends here ---
>Release-Note:
>Audit-Trail:

From: Nali Toja <nalitoja@gmail.com>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/162017: [patch] lang/sbcl: mark BROKEN on freebsd 9/10 (THREADS option)
Date: Wed, 26 Oct 2011 01:30:49 +0000

 --=-=-=
 Content-Type: text/plain
 
 And to make it easier to test re-enable sb-thread tests disabled by ports/154050. 
 
 --=-=-=
 Content-Type: text/x-patch
 Content-Disposition: attachment; filename=tests.diff
 
 Index: lang/sbcl/files/patch-disable-failing-tests
 ===================================================================
 RCS file: /a/.csup/ports/lang/sbcl/files/patch-disable-failing-tests,v
 retrieving revision 1.3
 diff -u -p -r1.3 patch-disable-failing-tests
 --- lang/sbcl/files/patch-disable-failing-tests	14 Jul 2011 21:34:14 -0000	1.3
 +++ lang/sbcl/files/patch-disable-failing-tests	26 Oct 2011 01:26:44 -0000
 @@ -1,14 +1,5 @@
  --- contrib/sb-concurrency/tests/test-mailbox.lisp.orig	2011-06-05 12:35:33.000000000 -0700
  +++ contrib/sb-concurrency/tests/test-mailbox.lisp	2011-07-14 13:27:49.000000000 -0700
 -@@ -40,7 +40,7 @@
 - 
 - ;;; FIXME: Several tests disabled on Darwin due to hangs. Something not right
 - ;;; with mailboxes -- or possibly semaphores -- there.
 --#+(and sb-thread (not darwin))
 -+#+(and sb-thread (not (or darwin freebsd)))
 - (progn
 - 
 - ;; Dummy struct for ATOMIC-INCF to work.
  @@ -181,6 +181,7 @@
     (:errors   . 0)
     (:timeouts . 0))
 
 --=-=-=--
Responsible-Changed-From-To: freebsd-ports-bugs->bf 
Responsible-Changed-By: bf 
Responsible-Changed-When: Sat Nov 19 10:30:29 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162017 

From: Jan Beich <jbeich@tormail.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162017: [patch] lang/sbcl: mark BROKEN on freebsd 9/10 (THREADS option)
Date: Sat, 19 Nov 2011 20:28:08 +0200

 This seems to be fixed in git master, making BROKEN and all hunks in
 files/patch-disable-failing-tests unnecessary for both pre- and post-
 r216641 libthr.so.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162017: commit references a PR
Date: Mon, 21 Nov 2011 00:42:01 +0000 (UTC)

 bf          2011-11-21 00:39:56 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/sbcl            Makefile 
     lang/sbcl/files      patch-disable-failing-tests 
   Log:
   -fix builds on FreeBSD 9,10 [1]
   -temporarily mark WITH_THREADS as BROKEN on 9,10 [2]
   -fix NOPORTDOCS; add a regression-test alias for the test
    target; delay the patch clean-up to ease debugging; remove
    some lines dealing with unsupported versions of FreeBSD
   
   PR:             161502 [1], 162017 [2]
   Submitted by:   N. Toja [1,2]
   Feature safe:   yes
   
   Revision  Changes    Path
   1.93      +18 -19    ports/lang/sbcl/Makefile
   1.4       +2 -11     ports/lang/sbcl/files/patch-disable-failing-tests
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: bf 
State-Changed-When: Mon Nov 21 00:51:55 UTC 2011 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162017 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/162017: commit references a PR
Date: Fri,  9 Dec 2011 12:54:53 +0000 (UTC)

 bf          2011-12-09 12:54:45 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/sbcl            Makefile distinfo pkg-plist 
     lang/sbcl/files      customize-target-features.lisp 
     math/fricas          Makefile 
     math/maxima          Makefile pkg-message 
     math/open-axiom      Makefile 
     x11-wm/stumpwm       Makefile 
     x11-wm/cl-stumpwm    Makefile 
   Removed files:
     lang/sbcl/files      patch-contrib_sb-posix_posix-tests.lisp 
   Log:
   update lang/sbcl to 1.0.54, and adjust dependent ports (this allows sbcl to
   be build WITH_THREADS on recent versions of FreeBSD once again) [1]; rename
   *.core files in sbcl and math/maxima so that they are not removed by
   disk-cleaning scripts [2]; make it possible to use the makesum target in sbcl
   WITH_SBCL; fix maxima build WITH_CMUCL, and place a default memory cap of
   1GiB on amd64; reduce default output from a few targets in maxima, and defer
   patch cleaning to the pre-build target to make debugging easier
   
   PR:             162017 [1], 162680 [2]
   Approved by:    pav (portmgr)
   Feature safe:   yes
   
   Revision  Changes    Path
   1.96      +8 -14     ports/lang/sbcl/Makefile
   1.67      +2 -6      ports/lang/sbcl/distinfo
   1.3       +0 -1      ports/lang/sbcl/files/customize-target-features.lisp
   1.3       +0 -20     ports/lang/sbcl/files/patch-contrib_sb-posix_posix-tests.lisp (dead)
   1.48      +3 -1      ports/lang/sbcl/pkg-plist
   1.14      +1 -1      ports/math/fricas/Makefile
   1.73      +25 -13    ports/math/maxima/Makefile
   1.2       +5 -7      ports/math/maxima/pkg-message
   1.10      +1 -0      ports/math/open-axiom/Makefile
   1.13      +1 -1      ports/x11-wm/cl-stumpwm/Makefile
   1.11      +1 -1      ports/x11-wm/stumpwm/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
