From nobody@FreeBSD.org  Tue Oct 25 14:40:53 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 607451065670
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Oct 2011 14:40:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 5061C8FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Oct 2011 14:40:53 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p9PEeqAQ023325
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Oct 2011 14:40:52 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p9PEeqja023324;
	Tue, 25 Oct 2011 14:40:52 GMT
	(envelope-from nobody)
Message-Id: <201110251440.p9PEeqja023324@red.freebsd.org>
Date: Tue, 25 Oct 2011 14:40:52 GMT
From: Eugene Paskevich <eugene@raptor.kiev.ua>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [bash-completion] fails to complete portinstall
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         161999
>Category:       ports
>Synopsis:       shells/bash-completion fails to complete portinstall
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    adamw
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 25 14:50:06 UTC 2011
>Closed-Date:    Tue Oct 25 23:14:31 UTC 2011
>Last-Modified:  Wed Oct 26 23:10:01 UTC 2011
>Originator:     Eugene Paskevich
>Release:        irrelevant
>Organization:
>Environment:
irrelevant
>Description:
Due to a likely typo, portinstall command is unable to parse the port-tree INDEX file.
>How-To-Repeat:

>Fix:
--- portupgrade	2011-10-25 17:38:30.000000000 +0300
+++ portupgrade.proper	2011-10-25 17:39:39.000000000 +0300
@@ -26,7 +26,7 @@
 
     portsdir=${PORTSDIR:-/usr/ports}/
     _get_comp_words_by_ref cur prev
-	indexfile="$(portsdir)/INDEX-${OSTYPE:7:1}"
+	indexfile="${portsdir}INDEX-${OSTYPE:7:1}"
 
     [[ "$prev" == -l || "$prev" == -L || "$prev" == -o ]] && return 0

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->adamw 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Oct 25 14:52:38 UTC 2011 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161999 
State-Changed-From-To: open->closed 
State-Changed-By: adamw 
State-Changed-When: Tue Oct 25 23:13:46 UTC 2011 
State-Changed-Why:  
Committed. Thanks for catching, patching, and reporting this! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161999 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/161999: commit references a PR
Date: Tue, 25 Oct 2011 23:13:40 +0000 (UTC)

 adamw       2011-10-25 23:13:32 UTC
 
   FreeBSD ports repository
 
   Modified files:
     shells/bash-completion Makefile 
     shells/bash-completion/files patch-contrib_portupgrade 
   Log:
   Fix a // in path which apparently breaks portinstall's ability to parse
   INDEX.
   
   PR:             ports/161999
   Submitted by:   Eugene Paskevich <eugene@raptor.kiev.ua>
   
   Revision  Changes    Path
   1.27      +1 -1      ports/shells/bash-completion/Makefile
   1.4       +1 -1      ports/shells/bash-completion/files/patch-contrib_portupgrade
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: "Eugene Paskevich" <eugene@raptor.kiev.ua>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/161999: shells/bash-completion fails to complete
 portinstall
Date: Wed, 26 Oct 2011 12:08:01 +0300

 Hello, Adam!
 
 The problem is not the spare slash (that is just the cosmetic change).
 It's the braces that should replace parenthesis.
 Please commit that change too.
 
 -- 
 Eugene Paskevich             |   *==)-----------   |     Plug me into
 eugene@raptor.kiev.ua        |   -----------(==*   |      The Matrix

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/161999: commit references a PR
Date: Wed, 26 Oct 2011 22:32:17 +0000 (UTC)

 adamw       2011-10-26 22:32:03 UTC
 
   FreeBSD ports repository
 
   Modified files:
     shells/bash-completion Makefile 
     shells/bash-completion/files patch-contrib_portupgrade 
   Log:
   Fix a variable substitution.
   
   Note that this was the intended fix in PORTREVISION 3, the previous
   commit, and was the change intended by ports/161999.
   
   PR:             ports/161999
   Submitted by:   Eugene Paskevich <eugene@raptor.kiev.ua>
   
   Revision  Changes    Path
   1.28      +1 -1      ports/shells/bash-completion/Makefile
   1.5       +1 -1      ports/shells/bash-completion/files/patch-contrib_portupgrade
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Adam Weinberger <adamw@adamw.org>
To: Eugene Paskevich <eugene@raptor.kiev.ua>
Cc: bug-followup@freebsd.org
Subject: Re: ports/161999: shells/bash-completion fails to complete portinstall
Date: Wed, 26 Oct 2011 18:38:27 -0400

 --000e0ce0f83a82898204b03b50ca
 Content-Type: text/plain; charset=ISO-8859-1
 
 Yikes. Glad you were paying attention. I am really hoping I committed the
 right thing this time.
 
 # Adam
 
 
 -- 
 Adam Weinberger
 adamw@adamw.org
 http://www.adamw.org
 "Can you picture that?"
    - Animal, et. al
 
 --000e0ce0f83a82898204b03b50ca
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 Yikes. Glad you were paying attention. I am really hoping I committed the r=
 ight thing this time.<br><br># Adam<br><br clear=3D"all"><br>-- <br>Adam We=
 inberger<br><a href=3D"mailto:adamw@adamw.org" target=3D"_blank">adamw@adam=
 w.org</a><br>
 <a href=3D"http://www.adamw.org" target=3D"_blank">http://www.adamw.org</a>=
 <br>&quot;Can you picture that?&quot;<br>=A0=A0 - Animal, et. al<br><br>
 
 --000e0ce0f83a82898204b03b50ca--
>Unformatted:
