From nalitoja@gmail.com  Fri Oct 21 05:35:24 2011
Return-Path: <nalitoja@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 772C01065670
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 21 Oct 2011 05:35:24 +0000 (UTC)
	(envelope-from nalitoja@gmail.com)
Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 350E58FC13
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 21 Oct 2011 05:35:24 +0000 (UTC)
Received: by mail-yw0-f54.google.com with SMTP id 3so4539056ywm.13
        for <FreeBSD-gnats-submit@freebsd.org>; Thu, 20 Oct 2011 22:35:24 -0700 (PDT)
Received: by 10.236.155.2 with SMTP id i2mr19345963yhk.115.1319175324014;
        Thu, 20 Oct 2011 22:35:24 -0700 (PDT)
Received: from nil ([68.71.46.138])
        by mx.google.com with ESMTPS id f47sm814613yhh.8.2011.10.20.22.35.19
        (version=SSLv3 cipher=OTHER);
        Thu, 20 Oct 2011 22:35:23 -0700 (PDT)
Message-Id: <86sjmmap2x.fsf@gmail.com>
Date: Fri, 21 Oct 2011 05:30:46 +0000
From: Nali Toja <nalitoja@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] emulators/qemu-devel: respect STRIP

>Number:         161856
>Category:       ports
>Synopsis:       [patch] emulators/qemu-devel: respect STRIP
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    nox
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 21 05:40:10 UTC 2011
>Closed-Date:    Sat Oct 22 18:59:07 UTC 2011
>Last-Modified:  Sat Oct 22 19:00:35 UTC 2011
>Originator:     Nali Toja
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Do not strip uncoditionally, it makes system-wide profiling more cumbersome.
>How-To-Repeat:
$ make install STRIP=
$ qemu &

# qemu itself + libs/kernel
$ pmcstat -t qemu -P instructions -T

# system-wide with lots of noise from other apps
$ pmcstat -S instructions -T
>Fix:
--- strip.diff begins here ---
Index: emulators/qemu-devel/Makefile
===================================================================
RCS file: /a/.csup/ports/emulators/qemu-devel/Makefile,v
retrieving revision 1.128
diff -u -p -r1.128 Makefile
--- emulators/qemu-devel/Makefile	13 Oct 2011 19:08:30 -0000	1.128
+++ emulators/qemu-devel/Makefile	20 Oct 2011 01:30:58 -0000
@@ -145,6 +145,10 @@ MAKE_ARGS+=	NOPORTDOCS=${NOPORTDOCS}
 BUILD_DEPENDS+=	texi2html:${PORTSDIR}/textproc/texi2html
 .endif
 
+.if !defined(STRIP) || ${STRIP} == ""
+CONFIGURE_ARGS+=--disable-strip
+.endif
+
 .if ${ARCH} == "amd64"
 MAKE_ARGS+=	ARCH=x86_64
 .endif
--- strip.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->nox 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Oct 21 05:41:04 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161856 

From: Nali Toja <nalitoja@gmail.com>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/161856: [patch] emulators/qemu-devel: respect STRIP
Date: Fri, 21 Oct 2011 06:12:18 +0000

 Nali Toja <nalitoja@gmail.com> writes:
 
 >>Description:
 > Do not strip uncoditionally, it makes system-wide profiling more cumbersome.
 
 Also, STRIP is used by WITH_DEBUG in bsd.port.mk.
State-Changed-From-To: open->closed 
State-Changed-By: nox 
State-Changed-When: Sat Oct 22 18:59:06 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161856 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/161856: commit references a PR
Date: Sat, 22 Oct 2011 18:56:14 +0000 (UTC)

 nox         2011-10-22 18:56:05 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/qemu-devel Makefile pkg-plist 
   Log:
   - Respect CC (sgabios) [1]
   - Respect STRIP [2]
   - Respect NOPORTDOCS, even if it's empty [3]
   - Trim deps for -nographic [4]
   
   PR:             ports/161855 [1], ports/161856 [2], ports/161857 [3],
                   ports/161858 [4]
   Submitted by:   Nali Toja <nalitoja@gmail.com>
   
   Revision  Changes    Path
   1.129     +32 -8     ports/emulators/qemu-devel/Makefile
   1.32      +1 -1      ports/emulators/qemu-devel/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/161856: commit references a PR
Date: Sat, 22 Oct 2011 18:57:39 +0000 (UTC)

 nox         2011-10-22 18:57:32 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/qemu       Makefile 
   Log:
   - Respect STRIP [1]
   - Respect NOPORTDOCS, even if it's empty [2]
   
   PR:             ports/161856 [1], ports/161857 [2]
   Submitted by:   Nali Toja <nalitoja@gmail.com>
   
   Revision  Changes    Path
   1.121     +5 -1      ports/emulators/qemu/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
