From nalitoja@gmail.com  Fri Oct 21 05:35:12 2011
Return-Path: <nalitoja@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7CE8D106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 21 Oct 2011 05:35:12 +0000 (UTC)
	(envelope-from nalitoja@gmail.com)
Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 3EE038FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 21 Oct 2011 05:35:12 +0000 (UTC)
Received: by ywm3 with SMTP id 3so4539056ywm.13
        for <FreeBSD-gnats-submit@freebsd.org>; Thu, 20 Oct 2011 22:35:11 -0700 (PDT)
Received: by 10.146.173.8 with SMTP id v8mr1161205yae.36.1319175311583;
        Thu, 20 Oct 2011 22:35:11 -0700 (PDT)
Received: from nil ([68.71.46.138])
        by mx.google.com with ESMTPS id e4sm32739875ani.12.2011.10.20.22.35.03
        (version=SSLv3 cipher=OTHER);
        Thu, 20 Oct 2011 22:35:10 -0700 (PDT)
Message-Id: <86zkguap6f.fsf@gmail.com>
Date: Fri, 21 Oct 2011 05:28:40 +0000
From: Nali Toja <nalitoja@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] emulators/qemu-devel: respect CC (sgabios)

>Number:         161855
>Category:       ports
>Synopsis:       [patch] emulators/qemu-devel: respect CC (sgabios)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    nox
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 21 05:40:09 UTC 2011
>Closed-Date:    Sat Oct 22 18:58:57 UTC 2011
>Last-Modified:  Sat Oct 22 19:00:20 UTC 2011
>Originator:     Nali Toja
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
$ export PATH=~/.bin:$PATH
$ for cc in CC cc c++ gcc g++; do ln -s /usr/bin/false ~/.bin/${cc}; done

# everything is `off'
$ make showconfig | fgrep \=on
>Description:
Also, make gmake(1) print directory before desceding into it

  gmake: Entering directory `WRKDIR/sgabios-read-only'

As .depend target failed just after `cd' it required a bit of guesswork
to deduce where the error occured.
>How-To-Repeat:
$ printf 'CC=clang\nCXX=clang++\nCPP=clang -E\n' >>/etc/make.conf
$ make V=1
[...]
rm -f .depend
cc -E -M -Wall -Os -m32 -nostdlib  sgabios.S >.tmpdepend && mv .tmpdepend .depend
gmake: *** [.depend] Error 1
*** Error code 2
>Fix:
--- cc.diff begins here ---
Index: emulators/qemu-devel/Makefile
===================================================================
RCS file: /a/.csup/ports/emulators/qemu-devel/Makefile,v
retrieving revision 1.128
diff -u -p -r1.128 Makefile
--- emulators/qemu-devel/Makefile	13 Oct 2011 19:08:30 -0000	1.128
+++ emulators/qemu-devel/Makefile	20 Oct 2011 01:30:58 -0000
@@ -193,7 +197,7 @@ post-configure:
 .endif
 
 post-build:
-	@(cd ${WRKDIR}/sgabios-read-only && ${GMAKE})
+	@${MAKE_ENV} ${GMAKE} -C${WRKDIR}/sgabios-read-only
 
 post-install:
 .if !defined(NOPORTDOCS)
--- cc.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->nox 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Oct 21 05:40:59 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161855 
State-Changed-From-To: open->closed 
State-Changed-By: nox 
State-Changed-When: Sat Oct 22 18:58:56 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161855 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/161855: commit references a PR
Date: Sat, 22 Oct 2011 18:56:13 +0000 (UTC)

 nox         2011-10-22 18:56:05 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/qemu-devel Makefile pkg-plist 
   Log:
   - Respect CC (sgabios) [1]
   - Respect STRIP [2]
   - Respect NOPORTDOCS, even if it's empty [3]
   - Trim deps for -nographic [4]
   
   PR:             ports/161855 [1], ports/161856 [2], ports/161857 [3],
                   ports/161858 [4]
   Submitted by:   Nali Toja <nalitoja@gmail.com>
   
   Revision  Changes    Path
   1.129     +32 -8     ports/emulators/qemu-devel/Makefile
   1.32      +1 -1      ports/emulators/qemu-devel/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
