From jhelfman@experts-exchange.com  Wed Oct 19 20:27:46 2011
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 826CC106566B;
	Wed, 19 Oct 2011 20:27:46 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.experts-exchange.com (mail.experts-exchange.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 6221B8FC0C;
	Wed, 19 Oct 2011 20:27:46 +0000 (UTC)
Received: from mail.experts-exchange.com (localhost [127.0.0.1])
	by mail.experts-exchange.com (Postfix) with ESMTP id 17BCD6FF5AF;
	Wed, 19 Oct 2011 13:27:46 -0700 (PDT)
Received: from mail.experts-exchange.com ([127.0.0.1])
	by mail.experts-exchange.com (mail.experts-exchange.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id dC2FwVNLai6n; Wed, 19 Oct 2011 13:27:45 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.122])
	by mail.experts-exchange.com (Postfix) with SMTP id E660D6FF5AA;
	Wed, 19 Oct 2011 13:27:45 -0700 (PDT)
Received: (nullmailer pid 66054 invoked by uid 1001);
	Wed, 19 Oct 2011 20:27:45 -0000
Message-Id: <1319056065.664453.66053.nullmailer@experts-exchange.com>
Date: Wed, 19 Oct 2011 13:27:45 -0700
From: Jason Helfman <jhelfman@experts-exchange.com>
Reply-To: Jason Helfman <jhelfman@experts-exchange.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: pav@freebsd.org, crees@freebsd.org, girgen@freebsd.org
Subject: [patch] databases/postgresql90-server: cleanup plist
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         161821
>Category:       ports
>Synopsis:       [patch] databases/postgresql90-server: cleanup plist
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 19 20:30:13 UTC 2011
>Closed-Date:    Thu Oct 20 21:14:33 UTC 2011
>Last-Modified:  Thu Oct 20 21:14:33 UTC 2011
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE i386
>Organization:
Experts Exchange, LLC.
>Environment:
System: FreeBSD eggman.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:
http://pointyhat.FreeBSD.org/errorlogs/amd64-errorlogs/a.9.20111019081335/postgresql-server-9.0.5.log
Cleanup properly
Builds cleanly in updated tinderbox => http://jgh.devio.us/files/logs/postgresql-server-9.0.5_1.log
An obmitted PLIST_SUB from previous commit was part of the issue. The other issue is that it wasn't in the plist to cleanup.
>How-To-Repeat:
	
>Fix:

Index: Makefile
===================================================================
RCS file: /home/jhelfman/ncvs/ports/databases/postgresql90-server/Makefile,v
retrieving revision 1.229
diff -u -r1.229 Makefile
--- Makefile	19 Oct 2011 18:29:58 -0000	1.229
+++ Makefile	19 Oct 2011 20:21:23 -0000
@@ -306,6 +306,7 @@
 SUB_LIST+=	PG_GROUP=$(PG_GROUP) \
 		PG_USER=$(PG_USER) \
 		PG_UID=$(PG_UID)
+PLIST_SUB+=	PG_USER=${PG_USER}
 
 .if defined(SERVER_ONLY)
 pre-everything::
Index: pkg-plist-server
===================================================================
RCS file: /home/jhelfman/ncvs/ports/databases/postgresql90-server/pkg-plist-server,v
retrieving revision 1.34
diff -u -r1.34 pkg-plist-server
--- pkg-plist-server	18 Oct 2011 09:03:32 -0000	1.34
+++ pkg-plist-server	19 Oct 2011 20:20:42 -0000
@@ -775,3 +775,4 @@
 @dirrmtry etc/periodic/daily
 @dirrmtry etc/periodic
 @dirrmtry lib/postgresql
+@dirrmtry %%PG_USER%%
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->girgen 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Oct 19 20:30:25 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161821 

From: Jason Helfman <jhelfman@e-e.com>
To: bug-followup@freebsd.org
Cc: pav@freebsd.org, crees@freebsd.org, girgen@freebsd.org
Subject: Re: ports/161821: [patch] databases/postgresql90-server: cleanup
 plist
Date: Wed, 19 Oct 2011 13:44:31 -0700

 Same patch will work for 83-server
 See log here => http://jgh.devio.us/files/logs/postgresql-server-8.3.16_1.log
 
 -jgh
 
 -- 
 Jason Helfman
 System Administrator
 experts-exchange.com
 http://www.experts-exchange.com/M_4830110.html
 E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
Responsible-Changed-From-To: girgen->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Thu Oct 20 20:52:24 UTC 2011 
Responsible-Changed-Why:  
I'm dealing with this problem right now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161821 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/161821: commit references a PR
Date: Thu, 20 Oct 2011 21:07:38 +0000 (UTC)

 crees       2011-10-20 21:07:29 UTC
 
   FreeBSD ports repository
 
   Modified files:
     databases/postgresql82-server Makefile pkg-plist-server 
     databases/postgresql83-server Makefile pkg-plist-server 
     databases/postgresql84-server Makefile pkg-plist-server 
     databases/postgresql90-server Makefile pkg-plist-server 
     databases/postgresql91-server Makefile pkg-plist-server 
   Log:
   - Fix packaging issue (missed %%PG_USER%% in pkg-plist-server)
   - Remove extra bsd.port.pre.mk include from postgresql82-server
   
   PR:             ports/161816 ports/161824 ports/161821
   Submitted by:   Jason Helfman (jhelfman@e-e.com)
   Approved by:    portmgr (pav)
   
   Revision  Changes    Path
   1.204     +1 -2      ports/databases/postgresql82-server/Makefile
   1.22      +1 -0      ports/databases/postgresql82-server/pkg-plist-server
   1.217     +1 -0      ports/databases/postgresql83-server/Makefile
   1.29      +1 -0      ports/databases/postgresql83-server/pkg-plist-server
   1.235     +1 -0      ports/databases/postgresql84-server/Makefile
   1.35      +1 -0      ports/databases/postgresql84-server/pkg-plist-server
   1.230     +1 -0      ports/databases/postgresql90-server/Makefile
   1.35      +1 -0      ports/databases/postgresql90-server/pkg-plist-server
   1.231     +1 -0      ports/databases/postgresql91-server/Makefile
   1.38      +1 -0      ports/databases/postgresql91-server/pkg-plist-server
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Thu Oct 20 21:14:32 UTC 2011 
State-Changed-Why:  
Fixed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161821 
>Unformatted:
