From cjr@cruwe.de  Fri Oct 14 19:35:42 2011
Return-Path: <cjr@cruwe.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 636E0106567C
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 14 Oct 2011 19:35:42 +0000 (UTC)
	(envelope-from cjr@cruwe.de)
Received: from cruwe.de (cruwe.de [188.40.164.98])
	by mx1.freebsd.org (Postfix) with ESMTP id 29B9A8FC16
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 14 Oct 2011 19:35:41 +0000 (UTC)
Received: from cruwe.de (unknown [127.0.0.4])
	by cruwe.de (Postfix) with ESMTP id 0573F28472
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 14 Oct 2011 19:20:08 +0000 (UTC)
Received: by cruwe.de (Postfix, from userid 1001)
	id D5BA428471; Fri, 14 Oct 2011 19:20:07 +0000 (UTC)
Message-Id: <20111014192007.D5BA428471@cruwe.de>
Date: Fri, 14 Oct 2011 19:20:07 +0000 (UTC)
From: Christopher J. Ruwe <cjr@cruwe.de>
Reply-To: Christopher J. Ruwe <cjr@cruwe.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: graphics/vigra dependacy hdf5.7 is unnecessary and obstructive
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         161666
>Category:       ports
>Synopsis:       graphics/vigra dependacy hdf5.7 is unnecessary and obstructive
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    vd
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 14 19:40:02 UTC 2011
>Closed-Date:    Thu Feb 09 22:41:18 UTC 2012
>Last-Modified:  Thu Feb 09 23:03:27 UTC 2012
>Originator:     Christopher J. Ruwe <cjr@cruwe.de>
>Release:        FreeBSD 8.2-STABLE
>Organization:
>Environment:
 amd64 Environment:
 System: FreeBSD dijkstra.cruwe.de 8.2-STABLE FreeBSD 8.2-STABLE #0: Sat
 Aug 27 12:42:02 UTC 2011
 root@:/usr/obj/zroot/rootnode/usr/src/8/sys/DIJKSTRA amd64
 
>Description:
	Installing editors/libreoffice pulls in graphics/vigra as
	dependency. For graphics/vigra, hdf5.7 is hardcoded into port as
	dependency (science/hdf5-18), which said hdf5-18 does not supply.
	The reason making the port dependant on hdf5.7 escapes me, as in
	the port graphics/vigra a comment states that the port would
	compile without the "dependancy", which it does after manually
	removing the corresponing LIB_DEPENDS statement.
>How-To-Repeat:
	Update ports-tree, update hdf5-18 and try installing
	graphics/vigra from ports. Port will not compile.
>Fix:
	Remove LIB_DEPENDS statement for hdf5.7 from port
	science/hdf5-18. Patch included. Alternatively, remark on that
	issue in UPDATING. 



--- vigra-withouthdf.patch begins here ---
diff -u /usr/ports/graphics/vigra/Makefile vigra/Makefile
--- /usr/ports/graphics/vigra/Makefile	2011-10-14 20:52:03.319235984 +0200
+++ vigra/Makefile	2011-10-14 20:59:44.180947070 +0200
@@ -55,8 +55,4 @@
 LIB_DEPENDS+=	fftw3:${PORTSDIR}/math/fftw3
 .endif
 
-.if !defined(WITHOUT_VIGRA_HDF5)
-LIB_DEPENDS+=	hdf5.7:${PORTSDIR}/science/hdf5-18
-.endif
-
 .include <bsd.port.mk>
diff -u /usr/ports/graphics/vigra/Makefile~ vigra/Makefile~
--- /usr/ports/graphics/vigra/Makefile~	2011-10-14 20:23:26.151600812 +0200
+++ vigra/Makefile~	2011-10-14 20:53:02.090705561 +0200
@@ -55,8 +55,8 @@
 LIB_DEPENDS+=	fftw3:${PORTSDIR}/math/fftw3
 .endif
 
-#.if !defined(WITHOUT_VIGRA_HDF5)
-#LIB_DEPENDS+=	hdf5.7:${PORTSDIR}/science/hdf5-18
-#.endif
+.if !defined(WITHOUT_VIGRA_HDF5)
+LIB_DEPENDS+=	hdf5.7:${PORTSDIR}/science/hdf5-18
+.endif
 
 .include <bsd.port.mk>
--- vigra-withouthdf.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->vd 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Oct 14 19:40:21 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161666 
State-Changed-From-To: open->feedback 
State-Changed-By: vd 
State-Changed-When: Tue Oct 18 08:55:04 UTC 2011 
State-Changed-Why:  
Hi, 

This is the reason for the way the hdf dependency is specified, 
from Makefile: 

# Vigra's CMakeLists.txt does not support disabling those so we hook them 
# as dependencies here unconditionally (without OPTIONS=) even though if 
# they are not present then Vigra/CMake will do without them (they are not 
# mandatory). 
# 
# Notice that if you define e.g. WITHOUT_VIGRA_TIFF and graphics/tiff is 
# installed on your system, then the lib will be picked up by Vigra, the 
# dependency will not be recorded by the ports system and later deletion 
# of graphics/tiff will break Vigra. Only define WITHOUT_VIGRA_TIFF if you 
# do not have graphics/tiff installed and do not want TIFF support in Vigra. 

and from the CVS logs: 

revision 1.23 
date: 2011/07/01 07:13:48;  author: vd;  state: Exp;  lines: +2 -1 
Request explicitly the lib hdf5.6 because if we ask for hdf5 then portmaster 
considers that an installed version of science/hdf5 satisfies the dependency. 
---------------------------- 
revision 1.22 
date: 2011/06/29 11:42:48;  author: vd;  state: Exp;  lines: +1 -1 
Use science/hdf5-18 instead of science/hdf5 as dependency 

In testing I used science/hdf5-18 but have somehow written science/hdf5 
in the Makefile and it worked because the same lib is provided by 
science/hdf5 too. This should fix [1]. 

PR:             ports/158425 [1] 
Submitted by:   Andrei Lavreniyuk <andy.lavr@gmail.com> 

You say 

Update ports-tree, update hdf5-18 and try installing 
graphics/vigra from ports. Port will not compile. 

but are you sure about this? science/hdf5-18 should install 
/usr/local/lib/libhdf5.so.7 which should be picked by the dep line: 

LIB_DEPENDS+=	hdf5.7:${PORTSDIR}/science/hdf5-18 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161666 
State-Changed-From-To: feedback->open 
State-Changed-By: pgollucci 
State-Changed-When: Thu Feb 9 02:34:54 UTC 2012 
State-Changed-Why:  
submitter timeout (Christopher J. Ruwe <cjr@cruwe.de> ; 108 days) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161666 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Thu Feb 9 22:41:17 UTC 2012 
State-Changed-Why:  


I am most sorry to have timed out ... I was very busy at that time and
completely missed that. 

After having uograded to 9-stable and having done a complete rebuild, I
cannot reproduce the issue any more.

I think the PR can be closed.

Thanks and, again, sorry, cheers
Christopher
Closed at submitter request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161666 
>Unformatted:
