From aehlig@linta.de  Thu Sep 29 03:37:30 2011
Return-Path: <aehlig@linta.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 16CBB1065678
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 29 Sep 2011 03:37:30 +0000 (UTC)
	(envelope-from aehlig@linta.de)
Received: from linta.de (isilmar-3.linta.de [188.40.101.200])
	by mx1.freebsd.org (Postfix) with ESMTP id 535488FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 29 Sep 2011 03:37:28 +0000 (UTC)
Received: (qmail 2828 invoked by uid 10); 29 Sep 2011 03:10:47 -0000
Received: from curry.linta.de by isilmar.linta.de with BSMTP; 29 Sep 2011 03:10:47 -0000
Received: by curry.linta.de (Postfix, from userid 1001)
	id EE73C1CC1D; Thu, 29 Sep 2011 04:10:33 +0100 (BST)
Message-Id: <20110929031033.EE73C1CC1D@curry.linta.de>
Date: Thu, 29 Sep 2011 04:10:33 +0100 (BST)
From: Klaus Aehlig <aehlig@linta.de>
Reply-To: Klaus Aehlig <aehlig@linta.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] games/sl fix build under clang
X-Send-Pr-Version: 3.113
X-GNATS-Notify: hym@cocoa.freemail.ne.jp

>Number:         161117
>Category:       ports
>Synopsis:       [patch] games/sl fix build under clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pawel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 29 03:40:09 UTC 2011
>Closed-Date:    Tue Nov 01 18:28:50 UTC 2011
>Last-Modified:  Tue Nov  1 18:30:06 UTC 2011
>Originator:     Klaus Aehlig
>Release:        FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD curry.linta.de 8.2-STABLE FreeBSD 8.2-STABLE #14: Wed Sep 28 23:31:53 BST 2011 root@curry.linta.de:/usr/obj/usr/src/sys/CURRY amd64

>Description:
	games/sl fails to build with CC=clang
>How-To-Repeat:
	cd /usr/ports/games/sl && make build CC=clang
>Fix:

	put the following patch in the files subdirectory (the latter has to be created)

	This patches also fixes the clang compiler warnings.

--- patch-sl.c begins here ---
--- sl.c.orig	1998-07-22 15:01:01.000000000 +0100
+++ sl.c	2011-09-29 03:59:40.000000000 +0100
@@ -32,6 +32,11 @@
 #include <unistd.h>
 #include "sl.h"
 
+void add_man(int, int);
+int add_D51(int);
+int add_sl(int);
+void add_smoke(int,int);
+
 int ACCIDENT  = 0;
 int LOGO      = 0;
 int FLY       = 0;
@@ -59,7 +64,7 @@
     }
 }
 
-void main(int argc, char *argv[])
+int main(int argc, char *argv[])
 {
     int x, i;
 
@@ -85,6 +90,8 @@
     }
     mvcur(0, COLS - 1, LINES - 1, 0);
     endwin();
+
+    return 0;
 }
 
 
@@ -129,7 +136,7 @@
 }
 
 
-add_D51(int x)
+int add_D51(int x)
 {
     static char *d51[D51PATTERNS][D51HIGHT + 1]
 	= {{D51STR1, D51STR2, D51STR3, D51STR4, D51STR5, D51STR6, D51STR7,
@@ -170,7 +177,7 @@
 }
 
 
-int add_man(int y, int x)
+void add_man(int y, int x)
 {
     static char *man[2][2] = {{"", "(O)"}, {"Help!", "\\O/"}};
     int i;
@@ -181,7 +188,7 @@
 }
 
 
-int add_smoke(int y, int x)
+void add_smoke(int y, int x)
 #define SMOKEPTNS	16
 {
     static struct smokes {
--- patch-sl.c ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Sep 29 03:40:18 UTC 2011 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161117 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: hym@cocoa.freemail.ne.jp
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/161117: [patch] games/sl fix build under clang
Date: Thu, 29 Sep 2011 03:40:17 UT

 Maintainer of games/sl,
 
 Please note that PR ports/161117 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161117
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->pawel 
Responsible-Changed-By: pawel 
Responsible-Changed-When: Tue Nov 1 17:56:10 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161117 
State-Changed-From-To: feedback->closed 
State-Changed-By: pawel 
State-Changed-When: Tue Nov 1 18:28:49 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161117 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/161117: commit references a PR
Date: Tue,  1 Nov 2011 18:28:52 +0000 (UTC)

 pawel       2011-11-01 18:28:33 UTC
 
   FreeBSD ports repository
 
   Added files:
     games/sl/files       patch-sl.c 
   Log:
   Fix build with clang
   
   PR:             ports/161117
   Submitted by:   Klaus Aehlig <aehlig@linta.de>
   Approved by:    maintainer timeout (4 weeks)
   
   Revision  Changes    Path
   1.1       +59 -0     ports/games/sl/files/patch-sl.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
