From nobody@FreeBSD.org  Thu Sep 22 09:39:46 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4490A106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Sep 2011 09:39:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 331F48FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Sep 2011 09:39:46 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8M9dj5S024273
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Sep 2011 09:39:45 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p8M9djor024272;
	Thu, 22 Sep 2011 09:39:45 GMT
	(envelope-from nobody)
Message-Id: <201109220939.p8M9djor024272@red.freebsd.org>
Date: Thu, 22 Sep 2011 09:39:45 GMT
From: Petr Lampa <lampa@fit.vutbr.cz>
To: freebsd-gnats-submit@FreeBSD.org
Subject: net-snmp-5.7_3 TCP-MIB::tcpCurrEstab.0 returns 0
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160900
>Category:       ports
>Synopsis:       net-mgmt/net-snmp 5.7_3 TCP-MIB::tcpCurrEstab.0 returns 0
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    zi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 22 09:40:08 UTC 2011
>Closed-Date:    Thu Nov 24 13:11:57 UTC 2011
>Last-Modified:  Thu Nov 24 13:11:57 UTC 2011
>Originator:     Petr Lampa
>Release:        8.2-STABLE
>Organization:
BUT FIT
>Environment:
FreeBSD xxxx 8.2-STABLE FreeBSD 8.2-STABLE #42: Tue Aug 16 09:51:21
>Description:
After upgrade to net-snmp 5.7 counter of TCP connections stopped working:

snmpget -c public -v2c xxx .1.3.6.1.2.1.6.9.0
TCP-MIB::tcpCurrEstab.0 = Gauge32: 0

The reason is this change in net-snmp source ./work/net-snmp-5.7/agent/mibgroup/mibII/tcp.c

#ifdef NETSNMP_FEATURE_HAS_TCP_COUNT_CONNECTIONS
        ret_value = TCP_Count_Connections();
#else /*  NETSNMP_FEATURE_HAS_TCP_COUNT_CONNECTIONS */
        ret_value = 0;
#endif /*  NETSNMP_FEATURE_HAS_TCP_COUNT_CONNECTIONS */

The define NETSNMP_FEATURE_HAS_TCP_COUNT_CONNECTIONS is not defined. After addition here:

#define NETSNMP_FEATURE_HAS_TCP_COUNT_CONNECTIONS
#ifdef NETSNMP_FEATURE_HAS_TCP_COUNT_CONNECTIONS
        ret_value = TCP_Count_Connections();
#else /*  NETSNMP_FEATURE_HAS_TCP_COUNT_CONNECTIONS */
        ret_value = 0;
#endif /*  NETSNMP_FEATURE_HAS_TCP_COUNT_CONNECTIONS */

counter works again:

snmpget -c public -v2c xxx .1.3.6.1.2.1.6.9.0
TCP-MIB::tcpCurrEstab.0 = Gauge32: 1094


>How-To-Repeat:

>Fix:
Delete #ifdef or #define NETSNMP_FEATURE_HAS_TCP_COUNT_CONNECTIONS in proper place.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sylvio 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Sep 22 09:55:17 UTC 2011 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160900 
Responsible-Changed-From-To: sylvio->zi 
Responsible-Changed-By: zi 
Responsible-Changed-When: Tue Nov 15 17:02:18 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160900 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160900: commit references a PR
Date: Thu, 24 Nov 2011 13:07:05 +0000 (UTC)

 zi          2011-11-24 13:06:52 UTC
 
   FreeBSD ports repository
 
   Added files:
     net-mgmt/net-snmp/files patch-agent__mibgroup__mibII__tcp.c 
   Log:
   - Fix TCP-MIB::tcpCurrEstab.0 reporting
   
   PR:             ports/160900
   Submitted by:   Petr Lampa <lampa@fit.vutbr.cz>
   Obtained from:  upstream commit 87a31bbc009c9515a26c86317475f8384bd70e1b
   Approved by:    maintainer (implicit)
   Feature safe:   yes
   
   Revision  Changes    Path
   1.1       +20 -0     ports/net-mgmt/net-snmp/files/patch-agent__mibgroup__mibII__tcp.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: zi 
State-Changed-When: Thu Nov 24 13:11:54 UTC 2011 
State-Changed-Why:  
A fix has been committed and is present in net-snmp-5.7_5. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160900 
>Unformatted:
