From jhelfman@experts-exchange.com  Wed Sep 14 04:52:30 2011
Return-Path: <jhelfman@experts-exchange.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EBE5C106566B;
	Wed, 14 Sep 2011 04:52:30 +0000 (UTC)
	(envelope-from jhelfman@experts-exchange.com)
Received: from mail.experts-exchange.com (mail.experts-exchange.com [72.29.183.251])
	by mx1.freebsd.org (Postfix) with ESMTP id CE3BC8FC15;
	Wed, 14 Sep 2011 04:52:30 +0000 (UTC)
Received: from mail.experts-exchange.com (localhost [127.0.0.1])
	by mail.experts-exchange.com (Postfix) with ESMTP id 769B26F03C4;
	Tue, 13 Sep 2011 21:52:30 -0700 (PDT)
Received: from mail.experts-exchange.com ([127.0.0.1])
	by mail.experts-exchange.com (mail.experts-exchange.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id I95HtMEf6JAz; Tue, 13 Sep 2011 21:52:30 -0700 (PDT)
Received: from experts-exchange.com (unknown [192.168.103.122])
	by mail.experts-exchange.com (Postfix) with SMTP id 539A56F03B1;
	Tue, 13 Sep 2011 21:52:30 -0700 (PDT)
Received: (nullmailer pid 77271 invoked by uid 1001);
	Wed, 14 Sep 2011 04:51:29 -0000
Message-Id: <1315975889.936077.77270.nullmailer@experts-exchange.com>
Date: Tue, 13 Sep 2011 21:51:29 -0700
From: Jason Helfman <zenoss@experts-exchange.com>
Reply-To: Jason Helfman <zenoss@experts-exchange.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: crees@freebsd.org
Subject: [patch][maintainer-update] Mk/bsd.zenoss.mk : remove USE_ZIP
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         160723
>Category:       ports
>Synopsis:       [patch][maintainer-update] Mk/bsd.zenoss.mk : remove USE_ZIP
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 14 05:00:19 UTC 2011
>Closed-Date:    Fri Sep 16 18:44:18 UTC 2011
>Last-Modified:  Fri Sep 16 19:00:19 UTC 2011
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE i386
>Organization:
Experts Exchange, LLC.
>Environment:
System: FreeBSD eggman.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:
There are some zenpacks that don't have zipfiles, and having this defined is causing issues.
Remove it, and address in individual ports.

This was found in ports/160290

>How-To-Repeat:
	
>Fix:

Index: Mk/bsd.zenoss.mk
===================================================================
RCS file: /home/jhelfman/ncvs/ports/Mk/bsd.zenoss.mk,v
retrieving revision 1.1
diff -u -r1.1 bsd.zenoss.mk
--- Mk/bsd.zenoss.mk	1 Sep 2011 16:08:01 -0000	1.1
+++ Mk/bsd.zenoss.mk	14 Sep 2011 04:46:01 -0000
@@ -15,7 +15,6 @@
 RUN_DEPENDS+=	zenoss>=3.1.0:${PORTSDIR}/net-mgmt/zenoss
 
 FETCH_ARGS?=	-o - > ${DISTDIR}/${DISTFILES}
-USE_ZIP?=		yes
 
 PKGNAMEPREFIX:=	zenpack-${ZPACKGROUP}-
 
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Thu Sep 15 18:29:43 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160723 
State-Changed-From-To: open->closed 
State-Changed-By: crees 
State-Changed-When: Fri Sep 16 18:44:17 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160723 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/160723: commit references a PR
Date: Fri, 16 Sep 2011 18:52:17 +0000 (UTC)

 crees       2011-09-16 18:44:08 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.zenoss.mk 
   Log:
   Stop hardcoding USE_ZIP -- distfiles are not always zipped.
   
   PR:             ports/160723
   Submitted by:   Jason Helfman <zenoss@experts-exchange.com> (maintainer)
   
   Revision  Changes    Path
   1.2       +1 -2      ports/Mk/bsd.zenoss.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
